Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp221370img; Wed, 20 Mar 2019 18:29:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqyBuy57qXSC/kB4C481RuuhlqzlH6RfFicoCz0YHzIJD5D8HU9UIITVSkyusDkIf0srypHu X-Received: by 2002:aa7:9103:: with SMTP id 3mr812280pfh.192.1553131784675; Wed, 20 Mar 2019 18:29:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553131784; cv=none; d=google.com; s=arc-20160816; b=F4HgDS4iT8lsNuKwmo81GpoUuGg75JuMc0tAE3+1RvIbPGhRSZ9YdeHpJIg2I8cVsO ibmXKDmhzaDGkvaungdaeUIhfaE6a5OIhDwyXPZ0WAWZmpvDy68wM3RZ5eTVTnFt69Ki C19bywdOwG8+v4wsXhFYOxnxIRfuSM22VUuzevxHgQq48Ok8WZ6O1UQX3xZ1jDu0acfj bop2jwcFEyXkkHn/pVToD9PNQYSYv9eoiHI50yDfTOzSLgj76caSpZDn2X6qeyo/uleR 8kJ27JSB2M9bD/emYmiAdCTIjJ+aabIOiMui7rOfQ0fgylJvvE8EH8dy1D4PKrgkMkgg XbSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=T0+SBSdOttaeAnFeh+HiVWPixLV2Bt2+R1x9DMvR6oo=; b=i4UW78LEdRG3DByhzFk/RS7+pa6lKLYZl6yyKJWReoOTvj7p8yR28hergsjFGMUjlk ftyw7S6qbnHq2FzC0GKiqOzMcpag9IqHdmHCHE6OvqkhnkNjuZQRFnC5ve7Q4cu9cfJG iw004PglT8MSuHx00OhZ7MfgapPd7aoAOWbi/GarxLampMfwG+v7Nv5eb0gdoHbRVFIG J53CXX85m7cONVZdsQTgsg8cze0mJ/7EoB/Eyft9jwxceKVvETbY6AX4ECVGUsRyCua9 +xXigehXpxecmDrq/8Ytyrh7Laz1ESF0zJYGUWgSqzfKNUHtdOO2vRqsZEkdquTUVvPl KIWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i11si2975485pgs.85.2019.03.20.18.29.29; Wed, 20 Mar 2019 18:29:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727756AbfCUB2w (ORCPT + 99 others); Wed, 20 Mar 2019 21:28:52 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:49951 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726753AbfCUB2w (ORCPT ); Wed, 20 Mar 2019 21:28:52 -0400 X-UUID: 6f326823894b4e0c88d15f58e88b5a68-20190321 X-UUID: 6f326823894b4e0c88d15f58e88b5a68-20190321 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 351178939; Thu, 21 Mar 2019 09:28:44 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 21 Mar 2019 09:28:42 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 21 Mar 2019 09:28:42 +0800 Message-ID: <1553131722.18216.10.camel@mtksdaap41> Subject: Re: [PATCH v2] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable() From: CK Hu To: Hsin-Yi Wang CC: , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , , , Date: Thu, 21 Mar 2019 09:28:42 +0800 In-Reply-To: <20190320071825.20268-1-hsinyi@chromium.org> References: <20190320071825.20268-1-hsinyi@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Hsin-yi: On Wed, 2019-03-20 at 15:18 +0800, Hsin-Yi Wang wrote: > mtk_dsi_stop() should be called after mtk_drm_crtc_atomic_disable(), which needs > ovl irq for drm_crtc_wait_one_vblank(), since after mtk_dsi_stop() is called, > ovl irq will be disabled. If drm_crtc_wait_one_vblank() is called after last > irq, it will timeout with this message: "vblank wait timed out on crtc 0". This > happens sometimes when turning off the screen. > > In drm_atomic_helper.c#disable_outputs(), > the calling sequence when turning off the screen is: > > 1. mtk_dsi_encoder_disable() > --> mtk_output_dsi_disable() > --> mtk_dsi_stop(); // sometimes make vblank timeout in atomic_disable > --> mtk_dsi_poweroff(); > 2. mtk_drm_crtc_atomic_disable() > --> drm_crtc_wait_one_vblank(); > ... > --> mtk_dsi_ddp_stop() > --> mtk_dsi_poweroff(); > > mtk_dsi_poweroff() has reference count design, change to make mtk_dsi_stop() > called in mtk_dsi_poweroff() when refcount is 0. > > Fixes: 0707632b5bac ("drm/mediatek: update DSI sub driver flow for sending commands to panel") > Signed-off-by: Hsin-Yi Wang > --- > change log: > v1->v2: > * update commit message. > * call mtk_dsi_stop() in mtk_dsi_poweroff() when refcount is 0. > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index b00eb2d2e086..e152f37af57d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -630,6 +630,8 @@ static void mtk_dsi_poweroff(struct mtk_dsi *dsi) > if (--dsi->refcount != 0) > return; > > + mtk_dsi_stop(dsi); > + > if (!mtk_dsi_switch_to_cmd_mode(dsi, VM_DONE_INT_FLAG, 500)) { > if (dsi->panel) { > if (drm_panel_unprepare(dsi->panel)) { I think you just move mtk_dsi_stop() into mtk_dsi_poweroff() would works fine, but I would rather like calling mtk_dsi_start() and mtk_dsi_stop() in a symmetric manner. That means you may also move below functions into mtk_dsi_poweron(): mtk_dsi_set_mode(dsi); mtk_dsi_clk_hs_mode(dsi, 1); mtk_dsi_start(dsi); > @@ -696,7 +698,6 @@ static void mtk_output_dsi_disable(struct mtk_dsi *dsi) > } > } > > - mtk_dsi_stop(dsi); > mtk_dsi_poweroff(dsi); > > dsi->enabled = false; > @@ -1178,6 +1179,8 @@ static int mtk_dsi_remove(struct platform_device *pdev) > struct mtk_dsi *dsi = platform_get_drvdata(pdev); > > mtk_output_dsi_disable(dsi); > + mtk_dsi_stop(dsi); > + mtk_dsi_poweroff(dsi); I think mtk_output_dsi_disable() would call mtk_dsi_poweroff(), and mtk_dsi_poweroff() would call mtk_dsi_stop(), so these two line are redundant. And I think you should remove mtk_dsi_stop() in mtk_output_dsi_disable(), why not in this patch? Regards, CK > component_del(&pdev->dev, &mtk_dsi_component_ops); > > return 0;