Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp222242img; Wed, 20 Mar 2019 18:31:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvSHOajm9+7UjVqj5+3cSJbEF/xwhFFameeGWYDQdFp1VgZHKu3EPxl2ioIm/h9OqN+3ex X-Received: by 2002:aa7:85cc:: with SMTP id z12mr847577pfn.142.1553131861289; Wed, 20 Mar 2019 18:31:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553131861; cv=none; d=google.com; s=arc-20160816; b=C1bo6ISkS6PwR5v2CsSeztyYWfy2wjtkl1xUMfExVLhRJp+SRqdJ1YxcPei63Z0NGK 7wSISSGWb3AnwSTHaVIpqxZSFY2SrZxUymtaq9VbEs92FuHfHF9gSMpwdTrVOSztwCH2 gGj9eZkfvmnVq2/75t1R7FlQtLfX92AAyTGU27E16jRkc0pb7gLdumr6grnoZ0y9e4Ek DVB7RzNJAUGpDl95gU0n13d4R5SQTu/p0o8EFqjsXJBRLw+z+CRokty9M6MJTTiIWk1g Esxoucz3nNrCc/BUzB9F4e/0+knzet9rlfNEklyNxG/caAOGA0St87BaAp8eOfZRodFW 5WuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:feedback-id:message-id :subject:reply-to:cc:from:to:dkim-signature:date; bh=912iqiIr4XC8S9eHn6h7beePGT6myjMMssSk8a5TjMA=; b=rqJnsfaSn+Z+Jg/0WR0qR6KdL5iq6gC1MbeEmIgggdoHC3gi2grrAP9frYDiScR82D 7x2gXyMCvGDG5Z2qw3RPWlpIvGmTgzdkLppEUHqpel4Gxnlth8jTBuv5pRG5t6X3Y7Rn pM607+k+LC4sWPRCBBl89+FVtjN+PZ+bJt9gHU/MAjLfXk4GmDaOYeB3IXgwtPW4Lae1 A/hkIDwwHQ5pb3oXboiBgV94oL5JWRRP4pHOcuGLS0A4jjrK03ug/2QRoE2Vi+ZXgz5I JtjfszytVZCvr6jFbFW+7bLzxF/iP32KamZOz/Zlp/5K4HWVGM3D7IjS6JLqndRL0/Aj GWDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.ch header.s=default header.b=v93d6uuU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.ch Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k7si2927197pgq.476.2019.03.20.18.30.45; Wed, 20 Mar 2019 18:31:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.ch header.s=default header.b=v93d6uuU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727738AbfCUB3U (ORCPT + 99 others); Wed, 20 Mar 2019 21:29:20 -0400 Received: from mail4.protonmail.ch ([185.70.40.27]:20203 "EHLO mail4.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726753AbfCUB3U (ORCPT ); Wed, 20 Mar 2019 21:29:20 -0400 Date: Thu, 21 Mar 2019 01:29:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.ch; s=default; t=1553131756; bh=912iqiIr4XC8S9eHn6h7beePGT6myjMMssSk8a5TjMA=; h=Date:To:From:Cc:Reply-To:Subject:Feedback-ID:From; b=v93d6uuUJHDu8GZpOuUNR01bHRlyIMknYzSt0hj1eRkSAN59A95yuIhIx+EctskrW PWkmHzJCPcqKavNeAvhID+zBVAsJMJ4tIFIjA8ULQhxyJT4vsH7F1zQozA36wsXZTE 6YGW0huBZQReIIDDKP9ypKIg3dgoBb4H4IMGKNPw= To: Mathieu Poirier From: Solomon Tan Cc: "peterz@infradead.org" , "mingo@redhat.com" , "acme@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "suzuki.poulose@arm.com" , "alexander.shishkin@linux.intel.com" , "jolsa@redhat.com" , "namhyung@kernel.org" , "robert.walker@arm.com" , "acme@redhat.com" Reply-To: Solomon Tan Subject: [PATCH v4] perf tools: Add missing case value Message-ID: Feedback-ID: idpJ9Qep05LI5f2mQoaoGmmCIit-QceKL6uqbHgV_NOtNjcF0QNi56ai_biFv0uPMue2gAtmoKKy4wfiVgSKGg==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha256; boundary="---------------------c54533f3f9ad8fb079b2a615a820b327"; charset=UTF-8 X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) -----------------------c54533f3f9ad8fb079b2a615a820b327 Content-Type: multipart/mixed;boundary=---------------------2108b41cedeb08d4a300ff618b20164f -----------------------2108b41cedeb08d4a300ff618b20164f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain;charset=utf-8 The following error was thrown when compiling `tools/perf` using OpenCSD v0.11.1. This patch fixes said error. ``` CC util/intel-pt-decoder/intel-pt-log.o CC util/cs-etm-decoder/cs-etm-decoder.o util/cs-etm-decoder/cs-etm-decoder.c: In function =E2=80=98cs_etm_decoder__buffer_range=E2=80=99: util/cs-etm-decoder/cs-etm-decoder.c:370:2: error: enumeration value =E2=80= =98OCSD_INSTR_WFI_WFE=E2=80=99 not handled in switch [-Werror=3Dswitch-en= um] switch (elem->last_i_type) { ^~~~~~ CC util/intel-pt-decoder/intel-pt-decoder.o cc1: all warnings being treated as errors ``` Because `OCSD_INSTR_WFI_WFE` case was added only in v0.11.0, the minimum required OpenCSD library version for this patch is no longer v0.10.0. Signed-off-by: Solomon Tan --- tools/build/feature/test-libopencsd.c | 4 ++-- tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/build/feature/test-libopencsd.c b/tools/build/feature/t= est-libopencsd.c index d68eb4fb40cc..2b0e02c38870 100644 --- a/tools/build/feature/test-libopencsd.c +++ b/tools/build/feature/test-libopencsd.c @@ -4,9 +4,9 @@ /* * Check OpenCSD library version is sufficient to provide required featur= es */ -#define OCSD_MIN_VER ((0 << 16) | (10 << 8) | (0)) +#define OCSD_MIN_VER ((0 << 16) | (11 << 8) | (0)) #if !defined(OCSD_VER_NUM) || (OCSD_VER_NUM < OCSD_MIN_VER) -#error "OpenCSD >=3D 0.10.0 is required" +#error "OpenCSD >=3D 0.11.0 is required" #endif int main(void) diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/= util/cs-etm-decoder/cs-etm-decoder.c index ba4c623cd8de..39fe21e1cf93 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c @@ -387,6 +387,7 @@ cs_etm_decoder__buffer_range(struct cs_etm_decoder *de= coder, break; case OCSD_INSTR_ISB: case OCSD_INSTR_DSB_DMB: + case OCSD_INSTR_WFI_WFE: case OCSD_INSTR_OTHER: default: packet->last_instr_taken_branch =3D false; -- 2.19.1 -----------------------2108b41cedeb08d4a300ff618b20164f Content-Type: application/pgp-keys; filename="publickey - solomonbstoner@protonmail.ch - 0xA77658B9.asc"; name="publickey - solomonbstoner@protonmail.ch - 0xA77658B9.asc" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="publickey - solomonbstoner@protonmail.ch - 0xA77658B9.asc"; name="publickey - solomonbstoner@protonmail.ch - 0xA77658B9.asc" LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tDQpWZXJzaW9uOiBPcGVuUEdQLmpz IHY0LjQuMTANCkNvbW1lbnQ6IGh0dHBzOi8vb3BlbnBncGpzLm9yZw0KDQp4c0JOQkZyeTVGWUJD QUNWZG9oN1pvYnFaMTI2RUFPVDNjaktZalVIMURtQkxHeWEvWmxQV0xaVVBmMjkNCk5aMUduSHcx K0ZnYXZPODRPY3ZPK0RORm51eVllUG9ZM3NsaVVwNWpPT0xRNHhoQmVIL0U3ZWgybDhUVg0KdW9t ZFZLK1hsQ0NzcGFXZU9BR3ovSkt0dDgrV0RtbytsOUsrQTNHcXdnZHZPTjI3dTA0L3VYd1MyeE5W DQpHQWhBY0RVVGZBL3NMNTdUbWV0NU5KNXdoZ0dXM3d5alNPOSs0Zkw4aWtXaDlBMGJvL3BxVFo5 L3NFTVcNCjdTOGllYXUxbklKUER5ZXBzeTU4TnE0ZFRnMTBIVll5WkMyZTdER0x4MXR4YzVPeE81 V3hJcTgwazJXdQ0KeFhqRFU5aVhPT2I1ZElDeDJZSExTTGZmdTQ1VGw0bXBVam9tY3F2WFVZdmpM NEZYRGszTWtTVFhBQkVCDQpBQUhOTzNOdmJHOXRiMjVpYzNSdmJtVnlRSEJ5YjNSdmJtMWhhV3d1 WTJnZ1BITnZiRzl0YjI1aWMzUnYNCmJtVnlRSEJ5YjNSdmJtMWhhV3d1WTJnK3dzQi9CQkFCQ0FB cEJRSmE4dVJXQmdzSkJ3Z0RBZ2tRNzdSbg0Kck1pQ2lhWUVGUWdLQWdNV0FnRUNHUUVDR3dNQ0hn RUFDZ2tRNzdSbnJNaUNpYWIweXdnQWxBemthWVZSDQpDMHFvL0lhY000NXRVVGJyTnlVYmVLeUds Mi9tTU9ma3JOTDcvcTBWemtxcmJxY2NTWjRzUVVta25IYU0NCk1Cdm1STnJiMXR4elNkTlZuS1ZQ VlJRSGE4eDlDcDVUQnhBTFV3NDdHOW81SnYrYVNueHRwWEFMSldldA0KbUt1WWlSaHRzUWxBazlF RlZJYzY3ajkvK2s5bkpTUkRtWnRLeU9jOGhXZkxjcFlGV0s2UXFLSWt1NG9xDQp3d0xFRzE0T0Nl c3VqV2E4Sm9iVy8rb1Irelh3QmJCOE55dWRGSm13b0FYLzdud2NTSlZ0bGRZeUdYbWoNCkt1VFFp eFJpWFh1TjhsNHBSdGRRdUdGdVhERjM4WVRrMDlNYyt1SmdjaVRZYmNSL3pmMGRhUktVbDB0aA0K RzBOVE85YzErZG02M0FHWjdMSkJIOFB1N0NrMi9hT3d4czdBVFFSYTh1UldBUWdBNVZWdCtKVGRa VXhwDQpuZSs2dzljSE0zTzY1Q1ZzcWFMNkI4VCtBcVF6a0VJbGJhQkI4RlV5citGa1BZZGRiNGVw SjlQVHNJLzYNCk1jeThTRTdWUUVuU2NuYVQvREtkbk1OUXJibngrRWgyM2NWNFNJVncveWVBT0hP Z1BvT0dHekZmVk0ySw0KZkVhQjJvTDk4eThNcUlRLzNEak9CYUpwZFdhQS9mQldEcVJ6aENqQzhX MkhndDIvRElQY2JWalpISUFtDQptZXBGSWo4R2JLZDhOVjhYVU1QcUtjWEVNTVZIdW1ndHNSVVBX eE9DN29wZjI3WmFLcjRteVd2NFdCVDANClo5RzAzT2VLUmEvU3ZoVUlYcjVMZzRyaWpkbTZWMVFL aFpvS3R4Wi9RR0RqdDg3dUtQb0M1ZTNwa2tQYg0KOXlvbHNFQVQ2U0xRcDd2TEVwWjRlUjFmd1Ju eDV3QVJBUUFCd3NCcEJCZ0JDQUFUQlFKYTh1UlhDUkR2DQp0R2VzeUlLSnBnSWJEQUFLQ1JEdnRH ZXN5SUtKcGk5N0IvOXhYU3VMRjc2QUd6ZWtwdFdiTVo2eXVYeWQNCmZza2IwL0NjL0xjR2tMV21V Y1hkbGRLWVdTLzg3ZXZTalZXZTFTbUhCQzVrZWhvVXp1bEpCZmx0SGpqMQ0KcVZCTWY0eHB6ckVz aGFCWUNxbllhTnpCa2NINlFINGNRT3cvMUw1WTZ5QjRPQVZGQjJ2d3UzN2dSNUJ4DQpEQWN2NHFD b1lvT1ZDRklDRFprV3lQWkFReFNLb3hHd3BXK2ZNOTdXOXBwV0Q4WEw5b2RlU29UVmN6a0INCnJK WTFrakltUnhONU5wMkg5UVRKY0EyMHNQNDJ0VnNQVzRuaC9HYkQ4cmc2Tkl3TFg3RWJVWkh2VjJE Mg0KRDJxRThSM1ZNTGNob3BSbGFIQjVHU1AzNWxpTkVuY2tKMmV0dTRUWVY4SXB6NkNseW16TnZy RjR1MkhkDQowZktFU0hRM2U3SEVWMGpQDQo9TTRBNA0KLS0tLS1FTkQgUEdQIFBVQkxJQyBLRVkg QkxPQ0stLS0tLQ0K -----------------------2108b41cedeb08d4a300ff618b20164f-- -----------------------c54533f3f9ad8fb079b2a615a820b327 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail Comment: https://protonmail.com wsBcBAEBCAAGBQJckujmAAoJEO+0Z6zIgommSIAH/0qwoDgHbWI80ibrtjuJ l1iKBGTCrOAa40TmZ+XpEX/NYSNyHHv7ykcmA+bIeWZGBI6wfDtCtznmiSPH TqkBeLJkl20YACYZSgmJ7eoyKDswa+M5Iv5ipH5FxGwa6HXiXVlhrG/M/Clm OxIEyaqh6MOii+bD+8lARD2a6Fwsf8wxLmtWdmZ+4g8toZC84Y3vUTLhSujP 4RuUijU2vdYVpyt2FRS2F4kq2TJS11PryrfORFOrSKagrB3NP6faqMd5QdBi udaWOcSey1rzSoDWWukwdNMgdVendNwDMhhTCusuljgnZ69SR94dgqGxhPFF YZbL2f8Mz8DgLYiqbeJFQzY= =BYC9 -----END PGP SIGNATURE----- -----------------------c54533f3f9ad8fb079b2a615a820b327--