Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp296796img; Wed, 20 Mar 2019 20:55:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqyqhQviMxBXA5gMxL6B1hukSu8jGE4IXcK+lHd/gluTk5A5ZtqTtSBZ25n/m+oZc551jt2J X-Received: by 2002:a65:6148:: with SMTP id o8mr1453510pgv.442.1553140527594; Wed, 20 Mar 2019 20:55:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553140527; cv=none; d=google.com; s=arc-20160816; b=MYilkizCtrAKm1hvrQQM/I/iLzGXFW86GPpULPkCeDfGPS9EG0uN0p/xguYdzp7+ec ruYMuO2L67XPcpYDFf5oXFGinVtREsKly0tjzf0pBU4lyVrm9hf1C/jm0MJZuu/8DPEI LtGj7aCnZw98dMpeHZ7QWnxMGISMXNZc6+tTy2B7c+qACn+Qy1QiSaJLg59nKWLASee7 xBPeP3neBdfyfTFgBDeLF7mjCPLwFE0MtRPaTjzuvINWaKtUWCFLHJvOczJrD3f9wIzB D8bvhUgjC7Lix186fFzDEUxB9jz3ajg+JGfe0INp7/GE8fOYKXULx8yxNMlcs4xMV4pO m5/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:subject:cc:date :to:from; bh=UG0yStngyVhqCpVvUI7Jduahifh34JEa27L9NJx8OD8=; b=TQDruL73BNbJPndW6YXRqtUeR6sNtv98/e/XnhJQqkBrcpWlzuxKy7cnO3UH4jZ/gq GkK+4rwsSvU4LLZ3g3JwwabOEQntnPXZpk23XDDBIQF63oPzx085wO+hKoyRWprTQIh/ pfLEnmjMZjT/pDmIW/x3UehE/Sr+kiFC8AxKTK3Ag+5rXOEIW1oTT7apJMUPN9UK2uGz rCq9IzcUgyo9YZX3mpZ27msvE2lfflJW7SbY5LTIVtGxBn+/NT/4K0yNTAUGXHuapkVQ MY59X5wcUs1diENS5KyXUprmpS9fRnaNsQTnqOBkXHPRfdpo+Cd3kt3BqHZlQqllS/yp QBMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b31si3669692plb.351.2019.03.20.20.55.10; Wed, 20 Mar 2019 20:55:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727890AbfCUDyb (ORCPT + 99 others); Wed, 20 Mar 2019 23:54:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:60810 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727575AbfCUDya (ORCPT ); Wed, 20 Mar 2019 23:54:30 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BC2CEAC43; Thu, 21 Mar 2019 03:54:29 +0000 (UTC) From: NeilBrown To: Jiri Kosina Date: Thu, 21 Mar 2019 14:54:22 +1100 Cc: LKML Subject: [PATCH trivial] list/hashtable: minor documentation corrections. Message-ID: <87o9647uhd.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable hash_for_each_safe() and hash_for_each_possible_safe() need to be passed a temp 'struct hlist_node' pointer, but do not say that in the documentation - they just say a 'struct'. Also the documentation for hlist_for_each_entry_safe() describes @n as "another" hlist_node, but in reality it is the only one. Signed-off-by: NeilBrown =2D-- include/linux/hashtable.h | 4 ++-- include/linux/list.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/hashtable.h b/include/linux/hashtable.h index 417d2c4bc60d..78b6ea5fa8ba 100644 =2D-- a/include/linux/hashtable.h +++ b/include/linux/hashtable.h @@ -145,7 +145,7 @@ static inline void hash_del_rcu(struct hlist_node *node) * hash entry * @name: hashtable to iterate * @bkt: integer to use as bucket loop cursor =2D * @tmp: a &struct used for temporary storage + * @tmp: a &struct hlist_node used for temporary storage * @obj: the type * to use as a loop cursor for each entry * @member: the name of the hlist_node within the struct */ @@ -197,7 +197,7 @@ static inline void hash_del_rcu(struct hlist_node *node) * same bucket safe against removals * @name: hashtable to iterate * @obj: the type * to use as a loop cursor for each entry =2D * @tmp: a &struct used for temporary storage + * @tmp: a &struct hlist_node used for temporary storage * @member: the name of the hlist_node within the struct * @key: the key of the objects to iterate over */ diff --git a/include/linux/list.h b/include/linux/list.h index 79626b5ab36c..894da1962f89 100644 =2D-- a/include/linux/list.h +++ b/include/linux/list.h @@ -842,7 +842,7 @@ static inline void hlist_move_list(struct hlist_head *o= ld, /** * hlist_for_each_entry_safe - iterate over list of given type safe agains= t removal of list entry * @pos: the type * to use as a loop cursor. =2D * @n: another &struct hlist_node to use as temporary storage + * @n: a &struct hlist_node to use as temporary storage * @head: the head for your list. * @member: the name of the hlist_node within the struct. */ =2D-=20 2.14.0.rc0.dirty --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlyTCu4ACgkQOeye3VZi gbmeFRAAn5whEALD1hO62treSICxHMR6XVPJOIZ3q/z9NUOCQC9ZhljWnaX0sQ/G 7qcyI+bxCIGypXFKKULOhSBeseOiX7J/LpPe50XjN7UVl1L2VzUN6zCxtb3+XGJ6 3MXeyz7jSvNIsYu4Mul+9m8LcelotLWVMOdQ+xODPvTTDPr3EY5vR5mFvzItNA0H B51pDPws6oTH+otQJF33ZwHS1kfVnnT2mHGM5pYpuWhkLdqghwZZu0cztLF0fRJ0 vhdZt8aGKdN3Dem0GDQOub2rfTAZsrbYhegxDKhleRrVNxztlZRacn25Xv2bHcGN 8G5GRGFJz//0UJMAwPXnULGMPTl4IIO1S7zrRE17hyPX24q3QGvnMHql59eJQze8 CyPahWReBoUF05OqlALG7C31IE4FaQUk+Eq37VfMeiAHT5ohL/qGfprOUEKLawFr SrvOygzUan9edJGvjG5cSzOZLNPVso15OsOh6nYLzjE10qWw8HVAqY5p0Q84kagE aJvGPPZzso+gIhjBFfug2dFzJwIMdEyPTQy1x0xEDFBlcruJAwUbJy5GKuwaQUzR ZUaoflV/6lcdiQIfWD2HyacRpnpTXxx8hPXp6u9A25HBBYkOlya0Su4z/cpdT55v 3VR9XKg8JXIE+TtfuhQ2ymdrHwTGcLXE/x3HgIiwRCX0Tbs2OEM= =rQJj -----END PGP SIGNATURE----- --=-=-=--