Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp410328img; Thu, 21 Mar 2019 00:23:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqwompq7WIRM1WTtpthGxZdn2AoCttfzrcQpAwMd7n5SwZuUQHDBMmjXbXFmE3ysSOkbfteo X-Received: by 2002:a63:4907:: with SMTP id w7mr2063921pga.50.1553152988126; Thu, 21 Mar 2019 00:23:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553152988; cv=none; d=google.com; s=arc-20160816; b=Ygwwvvm9oiTMOBiIw7AUwuaE5gux9aAwXNczXhU4MSXCno0oOv1K5Yg2Z0OtGJWW7Y JRowSTJv0ezTQGu6isKUXqihJ5v/gYVczHoOCOmy7iqBKu/ezmcXtUQDzyXpeB6M4tBD k2SBgYtw0eVqcTNHjMiCzJr8d1TEX+auchJIWxjde7WvXf82ihFMJZPB0Orpl6JfqehD OndYvmUuB2mXxamvSDYyuKofxdj/r+D2t6aKyhfXH6O9m3lb78wapV81F5xjVubkD8QN Wlv6ozINjnge0tREyuHjk/NWs/nt2xaB1upY09QLqndiaXzuWudriqvIrI+j8Lf9uHYD dHhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=c7i1Zr1Oeu2KbKqDknFFU5AYuWj4p3NzsbodfbSJpe4=; b=ijZgq53NDetCLSDn3aFbnlVBBw8exNGBe+O2sv8yKStsdYQ0NvcKxHI7t8IrTNzaF2 kh1FOeIKpVhBzwWbsbpnfyIwgvUmO7Pu4mQdNVlY+CGg921OC0f8To9FI7M1kzdGnN4a ULS/pQmZ8BNBc6XqzASnMyWz/lqFApJO7rCTNV188WBrlZk2XdOtrWLO7mHRRXtT+ThL WVpqjsJuLkX9bY32LRtGpqXD+t3c1jtxM6zuwQfkRYpVSNivz1ldUbP1NCBBAj505oWC 2wKiMLoJeQ/sWuTspRmKjjum/2IF0mzQDjZVceAfqiAEKIJPo0qPbitzhOjHDmuN13nh zPjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=gUIbidyM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l27si3520617pfb.258.2019.03.21.00.22.53; Thu, 21 Mar 2019 00:23:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=gUIbidyM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727914AbfCUHVA (ORCPT + 99 others); Thu, 21 Mar 2019 03:21:00 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:34024 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727870AbfCUHU7 (ORCPT ); Thu, 21 Mar 2019 03:20:59 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2L7FR8A056292; Thu, 21 Mar 2019 07:20:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=c7i1Zr1Oeu2KbKqDknFFU5AYuWj4p3NzsbodfbSJpe4=; b=gUIbidyMSkQhuhdAXX+QRoCiZNupyMe8qwqWYdEVOHDAinAaUy5Rirsr2z3gX2Mm+PEk G2LGWiEXlB32ENKqy0e1xizHVcPcCtqtaV+nOnKgAXpsQHgH8d/s/KVqkVYfqVFWIM9v J08bG6Fb/Qp2PL6hAjvF3aiBAxqV990AQzH1GYnpkqrMqTYYaoY3gvCe1GLbpt/POGNQ X22k7+UYun46dMN8OqrXNw2yI2Jnn6LI7K2mkr0nNPhxgpfhnozELYLwexU7Ho3+xJVP UU9yZzd1ZvmI8UUkAw91gTzavSyOOIi+RGMts1fRNhfQ/VZ5fCRBz/9udGyKkhVAfuYv kg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2r8pney0uy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2019 07:20:54 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x2L7Kpdl005196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2019 07:20:53 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x2L7KpKL016296; Thu, 21 Mar 2019 07:20:51 GMT Received: from kadam (/197.157.0.22) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 21 Mar 2019 00:20:50 -0700 Date: Thu, 21 Mar 2019 10:20:40 +0300 From: Dan Carpenter To: Aditya Pakki Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Nathan Chancellor , kjlu@umn.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc Message-ID: <20190321072039.GI2202@kadam> References: <20190319201509.16252-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190319201509.16252-1-pakki001@umn.edu> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9201 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903210053 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 19, 2019 at 03:15:08PM -0500, Aditya Pakki wrote: > phydm.internal is allocated using kzalloc which is used multiple > times without a check for NULL pointer. This patch avoids such a > scenario. > > -- > v1: Patch collision with different things, fix as per Greg > Signed-off-by: Aditya Pakki > --- Gar... Sorry, no, that's not quite right. It should be: blah blah blah... Signed-off-by: you --- V1: Patch collision with different things, fix as per Greg Try applying your patch with `cat raw_email.txt | git am` and you'll see the problem with the commit message. regards, dan carpenter