Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 62BC4608FC
Subject: Re: [PATCH -next] ubifs: remove unused function __ubifs_shash_final
To:     Richard Weinberger <richard@nod.at>
Cc:     Yue Haibing <yuehaibing@huawei.com>, dedekind1@gmail.com,
        adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
        linux-mtd@lists.infradead.org
References: <20190320140955.11576-1-yuehaibing@huawei.com>
 <97289b81-ed73-002a-504d-2e82fad153e7@codeaurora.org>
 <2691086.gDEv9kBeKS@blindfold>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <289f9994-0980-081e-f913-5729b16d16f4@codeaurora.org>
Date:   Thu, 21 Mar 2019 13:24:55 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <2691086.gDEv9kBeKS@blindfold>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/21/2019 1:48 AM, Richard Weinberger wrote:
> Am Mittwoch, 20. März 2019, 21:05:37 CET schrieb Mukesh Ojha:
>> On 3/20/2019 7:39 PM, Yue Haibing wrote:
>>> From: YueHaibing <yuehaibing@huawei.com>
>>>
>>> There is no callers in tree, and can be removed.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>>    fs/ubifs/auth.c | 18 ------------------
>>>    1 file changed, 18 deletions(-)
>>>
>>> diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
>>> index 5bf5fd0..2a40ccce 100644
>>> --- a/fs/ubifs/auth.c
>>> +++ b/fs/ubifs/auth.c
>>> @@ -147,24 +147,6 @@ struct shash_desc *__ubifs_hash_get_desc(const struct ubifs_info *c)
>>>    }
>>>    
>>>    /**
>>> - * __ubifs_shash_final - finalize shash
>>> - * @c: UBIFS file-system description object
>>> - * @desc: the descriptor
>>> - * @out: the output hash
>>> - *
>>> - * Simple wrapper around crypto_shash_final(), safe to be called with
>>> - * disabled authentication.
>>> - */
>>> -int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc,
>>> -			u8 *out)
>>> -{
>>> -	if (ubifs_authenticated(c))
>>> -		return crypto_shash_final(desc, out);
>>> -
>>> -	return 0;
>>> -}
>>> -
>>> -/**
>>>     * ubifs_bad_hash - Report hash mismatches
>>>     * @c: UBIFS file-system description object
>>>     * @node: the node
>>
>>
>> Looks fine to be removed.
>>
>> Acked-by: Mukesh Ojha <mojha@codeaurora.org>
> I guess you mean Reviewed-by?

As i am unsure about future scope of this func. i.e why Acked.


-Mukesh


>
> Thanks,
> //richard
>
>
>