Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Mar 2019 11:11:43 +0100
From:   Mariusz Bialonczyk <manio@skyboo.net>
To:     Evgeniy Polyakov <zbr@ioremap.net>
Cc:     Jean-Francois Dagenais <jeff.dagenais@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <greg@kroah.com>
Message-Id: <20190321111143.c54afe794f1de222a0cd020a@skyboo.net>
In-Reply-To: <9351961553005269@iva4-406defa25fee.qloud-c.yandex.net>
References: <20190318092737.8170-1-manio@skyboo.net>
        <20190318092737.8170-3-manio@skyboo.net>
        <6836A9A3-AF86-4E2F-9215-647CB36E22DA@gmail.com>
        <9351961553005269@iva4-406defa25fee.qloud-c.yandex.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH 2/2] w1: fix the resume command API
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Evgeniy,

On Tue, 19 Mar 2019 17:21:09 +0300
Evgeniy Polyakov <zbr@ioremap.net> wrote:

> Looks like this may break the search logic, can you check that with this patch applied
> some other single slave device will correctly 'tell' its id and it can be addressed via match rom (like, basically, just reading temperature or something like that)?

Yes, I have tested it in a mixed environment (regarding single slave/multidrop):

/sys/devices/w1_bus_master5 # ll
total 0
drwxr-xr-x    9 root     0                0 Mar 21 10:53 .
drwxr-xr-x   17 root     0                0 Mar  2 16:49 ..
drwxr-xr-x    4 root     0                0 Mar 21 10:55 28-00000921ff5e
drwxr-xr-x    3 root     0                0 Mar 21 11:04 29-0000001246a4
drwxr-xr-x    3 root     0                0 Mar 21 11:04 29-0000001246b1
drwxr-xr-x    3 root     0                0 Mar 21 11:04 29-0000001246b9
drwxr-xr-x    3 root     0                0 Mar 21 10:54 29-0000001246bc
drwxr-xr-x    3 root     0                0 Mar 21 10:53 3a-0000000f354f

/sys/devices/w1_bus_master6 # ll
total 0
drwxr-xr-x    4 root     0                0 Mar 21 10:54 .
drwxr-xr-x   17 root     0                0 Mar  2 16:49 ..
drwxr-xr-x    3 root     0                0 Mar 21 11:07 29-0000001246a9

No problem with searching and using other slaves on the bus.

regards,
-- 
Mariusz Białończyk | xmpp/e-mail: manio@skyboo.net
https://skyboo.net | https://github.com/manio