Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp542603img; Thu, 21 Mar 2019 03:56:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRmLkoESyLRuTCdKbVIMbMN7BXaz73nN2vRzrL7MjH66axwtRxsQn/PeNOdi47sraFpm4c X-Received: by 2002:a17:902:bb86:: with SMTP id m6mr2901013pls.4.1553165784418; Thu, 21 Mar 2019 03:56:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553165784; cv=none; d=google.com; s=arc-20160816; b=Ar3m5qQ8MfhX47TChLuZq1hS3uADz1X96xNpsqVKbkmgck9JQZgEtlJvKBmdynE5tQ wlB0b6bvVjhpRjdPC5tWvAcAkONDDZRv7VPw3OVSqyliYBVfDcbLbV+l9GpxeOQb2DnH djuURd7E08k1nEadd1RiKeTS5GEDCgWmTqtpc1SP19xjNARDDbZv7MU1vt4PuzVZU2MW XJttIF8fIQ/32+u9V4f6d9nIWLR0vnvGIVO+dOm1hF+ssOtQNT8C1K3t2cPvXD4KWlcq NBNjZekFhMJoXNfUmK6o//QqEaak0N5LFdk5rM0uYEF2ty4kjufvDQpwilZ26kyziXj9 bS5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:references:in-reply-to:message-id:cc:to:from:date; bh=bpq8iLc03p70SD9qtl9cz1aWtvZuHXLk9XnFXIm394w=; b=Z/JplCDmDVjbzXIAZor+fG9C7tKkkGvt23yWJzu2hJw5qPWl4SqY6CkJ0YzDC8iMoN pYzkJ4pm2OltgFZlb9fM4r/ydiKaZsxLRC/gQtD2WD0FJVsM7m51QKl8uRSO+qC8Kv2c o6ZV9pltCOE59vhRvOgsZYDG5+KfQv1Pk0G7p89hD5NbBGVZbjgjeIGL65+5d2tmYDN9 n2JiMHXeocWh8ObSDl2CJiJx0AUO/8sDm80aS4Jq1P06LHINNKcGkous4Zr8sKDnDlYS A21Q0WHhgqUN5PmyYWZu0uSNLhmQOCGRn4JjHCMa1dDGjDE3sk3pT4COcTZEvoSI7+F+ VYsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=REJECT dis=NONE) header.from=skyboo.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11si4080004plk.323.2019.03.21.03.56.06; Thu, 21 Mar 2019 03:56:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=REJECT dis=NONE) header.from=skyboo.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbfCUKzU (ORCPT + 99 others); Thu, 21 Mar 2019 06:55:20 -0400 Received: from skyboo.net ([94.40.87.198]:34918 "EHLO skyboo.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727823AbfCUKzU (ORCPT ); Thu, 21 Mar 2019 06:55:20 -0400 Received: from [10.1.0.1] (helo=nemesis.skyboo.net) by skyboo.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1h6vLs-0005Ze-MM; Thu, 21 Mar 2019 11:55:18 +0100 Date: Thu, 21 Mar 2019 11:55:11 +0100 From: Mariusz Bialonczyk To: Jean-Francois Dagenais Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov , Greg Kroah-Hartman Message-Id: <20190321115511.29f8f6f25a2b9b96c2dd77aa@skyboo.net> In-Reply-To: References: <20190318092737.8170-1-manio@skyboo.net> <20190318092737.8170-2-manio@skyboo.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 10.1.0.1 X-SA-Exim-Rcpt-To: jeff.dagenais@gmail.com, linux-kernel@vger.kernel.org, zbr@ioremap.net, greg@kroah.com X-SA-Exim-Mail-From: manio@skyboo.net X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on nemesis.skyboo.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 Subject: Re: [PATCH 1/2] w1: ds2408: add a missing reset when retrying in output_write() X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on skyboo.net) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Mar 2019 10:21:32 -0400 Jean-Francois Dagenais wrote: > May I suggest a cleaned up version my original klunky code with your fix in it > (Note: this is untested, it compiles on arm64, that's all): Thank you Jean! I just tested your version - and it is working as expected :) > I can do a proper patch submission if you guys provide positive response on this > early RFC. Or better yet, you can take it and own it yourself as your v2 > Mariusz. ;) No, it's your code, please just submit v2 as yours (I've already sent simplified version of the patch 1/2 as you suggested). Just drop the following and all will be fine :) Reported-by: Mariusz Bialonczyk Thanks! regards, -- Mariusz Białończyk | xmpp/e-mail: manio@skyboo.net https://skyboo.net | https://github.com/manio