Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp602283img; Thu, 21 Mar 2019 05:14:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqzm2Jx3OW3gC8fdFdLDfJhkOwgJcl7OSR6NrmRXDLMel05XFrbTptuRBCt0+qeux+IvQ2cr X-Received: by 2002:a17:902:bf0c:: with SMTP id bi12mr3241094plb.340.1553170458185; Thu, 21 Mar 2019 05:14:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553170458; cv=none; d=google.com; s=arc-20160816; b=FwVM1+d9XS1qsEKK6wdSixM3fMjhzRbVO+9nVfKpGmiKe6kXuO+BIS1wZJyX3yGIBd JgC+ux/I6/e65AWckNYoD09kdrgawuUzDM7T6d3+BmUvfUY8ReEqyqlufeONvkJijxXv B/OPQ2IHuJgcZ5R834J0NQBsq2OgIbxY+DvPLQ+sRS6SNhfR/YpEpzgzvsGHA63H6KrX YOdI4rijcWZQ2q9LWnihEpFEqwHW7dM/5J+bJckGhCR1yK/4XLTJgJn/hfnrgQG9ZXSF 8WVGmcpOyHtRQ/ODBhB3NheclMi8dY/Sm8Tf+sfSygmsOlg+mLtxuZPVQX3bOWgrvcQJ L/6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date; bh=3HXBkXYbO6EW1zb0WzFkUJw9OZIK0MrrctzqDxG3sGI=; b=oIi72N7NoN26o6GlXoT2ixWlUYEzIKPdOQJ04Qo9R1LSYlxPlRMQt+7TLd1Gh9PKFG 9RtFwr0WqWqAZuykEPZm6UbwUC/tWbeXwTfFprFfNKrr7UTYY0LsQgorvjd45EKh/3sa jY0BfHgdUgnAcdwksSikdwY2rh6PtbDZdoMQkuAbLJ1uvn+Gs7/BQ3Nta57NZDnRjpNj g4XrnJXM+rpPK75Qq3uLasYUG8ZeeK/HmJ+94ZZJ4obt8IX83/Jh8NQrwCrtnnzm8p3l zAazJG2Y0HlPJSc0H7aT7eYvpbaonVNy79B7bTg5n7K8jY50HnQWkeISi8qMqaLQ6VuR Upjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m9si4198472pgr.218.2019.03.21.05.14.00; Thu, 21 Mar 2019 05:14:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728176AbfCUMLi (ORCPT + 99 others); Thu, 21 Mar 2019 08:11:38 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:36956 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727878AbfCUMLh (ORCPT ); Thu, 21 Mar 2019 08:11:37 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1h6wXi-00076N-OM; Thu, 21 Mar 2019 20:11:30 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1h6wXc-0003Kt-UI; Thu, 21 Mar 2019 20:11:24 +0800 Date: Thu, 21 Mar 2019 20:11:24 +0800 From: Herbert Xu To: David Howells , Mimi Zohar , Dmitry Kasatkin , linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 02/11] crypto: akcipher - check the presence of callback before the call Message-ID: <20190321121124.lg4fjitsew5kpvq6@gondor.apana.org.au> References: <20190301175918.29694-1-vt@altlinux.org> <20190301175918.29694-3-vt@altlinux.org> <20190321111918.4kr7vdgz23xzjwed@gondor.apana.org.au> <20190321114209.qdaql3kdtfsnfzla@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321114209.qdaql3kdtfsnfzla@altlinux.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 21, 2019 at 02:42:10PM +0300, Vitaly Chikunov wrote: > > I guess patch "PATCH v7 01/11] KEYS: report to keyctl only actually > supported key ops" should also be removed and will infer anything from > presence of the callbacks. Indeed. Especially if this is exposed to user-space then you need to be careful changing the user-space API by clearing the verify/sign bits for raw RSA. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt