Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp669026img; Thu, 21 Mar 2019 06:36:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwuezIZjG3AYUN/3vqOdZwiXeg5HvhB1vp/Qb0Sgj/Ezyx8AxBCctFmGhFJSDHoezr8aUsO X-Received: by 2002:a63:fd10:: with SMTP id d16mr3346897pgh.306.1553175383371; Thu, 21 Mar 2019 06:36:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553175383; cv=none; d=google.com; s=arc-20160816; b=DCP0hl63Fc86Ip+YMoInNwhEiuVpOMGSGC+s26kKJQjW+LdZs3yc97VF876AqAAnvF wGz/sYM8T9LGm1ek8m0tYVgxmzx0/dpdSmqXJ2G5nPsCZtcc/JifFsjqi2AVBbdTlVeS 1Iqk5O4yZWnf71SWPFkJcPlx0Wtzzt6DiNZQ1etWi8BGYFOSY/S9J3ZYsrtrLE7TC/1o myn4A9QUDZ7icyZGhoaXr7DGcb0QG52eUQN/0nAvhCaD7h1cbsEir4iyPXGBhpG8sQaO E3itnxZ3lALNw2cnDKBI89O/0sztx0XkrNHpyNgnEfquKN8w1+dM5JUzCO+82rksRWb5 crig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=7jKqQTi1drzmi9cfWKSq900xVYTWTgaFQiRozTIDCSI=; b=uJpQ39kmtRnisZf1MAEIp0jrO7nUFJaMY7Fk/QkF0aQ/0Jqmk0z8NNNpBzTQEjxWOS rLftrrForu3CXaTZVdEzkOEfr4BXhXF4q887JwN7FJwh2Iz+inoTgfz3vDnpYIwJ+5e4 tYG88thAcaO6g4n/V94fC+IKe5fqkvU0KH9KshfPsLAGAGRJVKFLYH9Qj/6hm3PwFeLC EeVbfFAlJ4h6BxLLB123sYXn+KHxD2UUKXRExkzyeZyfYY3Y7lu/kHEwQ/nCDb5coGPi nFfIEGarAmXYDWxPlAMZXluKR2LSV8ng9EJtuHcFRkvAotQMZZFhA/s6/9F8GZJdQrwY gnng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a4si4500769plp.431.2019.03.21.06.36.08; Thu, 21 Mar 2019 06:36:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728353AbfCUNfB (ORCPT + 99 others); Thu, 21 Mar 2019 09:35:01 -0400 Received: from mga01.intel.com ([192.55.52.88]:48434 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728069AbfCUNfA (ORCPT ); Thu, 21 Mar 2019 09:35:00 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 06:35:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,252,1549958400"; d="scan'208";a="153819762" Received: from dilu-mobl2.ccr.corp.intel.com (HELO localhost) ([10.249.254.184]) by fmsmga002.fm.intel.com with ESMTP; 21 Mar 2019 06:34:57 -0700 Date: Thu, 21 Mar 2019 15:34:55 +0200 From: Jarkko Sakkinen To: Tadeusz Struk Cc: grawity@gmail.com, James.Bottomley@HansenPartnership.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm: fix a race between poll and write in tpm-dev-common Message-ID: <20190321133455.GD2267@linux.intel.com> References: <155294749695.20367.14472779462229450620.stgit@tstruk-mobl1.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <155294749695.20367.14472779462229450620.stgit@tstruk-mobl1.jf.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 18, 2019 at 03:18:16PM -0700, Tadeusz Struk wrote: > Since the poll returns EPOLLIN base on the state of two > variables, the response_read being false and the > response_length > 0 the poll needs to take the buffer_mutex > after it is woken up. > > Fixes: 9488585b21bef0df12 ("tpm: add support for partial reads") > Reported-by: Mantas Mikulėnas > Signed-off-by: Tadeusz Struk Also, please add Cc: stable@vger.kernel.org as the first tag. /Jarkko