Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: [PATCH v2] w1: ds2408: reset on output_write retry with readback
From:   Jean-Francois Dagenais <jeff.dagenais@gmail.com>
In-Reply-To: <20190318092737.8170-2-manio@skyboo.net>
Date:   Thu, 21 Mar 2019 11:18:27 -0400
Cc:     Greg Kroah-Hartman <greg@kroah.com>,
        Mariusz Bialonczyk <manio@skyboo.net>
Content-Transfer-Encoding: quoted-printable
Message-Id: <10244730-36A8-4DAC-95E5-AD7BDEA32F43@gmail.com>
References: <20190318092737.8170-1-manio@skyboo.net>
 <20190318092737.8170-2-manio@skyboo.net>
To:     open list <linux-kernel@vger.kernel.org>,
        Evgeniy Polyakov <zbr@ioremap.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Originally
Reported-by: Mariusz Bialonczyk <manio@skyboo.net>

When we have success in 'Channel Access Write' but reading back latch
states fails, a write is retried without doing a proper slave reset.
This leads to protocol errors as the slave treats the next 'Channel
Access Write' as the continuation of previous command.

This commit is fixing this by making sure if the retry loop re-runs, a
reset is performed, whatever the failure (CONFIRM_BYTE or the read
back).

The loop was quite due for a cleanup and this change mandated it. By
isolating the CONFIG_W1_SLAVE_DS2408_READBACK case into it's own
function, we vastly reduce the visual and branching(runtime and
compile-time) noise.

Tested-by: Mariusz Bialonczyk <manio@skyboo.net>
Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
---
 drivers/w1/slaves/w1_ds2408.c | 76 =
++++++++++++++++++++++---------------------
 1 file changed, 39 insertions(+), 37 deletions(-)

diff --git a/drivers/w1/slaves/w1_ds2408.c =
b/drivers/w1/slaves/w1_ds2408.c
index b535d5ec35b6..92e8f0755b9a 100644
--- a/drivers/w1/slaves/w1_ds2408.c
+++ b/drivers/w1/slaves/w1_ds2408.c
@@ -138,14 +138,37 @@ static ssize_t status_control_read(struct file =
*filp, struct kobject *kobj,
 		W1_F29_REG_CONTROL_AND_STATUS, buf);
 }
=20
+#ifdef fCONFIG_W1_SLAVE_DS2408_READBACK
+static bool optional_read_back_valid(struct w1_slave *sl, u8 expected)
+{
+	u8 w1_buf[3];
+
+	if (w1_reset_resume_command(sl->master))
+		return false;
+
+	w1_buf[0] =3D W1_F29_FUNC_READ_PIO_REGS;
+	w1_buf[1] =3D W1_F29_REG_OUTPUT_LATCH_STATE;
+	w1_buf[2] =3D 0;
+
+	w1_write_block(sl->master, w1_buf, 3);
+
+	return (w1_read_8(sl->master) =3D=3D expected);
+}
+#else
+static bool optional_read_back_valid(struct w1_slave *sl, u8 expected)
+{
+	return true;
+}
+#endif
+
 static ssize_t output_write(struct file *filp, struct kobject *kobj,
 			    struct bin_attribute *bin_attr, char *buf,
 			    loff_t off, size_t count)
 {
 	struct w1_slave *sl =3D kobj_to_w1_slave(kobj);
 	u8 w1_buf[3];
-	u8 readBack;
 	unsigned int retries =3D W1_F29_RETRIES;
+	ssize_t bytes_written =3D -EIO;
=20
 	if (count !=3D 1 || off !=3D 0)
 		return -EFAULT;
@@ -155,54 +178,33 @@ static ssize_t output_write(struct file *filp, =
struct kobject *kobj,
 	dev_dbg(&sl->dev, "mutex locked");
=20
 	if (w1_reset_select_slave(sl))
-		goto error;
+		goto out;
=20
-	while (retries--) {
+	do {
 		w1_buf[0] =3D W1_F29_FUNC_CHANN_ACCESS_WRITE;
 		w1_buf[1] =3D *buf;
 		w1_buf[2] =3D ~(*buf);
-		w1_write_block(sl->master, w1_buf, 3);
=20
-		readBack =3D w1_read_8(sl->master);
+		w1_write_block(sl->master, w1_buf, 3);
=20
-		if (readBack !=3D W1_F29_SUCCESS_CONFIRM_BYTE) {
-			if (w1_reset_resume_command(sl->master))
-				goto error;
-			/* try again, the slave is ready for a command =
*/
-			continue;
+		if (w1_read_8(sl->master) =3D=3D =
W1_F29_SUCCESS_CONFIRM_BYTE &&
+		    optional_read_back_valid(sl, *buf)) {
+			bytes_written =3D 1;
+			goto out;
 		}
=20
-#ifdef CONFIG_W1_SLAVE_DS2408_READBACK
-		/* here the master could read another byte which
-		   would be the PIO reg (the actual pin logic state)
-		   since in this driver we don't know which pins are
-		   in and outs, there's no value to read the state and
-		   compare. with (*buf) so end this command abruptly: */
 		if (w1_reset_resume_command(sl->master))
-			goto error;
+			goto out; /* unrecoverable error */
+		/* try again, the slave is ready for a command */
+	} while (--retries);
=20
-		/* go read back the output latches */
-		/* (the direct effect of the write above) */
-		w1_buf[0] =3D W1_F29_FUNC_READ_PIO_REGS;
-		w1_buf[1] =3D W1_F29_REG_OUTPUT_LATCH_STATE;
-		w1_buf[2] =3D 0;
-		w1_write_block(sl->master, w1_buf, 3);
-		/* read the result of the READ_PIO_REGS command */
-		if (w1_read_8(sl->master) =3D=3D *buf)
-#endif
-		{
-			/* success! */
-			mutex_unlock(&sl->master->bus_mutex);
-			dev_dbg(&sl->dev,
-				"mutex unlocked, retries:%d", retries);
-			return 1;
-		}
-	}
-error:
+out:
 	mutex_unlock(&sl->master->bus_mutex);
-	dev_dbg(&sl->dev, "mutex unlocked in error, retries:%d", =
retries);
=20
-	return -EIO;
+	dev_dbg(&sl->dev, "%s, mutex unlocked retries:%d\n",
+		(bytes_written > 0) ? "succeeded" : "error", retries);
+
+	return bytes_written;
 }
=20
=20
--=20
2.11.0=