Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190321141010.19612-1-brgl@bgdev.pl> <20190321141010.19612-4-brgl@bgdev.pl>
 <06c6fe16-eb33-960c-909a-635e70c3b976@lechnology.com> <CAMpxmJWDn9-W6wGTyZdAHJJnp8vHysNHNcL+qqKMRss664MhrQ@mail.gmail.com>
In-Reply-To: <CAMpxmJWDn9-W6wGTyZdAHJJnp8vHysNHNcL+qqKMRss664MhrQ@mail.gmail.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Thu, 21 Mar 2019 17:43:55 +0100
Message-ID: <CAMpxmJUT7Rc5noOAKZsoaN--hu14wQTujnH_6v8TWiO=KufNhg@mail.gmail.com>
Subject: Re: [PATCH 3/4] ARM: dts: da850-evm: enable cpufreq
To:     David Lechner <david@lechnology.com>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>, Sekhar Nori <nsekhar@ti.com>,
        Kevin Hilman <khilman@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        arm-soc <linux-arm-kernel@lists.infradead.org>,
        linux-devicetree <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Adam Ford <adam.ford@logicpd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

czw., 21 mar 2019 o 17:36 Bartosz Golaszewski
<bgolaszewski@baylibre.com> napisa=C5=82(a):
>
> czw., 21 mar 2019 o 16:53 David Lechner <david@lechnology.com> napisa=C5=
=82(a):
> >
> > On 3/21/19 9:10 AM, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >
> > > Enable cpufreq-dt support for da850-evm. The cvdd regulator is fixed
> > > at 1.2V on this board so disable the lower operating points and enabl=
e
> > > the 375MHz opp.
> >
> >
> > The board-da850-evm.c file seems to indicate that this regulator is
> > variable and comes from the tps65070. This regulator seems to be missin=
g
> > from the device tree though, even though it has device tree bindings.
> >
>
> Oh snap, you're right. I glanced over the 1.2V comment and thought
> it's the same as other boards, but actually it specifies: .min_uV =3D
> 950000, .max_uV =3D 1350000, so all the operating points should work on
> that one.
>

It seems this pmic is defined here[1] and a skeleton included here[2]
and then the regulator constraints follow.

Bart

[1] https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/da850-=
evm.dts#L224
[2] https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/da850-=
evm.dts#L326

> Bart
>
> > Cc: Adam Ford
> >
> >
> > >
> > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > ---
> > >   arch/arm/boot/dts/da850-evm.dts | 30 ++++++++++++++++++++++++++++++
> > >   1 file changed, 30 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da85=
0-evm.dts
> > > index f04bc3e15332..f63867692da4 100644
> > > --- a/arch/arm/boot/dts/da850-evm.dts
> > > +++ b/arch/arm/boot/dts/da850-evm.dts
> > > @@ -151,6 +151,15 @@
> > >                       system-clock-frequency =3D <24576000>;
> > >               };
> > >       };
> > > +
> > > +     cvdd: regulator0 {
> > > +             compatible =3D "regulator-fixed";
> > > +             regulator-name =3D "cvdd";
> > > +             regulator-min-microvolt =3D <1200000>;
> > > +             regulator-max-microvolt =3D <1200000>;
> > > +             regulator-always-on;
> > > +             regulator-boot-on;
> > > +     };
> > >   };
> > >
> > >   &ecap2 {
> > > @@ -191,6 +200,27 @@
> > >       };
> > >   };
> > >
> > > +&cpu {
> > > +     cpu-supply =3D <&cvdd>;
> > > +};
> > > +
> > > +/*
> > > + * DA850-EVM has a fixed CVDD of 1.2V - we cannot go below 300MHz or
> > > + * above 375MHz.
> > > + */
> > > +
> > > +&opp_100 {
> > > +     status =3D "disabled";
> > > +};
> > > +
> > > +&opp_200 {
> > > +     status =3D "disabled";
> > > +};
> > > +
> > > +&opp_375 {
> > > +     status =3D "okay";
> > > +};
> > > +
> > >   &sata {
> > >       status =3D "okay";
> > >   };
> > >
> >