Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp929344img; Thu, 21 Mar 2019 11:57:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqxVj6UCEiCOEM/imp+qqe/Q6UcNjFgm/phjGfiT+V/9Y/eR9s9Tfz23mo1AxBwRKsnKzXAM X-Received: by 2002:aa7:8157:: with SMTP id d23mr4823893pfn.67.1553194656204; Thu, 21 Mar 2019 11:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553194656; cv=none; d=google.com; s=arc-20160816; b=zIBSGFF/8VjQIJHd3BEPefmtnuv1VBzgfjgFpleRsnPnsCXJv+3BPNYhVnIfJSjDKF 8jHSaRfkXj2VU+ExS5pB0xenvcKr+Cig5nELR7R+4gU1QYbQDh4pvwuviC1GhZATEJCj 7lKHscWo1vNwzOXluTAsCtYPcVLOl8+uJ9Y4aoy2GC66oF9spXucbIra5RNkzit76Wyk YG/c4jG2Fnla2D9S9+l7JhWX47xGL0lt6vE4CUUaZrQ20hLrGInsWUwTZywYwjGFzgAm ikS4VAv38M/5EDIrE1vISmKECiAtUutGCQnCUI/baxWd4stPvJQ65DouKi1nTuX+XT3z Oskg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=uJxhIOt3ovw6PgVgj+JFHMD/Eoofq6ScdM5YUcAMDok=; b=n2bPDr1hXthQyWm2+x8Ptn3RdFWODIxyfHNOfq/3hrP8aKy2fAJIxtK5k6Czmjh4JY /ETJH5gomn35geJXjFCeiInjw0qQZ5XX5XRvLC2Woi9jUytvrts8AM6D8z3hYJygtRkP K7nKir9c1/aWmk+jvWeckog5HFcZPAmrAPM8k0xm0CnIrZsE1iY2Aovvr44tOzThRTDc +l2z+DIRiszrEzkoeYogRl4caY5XjYbxj8Zkk6EDMeQ9wg2otOP3+8TdmhmD1HzTpUvw 1K1MzXo3zu9jc/pmJZofniR0pSDAhjdFSQc9qy0ximwaDGfnd/9H0cfhacxB3ARpI73j 0L6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l1si5487348pld.210.2019.03.21.11.57.20; Thu, 21 Mar 2019 11:57:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728975AbfCUSz4 (ORCPT + 99 others); Thu, 21 Mar 2019 14:55:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:47424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728795AbfCUSzy (ORCPT ); Thu, 21 Mar 2019 14:55:54 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A7518205F4; Thu, 21 Mar 2019 18:55:52 +0000 (UTC) Date: Thu, 21 Mar 2019 14:55:51 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: Andy Lutomirski , Juergen Gross , LKML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Joel Fernandes , He Zhe , Linus Torvalds , Clark Williams Subject: Re: [RFC][PATCH] tracing/x86: Save CR2 before tracing irqsoff on error_entry Message-ID: <20190321145551.4c80c3a7@gandalf.local.home> In-Reply-To: <20190321182830.GV5996@hirez.programming.kicks-ass.net> References: <20190320221534.165ab87b@oasis.local.home> <20190321083317.GL6058@hirez.programming.kicks-ass.net> <20190321090241.GL6521@hirez.programming.kicks-ass.net> <20190321104517.GM6521@hirez.programming.kicks-ass.net> <20190321093242.4a948198@gandalf.local.home> <20190321172203.GS5996@hirez.programming.kicks-ass.net> <20190321141020.641e313f@gandalf.local.home> <20190321182830.GV5996@hirez.programming.kicks-ass.net> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Mar 2019 19:28:30 +0100 Peter Zijlstra wrote: > On Thu, Mar 21, 2019 at 02:10:20PM -0400, Steven Rostedt wrote: > > On Thu, 21 Mar 2019 11:05:06 -0700 > > Andy Lutomirski wrote: > > > > > In the long run, I think the right solution is to rewrite even more of > > > this mess in C. We really ought to be able to put the IRQ flag > > > tracing and the context tracking into C code. > > > > And once we do that, we can work on getting the irq tracing > > incorporated into a jump_label type that we could possibly enable > > lockdep at start up, and then disable it later, even on production > > systems! That is, to be able to turn it off and bring the system back > > up to full speed. > > You forget the stupid amount of data bloat that lockdep brings. No I didn't. Some users only care about performance, but find memory cheap. -- Steve