Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp948867img; Thu, 21 Mar 2019 12:19:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzDOxq1ETZTLTZLrWxJfXNh0lOSckjPnc27Dzxni/hRTVukr3HGgpO6fhSyApq6HYJ8ARxY X-Received: by 2002:a63:6985:: with SMTP id e127mr4927924pgc.101.1553195988544; Thu, 21 Mar 2019 12:19:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553195988; cv=none; d=google.com; s=arc-20160816; b=qfRRCquZopbYVFd6OIJMPA4jKLZz272hlNM0zJBQXp/TXyUJs69jfNAzLqyRWZ7xig BMFjL2lP9X07hy26jDDu/voR1vgNk1qAndPDxqMugWvRUTrAFZM+RcFlw+yZs4YbJH9Z bhN2bqgtpPa8YolrR3Tc7aSSm8a6V4eZchNMXCusrxK3iKLUSxMd9SfODWqS8JsO+Pc2 Wp4ekgwNNeNhcqLXsb4kyh4BonS0dt9BCFEDx0cVXO/wUpfbVpNREg2GQrR9/QXQQZIA 0iKwEe//ryQMVhuw9Ezb3VJ4HpOq9S2HsyF0/sn9YDLjm0/b7UODaU3F/fdUCAXfuYGc ENCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=7N/ex5P1qbT3v4MiBwAUuPDqCPFT4nVQ8yiJHE2mLz4=; b=08D4VmLHFBx88A4W0xc6Mxf6PEiZhv9D/Fr5clMZ/lyGauAeTjzjHptwSEU+u2M++N q8O+9khD+b738uLM7G4n2ZqU5d42nRVbsOWP8B1iD1uFevgz0fB7UrnzX8y6E7UlxcFr RGwGlF2o9XleFjXaQ6+f7aduNcr282eXF1A0lv/htvTqc25nztTJT6FuQR78EXpQn4NZ K+/gPNaHjIT8FjyFAAGqikWYUIFeVu9+CQkpsXZU7I4/l1Rx8Tjw5jNdA+NHQrPE9Clr 5J7oOmrP2c/bwxPo98aTqJW8k1SuiPVkQvxHQSPg4IpAHn1j8ZXntSQwBtqGCeG82J+Q 3rLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 25si4809670pgt.419.2019.03.21.12.19.30; Thu, 21 Mar 2019 12:19:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728592AbfCUTSe (ORCPT + 99 others); Thu, 21 Mar 2019 15:18:34 -0400 Received: from sandeen.net ([63.231.237.45]:52622 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727958AbfCUTSe (ORCPT ); Thu, 21 Mar 2019 15:18:34 -0400 Received: from [10.0.0.4] (liberator [10.0.0.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTPSA id DCA562B3B; Thu, 21 Mar 2019 14:18:31 -0500 (CDT) Subject: Re: [PATCH 0/6] sysctl: add pending proc_do_large_bitmap fix To: Eric Sandeen , Luis Chamberlain , akpm@linux-foundation.org, keescook@chromium.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190320222831.8243-1-mcgrof@kernel.org> <2c1811ae-1cad-8ec8-7948-519517cf4eba@redhat.com> From: Eric Sandeen Openpgp: preference=signencrypt Autocrypt: addr=sandeen@sandeen.net; prefer-encrypt=mutual; keydata= mQINBE6x99QBEADMR+yNFBc1Y5avoUhzI/sdR9ANwznsNpiCtZlaO4pIWvqQJCjBzp96cpCs nQZV32nqJBYnDpBDITBqTa/EF+IrHx8gKq8TaSBLHUq2ju2gJJLfBoL7V3807PQcI18YzkF+ WL05ODFQ2cemDhx5uLghHEeOxuGj+1AI+kh/FCzMedHc6k87Yu2ZuaWF+Gh1W2ix6hikRJmQ vj5BEeAx7xKkyBhzdbNIbbjV/iGi9b26B/dNcyd5w2My2gxMtxaiP7q5b6GM2rsQklHP8FtW ZiYO7jsg/qIppR1C6Zr5jK1GQlMUIclYFeBbKggJ9mSwXJH7MIftilGQ8KDvNuV5AbkronGC sEEHj2khs7GfVv4pmUUHf1MRIvV0x3WJkpmhuZaYg8AdJlyGKgp+TQ7B+wCjNTdVqMI1vDk2 BS6Rg851ay7AypbCPx2w4d8jIkQEgNjACHVDU89PNKAjScK1aTnW+HNUqg9BliCvuX5g4z2j gJBs57loTWAGe2Ve3cMy3VoQ40Wt3yKK0Eno8jfgzgb48wyycINZgnseMRhxc2c8hd51tftK LKhPj4c7uqjnBjrgOVaVBupGUmvLiePlnW56zJZ51BR5igWnILeOJ1ZIcf7KsaHyE6B1mG+X dmYtjDhjf3NAcoBWJuj8euxMB6TcQN2MrSXy5wSKaw40evooGwARAQABtCVFcmljIFIuIFNh bmRlZW4gPHNhbmRlZW5Ac2FuZGVlbi5uZXQ+iQI7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCUzMzbAIZAQAKCRAgrhaS4T3e4Fr7D/wO+fenqVvHjq21SCjDCrt8HdVj aJ28B1SqSU2toxyg5I160GllAxEHpLFGdbFAhQfBtnmlY9eMjwmJb0sCIrkrB6XNPSPA/B2B UPISh0z2odJv35/euJF71qIFgWzp2czJHkHWwVZaZpMWWNvsLIroXoR+uA9c2V1hQFVAJZyk EE4xzfm1+oVtjIC12B9tTCuS00pY3AUy21yzNowT6SSk7HAzmtG/PJ/uSB5wEkwldB6jVs2A sjOg1wMwVvh/JHilsQg4HSmDfObmZj1d0RWlMWcUE7csRnCE0ZWBMp/ttTn+oosioGa09HAS 9jAnauznmYg43oQ5Akd8iQRxz5I58F/+JsdKvWiyrPDfYZtFS+UIgWD7x+mHBZ53Qjazszox gjwO9ehZpwUQxBm4I0lPDAKw3HJA+GwwiubTSlq5PS3P7QoCjaV8llH1bNFZMz2o8wPANiDx 5FHgpRVgwLHakoCU1Gc+LXHXBzDXt7Cj02WYHdFzMm2hXaslRdhNGowLo1SXZFXa41KGTlNe 4di53y9CK5ynV0z+YUa+5LR6RdHrHtgywdKnjeWdqhoVpsWIeORtwWGX8evNOiKJ7j0RsHha WrePTubr5nuYTDsQqgc2r4aBIOpeSRR2brlT/UE3wGgy9LY78L4EwPR0MzzecfE1Ws60iSqw Pu3vhb7h3bkCDQROsffUARAA0DrUifTrXQzqxO8aiQOC5p9Tz25Np/Tfpv1rofOwL8VPBMvJ X4P5l1V2yd70MZRUVgjmCydEyxLJ6G2YyHO2IZTEajUY0Up+b3ErOpLpZwhvgWatjifpj6bB SKuDXeThqFdkphF5kAmgfVAIkan5SxWK3+S0V2F/oxstIViBhMhDwI6XsRlnVBoLLYcEilxA 2FlRUS7MOZGmRJkRtdGD5koVZSM6xVZQSmfEBaYQ/WJBGJQdPy94nnlAVn3lH3+N7pXvNUuC GV+t4YUt3tLcRuIpYBCOWlc7bpgeCps5Xa0dIZgJ8Louu6OBJ5vVXjPxTlkFdT0S0/uerCG5 1u8p6sGRLnUeAUGkQfIUqGUjW2rHaXgWNvzOV6i3tf9YaiXKl3avFaNW1kKBs0T5M1cnlWZU Utl6k04lz5OjoNY9J/bGyV3DSlkblXRMK87iLYQSrcV6cFz9PRl4vW1LGff3xRQHngeN5fPx ze8X5NE3hb+SSwyMSEqJxhVTXJVfQWWW0dQxP7HNwqmOWYF/6m+1gK/Y2gY3jAQnsWTru4RV TZGnKwEPmOCpSUvsTRXsVHgsWJ70qd0yOSjWuiv4b8vmD3+QFgyvCBxPMdP3xsxN5etheLMO gRwWpLn6yNFq/xtgs+ECgG+gR78yXQyA7iCs5tFs2OrMqV5juSMGmn0kxJUAEQEAAYkCHwQY AQIACQUCTrH31AIbDAAKCRAgrhaS4T3e4BKwD/0ZOOmUNOZCSOLAMjZx3mtYtjYgfUNKi0ki YPveGoRWTqbis8UitPtNrG4XxgzLOijSdOEzQwkdOIp/QnZhGNssMejCnsluK0GQd+RkFVWN mcQT78hBeGcnEMAXZKq7bkIKzvc06GFmkMbX/gAl6DiNGv0UNAX+5FYh+ucCJZSyAp3sA+9/ LKjxnTedX0aygXA6rkpX0Y0FvN/9dfm47+LGq7WAqBOyYTU3E6/+Z72bZoG/cG7ANLxcPool LOrU43oqFnD8QwcN56y4VfFj3/jDF2MX3xu4v2OjglVjMEYHTCxP3mpxesGHuqOit/FR+mF0 MP9JGfj6x+bj/9JMBtCW1bY/aPeMdPGTJvXjGtOVYblGZrSjXRn5++Uuy36CvkcrjuziSDG+ JEexGxczWwN4mrOQWhMT5Jyb+18CO+CWxJfHaYXiLEW7dI1AynL4jjn4W0MSiXpWDUw+fsBO Pk6ah10C4+R1Jc7dyUsKksMfvvhRX1hTIXhth85H16706bneTayZBhlZ/hK18uqTX+s0onG/ m1F3vYvdlE4p2ts1mmixMF7KajN9/E5RQtiSArvKTbfsB6Two4MthIuLuf+M0mI4gPl9SPlf fWCYVPhaU9o83y1KFbD/+lh1pjP7bEu/YudBvz7F2Myjh4/9GUAijrCTNeDTDAgvIJDjXuLX pA== Message-ID: <1790444d-db2a-6a92-b49e-513700c00f5c@sandeen.net> Date: Thu, 21 Mar 2019 14:18:32 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <2c1811ae-1cad-8ec8-7948-519517cf4eba@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/19 12:13 PM, Eric Sandeen wrote: > On 3/20/19 5:28 PM, Luis Chamberlain wrote: >> Andrew, Kees, >> >> Eric sent a fix out for proc_do_large_bitmap() last month for when >> using a large input buffer. After patch review a test case for the issue >> was built and submitted. I noticed there were a few issues with the >> tests, but instead of just asking Eric to address them I've taken >> care of them and ammended the commit where necessary. There's a >> few issues he reported which I also address and fix in this series. >> >> Since we *do* expect users of these scripts to also use them on older >> kernels, I've also addressed not breaking calling the script for them, >> and gives us an easy way to easily extend our tests cases for future >> kernels as well. >> >> Before anyone considers these for stable as minor fixes, I'd recommend >> we also address the discrepancy on the read side of things: modify the >> test script to use diff against the target file instead of using the >> temp file. >> >> Eric Sandeen (2): >> test_sysctl: add proc_do_large_bitmap() test case >> sysctl: Fix proc_do_large_bitmap for large input buffers > > Isn't this missing: > > [PATCH] sysctl: add proc_do_large_bitmap test node Oh, I see, you rolled it into the test patch. that wasn't clear...