Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Mar 2019 15:50:06 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Andy Lutomirski <luto@amacapital.net>,
        Juergen Gross <jgross@suse.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Joel Fernandes <joel@joelfernandes.org>,
        He Zhe <zhe.he@windriver.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Clark Williams <williams@redhat.com>
Subject: Re: [RFC][PATCH] tracing/x86: Save CR2 before tracing irqsoff on
 error_entry
Message-ID: <20190321155006.5288345f@gandalf.local.home>
In-Reply-To: <20190321193152.GB2490@worktop.programming.kicks-ass.net>
References: <20190320221534.165ab87b@oasis.local.home>
        <20190321083317.GL6058@hirez.programming.kicks-ass.net>
        <20190321090241.GL6521@hirez.programming.kicks-ass.net>
        <20190321104517.GM6521@hirez.programming.kicks-ass.net>
        <20190321093242.4a948198@gandalf.local.home>
        <20190321172203.GS5996@hirez.programming.kicks-ass.net>
        <CALCETrXqmjJt7azNoEtxs2eBkDd-vjUAYvrjNh_RD30DAvksBw@mail.gmail.com>
        <20190321141020.641e313f@gandalf.local.home>
        <20190321182830.GV5996@hirez.programming.kicks-ass.net>
        <20190321145551.4c80c3a7@gandalf.local.home>
        <20190321193152.GB2490@worktop.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 21 Mar 2019 20:31:52 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> > 
> > No I didn't. Some users only care about performance, but find memory
> > cheap.  
> 
> Because cache-misses are free?

If I ever did implement this, I would try to get all the data out of
line as much as possible, where only a nop would be inserted:

	jmp lockdep_code
	raw_locking
1:

[..]

lockdep_code:
	do all that lockdep needs
	raw_locking
	jmp 1b

and have that converted to:


	nop // jmp lockdep_code
	raw_locking
1:

when disabled. So the only extra pressure on the icache is the nop.

-- Steve