Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp117430img; Thu, 21 Mar 2019 15:33:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqzxjHmoCJMfo9/vvMNTpby67+pid3FibCIQAb2Acw/r0yhJ1LPf+yZbijtVycndfZ9IXH8u X-Received: by 2002:a17:902:8203:: with SMTP id x3mr6031167pln.159.1553207631047; Thu, 21 Mar 2019 15:33:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553207631; cv=none; d=google.com; s=arc-20160816; b=JGarZeegDfEu+Zqi+GO7CzPfAgez5xln4esWuCc+SCIY8wUYqp4p12ZUFMex3PTSxn VBaVCk09OS6d8yCjSZS4qZMSRE48ZAeSG4dU92zvx+t7NxCp7vARzmf0afRjqN+cjvgX J3sS4tTqqYGTBH3GAeBneNX3HI7SztpYK6tXN53FxHdUVzplF3TYFoGQqJQa7c5+m1mx h+KPUZGYwTLcXz6LK2nXZR4IQTSLIMs69prHw6CLj1kINWpJ6YEUCtzKSQEyFI/wMDDv BUFNtLCW/t+yH5qhMt44qFkE04hkm3+6dK3/FpF4WcT53XNzHEe2WccqKta9vXPzAl1L mIjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-reaction:dlp-version:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=EdVAAy9yPbDm7RdpggiK+ToVkkrOQPgUbL1vTWIS81Y=; b=W4SgKv0W87I1RMytcnwyt/2KtVUWC7AM4laiocvBZgJupQ1Efktar483YlOT65EsX0 FXbD+dDawlPoOBZEZIzoizh6Ijo8KmGSnoJhyxHU+2u91gGW3h1ycdxaiTjsIVzNPKtB XMziO5T5eWkzYV81JUuc51BY0/u8OHroh+cVQHDH2XH7aJ32z8d3qigVqoOpHM0MIJYp J1X8pmu9aWChgd+D/ytIz81gC6nSj+xrprOzwo5fsSCYuX4ONyA0hPwxcEeM0B6qVrV5 /365bJnJWFOFNnMA42gQewf8WFafxWtx4Qvtgy5blKqlNdtuHUDd0Isz6FeKDDMVMPSY RozQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 5si5594571plx.421.2019.03.21.15.33.33; Thu, 21 Mar 2019 15:33:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727062AbfCUWcu convert rfc822-to-8bit (ORCPT + 99 others); Thu, 21 Mar 2019 18:32:50 -0400 Received: from mga04.intel.com ([192.55.52.120]:5858 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfCUWct (ORCPT ); Thu, 21 Mar 2019 18:32:49 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 15:32:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,254,1549958400"; d="scan'208";a="142746386" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by FMSMGA003.fm.intel.com with ESMTP; 21 Mar 2019 15:32:48 -0700 Received: from orsmsx125.amr.corp.intel.com (10.22.240.125) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 21 Mar 2019 15:32:48 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.204]) by ORSMSX125.amr.corp.intel.com ([169.254.3.65]) with mapi id 14.03.0415.000; Thu, 21 Mar 2019 15:32:48 -0700 From: "Bowers, AndrewX" To: "netdev@vger.kernel.org" CC: open list , "moderated list:INTEL ETHERNET DRIVERS" Subject: RE: [Intel-wired-lan] [PATCH net] ixgbe: fix mdio bus registration Thread-Topic: [Intel-wired-lan] [PATCH net] ixgbe: fix mdio bus registration Thread-Index: AQHU2035ZLA7+Fy1r0SThbLM+B9IgaYWtUYA Date: Thu, 21 Mar 2019 22:32:47 +0000 Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A1D376AA9@ORSMSX104.amr.corp.intel.com> References: <20190315084515.22983-1-ivecera@redhat.com> In-Reply-To: <20190315084515.22983-1-ivecera@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjY1OGJiOTktNmFmOC00MDIwLWI5OWQtMjJiNmYyOThhYWEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU01RNk5LaWQ5VUtLUjBkNjZlZEdEVm1MQjYzVTNkWDl2TzRjaXdab09VYTlIa0dpZFExSzBxS1wvR1FUMVF3XC93In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Ivan Vecera > Sent: Friday, March 15, 2019 1:45 AM > To: netdev@vger.kernel.org > Cc: open list ; moderated list:INTEL > ETHERNET DRIVERS ; David S. Miller > > Subject: [Intel-wired-lan] [PATCH net] ixgbe: fix mdio bus registration > > The ixgbe ignores errors returned from mdiobus_register() and leaves > adapter->mii_bus non-NULL and MDIO bus state as MDIOBUS_ALLOCATED. > This triggers a BUG from mdiobus_unregister() during ixgbe_remove() call. > > Fixes: 8fa10ef01260 ("ixgbe: register a mdiobus") > Signed-off-by: Ivan Vecera > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) Tested-by: Andrew Bowers