Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp232731img; Thu, 21 Mar 2019 18:48:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqxmoww6j1RvCxt17AFl+DCf7PqkXgvmkR1PvnKAcvo1IzU3I2y0/WrQ+UttKT1VAa9m5sj5 X-Received: by 2002:aa7:914f:: with SMTP id 15mr6480340pfi.49.1553219316606; Thu, 21 Mar 2019 18:48:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553219316; cv=none; d=google.com; s=arc-20160816; b=abIgBao1HoL6StTDPo7TShL5uvnnJ8a5MZPkYpB3l+niUhuMkeij3BBp0Fz7GDw0xz 2ekNduTzgd8RC0zyPVQA3QfJRbJhzj+Hji6VLJMkmn16BWmwniiU3tXbZ/az8+ardr4l IWhrv/t2bVYcpwGOxPaODggGLd4PTAz9VxeON3Ed2XS9ekoS3xHFQu50Y33XDh6hsXa9 b3P0LLsptXpeLyARINVNhSUFKzdOKED26ufHoo9MhT6nLG9ouuChEBusxXG29tFBj7Iw LiqGIS6puucc5u0ppyQXLab4fICXQ1Sd24Fo9rj48g5i9zuwKeouTdQZ3k+x434Q96p8 SnqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=x5Low4SuSzWr6ujbDyxHrARXjGVys0Q5FQRetssJ/yY=; b=KvZ17WX7WMf8IrVwzYFYbIC8aNDODD2hFyD0xoe6Enc57T+EqLYgfmiXkWuo3f0UOz fflFWXSzXYteLWhZrA1GiXuJGXYyxBIRr+GbI8jgYVrt5QQqk+VjV5woureE1p6PXSFX 6i4JJ7zQ6OfnZyEHtmHMT9RQKlyK3Ru5hhnWVTf170133zAcVHyhLRClcBDDpW6WsazZ thn0G/VrGOuw/S62HQBmKICV6YD/n/GEK4C17FyDbWRHR2uslokffdikNrii7VLUH8cG yQHJrW+7GUj+KvyihAOimjPrTWEv7gObxYmCByTPam7BEfhunr5ZFUOmgVR1ESb5OSMa Fveg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=T7TjPlkJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l7si5931784plb.219.2019.03.21.18.48.21; Thu, 21 Mar 2019 18:48:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=T7TjPlkJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727577AbfCVBqJ (ORCPT + 99 others); Thu, 21 Mar 2019 21:46:09 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:39754 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbfCVBqJ (ORCPT ); Thu, 21 Mar 2019 21:46:09 -0400 Received: by mail-ot1-f65.google.com with SMTP id f10so595363otb.6 for ; Thu, 21 Mar 2019 18:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x5Low4SuSzWr6ujbDyxHrARXjGVys0Q5FQRetssJ/yY=; b=T7TjPlkJIXF7J9SZ+bV1+gtfPYv4ahYUwC0C7UfS+kQHoq0koldlw5i82ZgzJzKmih 76beQhdFRHnJE5OWJWYyP0kiR5MzzW8sDkKL06X/b9iy2DNLPF5gY8izh3FQY/oiBP/V HhVSlZQF+z3K5McQKdSAvvb5eQdWR1VuqrapcS5h1nvNa/Retg50SMYxY3UlwfmI1rTH LRN+K0+gshCBFW/bYaCFwZFNjU8WStUIdpU1nF1vQN2Mq6+G0EP+TasUXYko1gTcz27F r9v70by+4ETaDxNNU6B5nVPr7YtkItNXAnBpTYrTMTV2QXcBUxeuJIzJq/eN4JHkTHXX WiSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x5Low4SuSzWr6ujbDyxHrARXjGVys0Q5FQRetssJ/yY=; b=rHC/mBg76yS43iSBrA2LZHdTSzwmbamHQ/jmzM9hM7bsZ9Fz62MWq7LWcW1hCLVDN9 dYWJ6m5EhQfyNvOnhKfuIEh0hPAIdwn2IyZ5w8Ki3tFwthKhnoGSkrO2ExaWA3fQgns0 sM3Ou+kRrIkEWfmyE9oZj2kWlMcZxVCOALHAge+xGsSXO/E5HAC7eef0LPzFowEgH1JJ Zi202Ymp7/zyxJh3Zp9cDeBcPoWa+NCTY7SlT3ityN01+XQDIElmcI1bo5PDI62PBOqh nor+2i7DpWwoZumUENz4f9maN57YhTT+WF+h1POioMdpx1hbI8W18yrkkXfXJGTU8ut7 Q0Hg== X-Gm-Message-State: APjAAAVRlMI/Qjlb/lyuqDlPg4UmPbJ1F+sszpvyJmz8ih1FHCYbFFNH JRyTsYCA15xsAxywDBQxiocGBGBaT6FlMh7V0xjDNw== X-Received: by 2002:a9d:d66:: with SMTP id 93mr4885898oti.25.1553219167991; Thu, 21 Mar 2019 18:46:07 -0700 (PDT) MIME-Version: 1.0 References: <20190214213729.21702-1-brendanhiggins@google.com> <20190214213729.21702-18-brendanhiggins@google.com> <09b06e6d-fd36-707e-cb7a-e935bd930510@gmail.com> In-Reply-To: <09b06e6d-fd36-707e-cb7a-e935bd930510@gmail.com> From: Brendan Higgins Date: Thu, 21 Mar 2019 18:45:56 -0700 Message-ID: Subject: Re: [RFC v4 17/17] of: unittest: split up some super large test cases To: Frank Rowand Cc: Kees Cook , Luis Chamberlain , shuah@kernel.org, Rob Herring , Kieran Bingham , Greg KH , Joel Stanley , Michael Ellerman , Joe Perches , brakmo@fb.com, Steven Rostedt , "Bird, Timothy" , Kevin Hilman , Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Linux Kernel Mailing List , Jeff Dike , Richard Weinberger , linux-um@lists.infradead.org, Daniel Vetter , dri-devel , Dan Williams , linux-nvdimm , Knut Omang , devicetree , Petr Mladek , Sasha Levin , Amir Goldstein , Dan Carpenter , wfg@linux.intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 21, 2019 at 6:16 PM Frank Rowand wrote: > > On 2/14/19 1:37 PM, Brendan Higgins wrote: > > Split up the super large test cases of_unittest_find_node_by_name and > > of_unittest_dynamic into properly sized and defined test cases. > > I also still object to this patch. I figured. Will drop.