Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp350894img; Thu, 21 Mar 2019 22:39:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqw24TmdHimfoptFYBXBBZgCTHhicYBPvoby1hzyLwvYhuHddxSpYnkBrJ/tvP2U2pExfqG0 X-Received: by 2002:a63:2f44:: with SMTP id v65mr7051952pgv.141.1553233152123; Thu, 21 Mar 2019 22:39:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553233152; cv=none; d=google.com; s=arc-20160816; b=YYlWtdZFpuKq+SU5ci92vVSMBqyGCEUD87eyz3Bw2z8nsCxCtr8/exhAZ8bkj9DQkU OhImSelCihlkK2gbnEDr/X0jLJRNNJnF9QIBXrcWAf/DT6qA4fIVkmR4tE9Bduj6xtlK FSYzpwjuK4tmWmbimnCrYuIU7Egomz2hbj9k1AGcHNeYeFgnYotMfcWdyu1m83MGNcUW sA7ny6N6HljsTBhOKZYw7GZmSyc78YiBGQZXpTW/lL2+MBS9HXMjSRppH+N2znYx5GG8 8J6sF9N8/SXZkMcih7La3/5+yccTY+UXnDOCvzLEySkXa7EijB31YcXgEbYlnB4jbDuK oThw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=y3PF+rLm0iFQ/3SMB4rtvppVcCSlyW59feapyZPVwwM=; b=AGg1ryUXQu1JvFLd/lm2qGFWtHR/kxPklWj0wMyFV/35EPHE91DQgJOdghHsAtHMS6 pwRhwLwLxrptUotetPs3v33Ps/O6v0I2aL5DO0W+M42vo1Z2Kyx4JOm8YPvHEG3zWVYw 0RnJwXyFd6N9M4DAJ8urjCkvG89ys2GGAOYddODs5ZgxgOW0ABJ/uNl0RVUCByXoUiLs C5Gc+xRhMqFnBXUfPHgU0Ej427PNZxQu+9GvTfXpvZ0WjC5aKmux0AlE1B+a34QveRCG dfeZbLhIk3B3vupAoUmcslOp8MtUkTgb/mhHAhGN9RDBOY0o4JYBXRv9UbRTXiYIC+Ul LQNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B2qgywxH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o1si6130450plk.7.2019.03.21.22.38.54; Thu, 21 Mar 2019 22:39:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B2qgywxH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727740AbfCVFhq (ORCPT + 99 others); Fri, 22 Mar 2019 01:37:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:46248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbfCVFhq (ORCPT ); Fri, 22 Mar 2019 01:37:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EEC1A218B0; Fri, 22 Mar 2019 05:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553233065; bh=vEj6MDvfvi5+o7E9dbvy4Ex3YdChPz9jwzNJi/OEplo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B2qgywxH3J5axp3waQgKMyBU7NKwGKLtN24aR0dYqoKZfqYfE7JaeAwJukAtc3IgD ttiuWr7TeNsmNqiTdkDhB0SyI2TAwCZ1D9oxzNtluh7q9J7WY0GYwpGLcrNw0BGWQ2 Tc+1uUmTdfg1SiuI84lnQg4DHgwSsrMdYvY8YOHI= Date: Fri, 22 Mar 2019 06:37:42 +0100 From: Greg Kroah-Hartman To: Jochen Sprickerhof Cc: Marek Szyprowski , Roger Quadros , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I Subject: Re: [PATCH] usb: dwc3: Softdep for GBit Ethernet on Odroid XU4 Message-ID: <20190322053742.GB31708@kroah.com> References: <20190321202303.GA1399@vis> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321202303.GA1399@vis> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 21, 2019 at 09:23:03PM +0100, Jochen Sprickerhof wrote: > This adds a soft dependency to the dwc3 module to load it after > xhci-plat as proposed in: > > https://marc.info/?l=linux-usb&m=155230272022603&w=2 > > Old behaviour: > > $ lsusb -t > /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M > /: Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M > |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M > > New behaviour: > > $ lsusb -t > /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M > |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M > > Tested on Debian unstable using Linux 4.19.29. > > Note, this needs a hard reset when coming from an unpatched kernel. > > Signed-off-by: Jochen Sprickerhof > --- > drivers/usb/dwc3/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 103807587dc6..9017e4ed9d99 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1746,3 +1746,4 @@ MODULE_ALIAS("platform:dwc3"); > MODULE_AUTHOR("Felipe Balbi "); > MODULE_LICENSE("GPL v2"); > MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver"); > +MODULE_SOFTDEP("pre: xhci_plat_hcd"); Your patch is corrupted and can not be applied :(