Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Mar 2019 12:15:06 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Aaro Koskinen <aaro.koskinen@iki.fi>
Cc:     "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BISECTED, REGRESSION] Broken networking on MIPS/OCTEON
 EdgeRouter Lite
Message-ID: <20190322064506.GB5348@vkoul-mobl>
References: <20190322002125.GD7872@darkstar.musicnaut.iki.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190322002125.GD7872@darkstar.musicnaut.iki.fi>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 22-03-19, 02:21, Aaro Koskinen wrote:
> Hi,
> 
> When booting v5.1-rc1 on EdgeRouter Lite (MIPS/OCTEON), with at803x phy
> driver enabled, networking no longer works - I even need to go physically
> power cycle the board before getting networking to work again (otherwise
> bootloader cannot tftp an older working image).
> 
> Bisected to:
> 
> 	commit 6d4cd041f0af5b4c8fc742b4a68eac22e420e28c
> 	Author: Vinod Koul <vkoul@kernel.org>
> 	Date:   Thu Feb 21 15:53:15 2019 +0530
> 
> 	    net: phy: at803x: disable delay only for RGMII mode

Hello,

So with cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII
mode") it works for you but not 6d4cd041f0af ("net: phy: at803x: disable
delay only for RGMII mode"). That is bit more weird case :)

So does the ethernet expect RGMII mode or RGMII_ID mode here, looks like
disable delay is expected as well?

Can you point me to the DT node as well..

> Booting v5.1-rc1 with this commit reverted makes networking to work
> fine again.

-- 
~Vinod