Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp443381img; Fri, 22 Mar 2019 01:09:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzm0pXV8AkzhlpO9FYH+gsFpEIndsGMD04THUeazI93Kf6YCHJ55wQ6PYCw4KftEEUs1Cox X-Received: by 2002:aa7:8249:: with SMTP id e9mr7777700pfn.6.1553242185472; Fri, 22 Mar 2019 01:09:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553242185; cv=none; d=google.com; s=arc-20160816; b=MxZHRRWsXTr2NEt5MEPHqUokbesLifVlJFTudGzfBs6p02X6+Y+DcRByfGY82+BvHv khcAyiGSSf3SwKNYN4XeSHHinm9n5y+bsEPh0PcgSJFxP8dqjdwj4GsWytNbhGW1Gxk+ 8FlpDs1qG8c26hHUOu8jqlRmMpVWmcaCsF/+FeOia/+naU1Z/EhLv4HmG+N+YPzBO+SH xiCN6epobYr9J+7zmam+E4+eCPIMQacE9cwiMuOQGRV3V8sFYROsni0njp18/HxPOXA3 Ja9J2NsRlgfyP8aETkz864LyOkvmRhmvJe1OUVLZtkhB/SY8A4ps1WZDTjGFcFnjIiyW NiUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:cc:to:subject:from:references :in-reply-to:message-id:dkim-signature; bh=clISJmG2l3/ZkCVole2S2gui9mKGtnTXA7Zm6ytBbNw=; b=SmqJILWR0rGW88b/BmKxyqAZxybXLd1Uc5Y3bcL4PziX6/JarE4MFlmOBwIrLuB06c R01bk/4yofNmbC0k0Yw2o3O0BxNrm9vBPib+OK5YQYx4gWwKhvG6YUqMzJ5qaagGZ4xt RAe0Y7Djr+v4fUcBuBNKuWQtOvtvrf/CZZwKUDTI2S34/VtdM1a48uYbtZGKSoq39GSL Ay1UOtsNWi2+3PA059GEo3TLkd/cp7RKDHKLoW2aK2NuDLlcsKE9YKiI5ysIUC75f0OX +bLZ64al8qqrZIvpbr630aGD61iV02afLHN/rWZS2jkj6rIEehaqSTfYAaE04u5ShMCK z/aA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=SxxSXPj8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u65si6647950pfj.218.2019.03.22.01.09.30; Fri, 22 Mar 2019 01:09:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=SxxSXPj8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727724AbfCVIIt (ORCPT + 99 others); Fri, 22 Mar 2019 04:08:49 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:12244 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbfCVIIq (ORCPT ); Fri, 22 Mar 2019 04:08:46 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 44Qbrr3Rf9z9vCWG; Fri, 22 Mar 2019 09:08:44 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=SxxSXPj8; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 9Z9pn60CMHs0; Fri, 22 Mar 2019 09:08:44 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 44Qbrr2Dyzz9v9vG; Fri, 22 Mar 2019 09:08:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1553242124; bh=clISJmG2l3/ZkCVole2S2gui9mKGtnTXA7Zm6ytBbNw=; h=In-Reply-To:References:From:Subject:To:Cc:Date:From; b=SxxSXPj8CWxsFCGtaGYHQ5u8Hax2Ec5WM6xFZd5i5YgZTgT2MrbV+XjQaLjyXkxfN ZRYsvt0M3e+DcSXXMT/g9nqYZ32n9kCqx4iOJvaWKMuSuTarC31h9hVDcwFXqg4FNh DjF+M/GcznQ5LCFOHSFREhZulkJhO2o8D7dfktJY= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2BD0D8B845; Fri, 22 Mar 2019 09:08:45 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id BIK7wei4BPRL; Fri, 22 Mar 2019 09:08:45 +0100 (CET) Received: from po16846vm.idsi0.si.c-s.fr (po15451.idsi0.si.c-s.fr [172.25.231.2]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 12CC08B844; Fri, 22 Mar 2019 09:08:45 +0100 (CET) Received: by po16846vm.idsi0.si.c-s.fr (Postfix, from userid 0) id EE1086CD85; Fri, 22 Mar 2019 08:08:44 +0000 (UTC) Message-Id: In-Reply-To: References: From: Christophe Leroy Subject: [PATCH 6/7] powerpc/setup: cleanup the #ifdef CONFIG_TAU block To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Fri, 22 Mar 2019 08:08:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use cpu_has_feature() instead of opencoding Use IS_ENABLED() instead of #ifdef for CONFIG_TAU_AVERAGE Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/setup-common.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c index 95d545e94c28..b6c86287085a 100644 --- a/arch/powerpc/kernel/setup-common.c +++ b/arch/powerpc/kernel/setup-common.c @@ -254,18 +254,18 @@ static int show_cpuinfo(struct seq_file *m, void *v) seq_printf(m, "\n"); #ifdef CONFIG_TAU - if (cur_cpu_spec->cpu_features & CPU_FTR_TAU) { -#ifdef CONFIG_TAU_AVERAGE - /* more straightforward, but potentially misleading */ - seq_printf(m, "temperature \t: %u C (uncalibrated)\n", - cpu_temp(cpu_id)); -#else - /* show the actual temp sensor range */ - u32 temp; - temp = cpu_temp_both(cpu_id); - seq_printf(m, "temperature \t: %u-%u C (uncalibrated)\n", - temp & 0xff, temp >> 16); -#endif + if (cpu_has_feature(CPU_FTR_TAU)) { + if (IS_ENABLED(CONFIG_TAU_AVERAGE)) { + /* more straightforward, but potentially misleading */ + seq_printf(m, "temperature \t: %u C (uncalibrated)\n", + cpu_temp(cpu_id)); + } else { + /* show the actual temp sensor range */ + u32 temp; + temp = cpu_temp_both(cpu_id); + seq_printf(m, "temperature \t: %u-%u C (uncalibrated)\n", + temp & 0xff, temp >> 16); + } } #endif /* CONFIG_TAU */ -- 2.13.3