Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp535687img; Fri, 22 Mar 2019 03:26:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqzMQqdZnn+XE9EXx/QmD4bcVL1aa/h/5zyV4MI3ZPJuvBqNAanMunLQuR7nO2ZJ0gJg2lC1 X-Received: by 2002:a65:5b47:: with SMTP id y7mr8134229pgr.449.1553250364500; Fri, 22 Mar 2019 03:26:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553250364; cv=none; d=google.com; s=arc-20160816; b=IrI9+iCgp3bBNI9+u2FBbsgWqlu/umBglb6AVqnWYxyJ0bWhN7yGfOugClQHKv8FUl LZjAVKHHGh6wOMNZ00FgQkWddWSUQgsnDShoyGe2M4Ghg5D+3znS9/1hwSvJ67VfFzQI jP48ZPi/iXoXdBnBkwAdv+QruTxLWOq65eNQy2POOpdVeUWV/N2DaYjLuqxPNZjyrj4i COgps8BdWcslBplGgEp/lc5Txp37R70jmQrc65xm4+neGpq1qSZZVzpoIFRFqJDQZTE+ zI6nwcRMxf3b7wx5hWvTmTh5agWhpSD4s+hIaxNH3jXz28alxKYFL+VCTO+yADINgHc0 h7Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ZbGC2mnEeJdatgaGQteeXBb+NTgv66VI3eHPK+nwWvg=; b=KBV6IGjYDchzCQI5B8jztQVA+1M81FTLRy9a+t/riqICi1Snej6fPc2ufOBaQc4zQf qGqtvZxtQC825Xm/8t67T66DXuvFoMoZVfGte05CF4CHWquCZX1jX6w3CToBIQINLoPD mGtDp0mdJSbU78UG1eRhSE+nrJoYUey88jXjY9hgXML+zP5wbFKFsL1lhSCFLGYlVOs2 D7qLMSWaGytVpKha6jXxRFlkPm9L3FnhLRMhfRgdYGI63mJFps3nRQ8XwLx8v74hfgyR POa23dsbLbGocAQUP3iVS0l+et7SU0TZZ5YqGF0HNG7Niv9+2t9RSieG2ixaUzynLlDx 5zWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e16si5971663pgv.436.2019.03.22.03.25.48; Fri, 22 Mar 2019 03:26:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727979AbfCVKZN (ORCPT + 99 others); Fri, 22 Mar 2019 06:25:13 -0400 Received: from mga09.intel.com ([134.134.136.24]:56305 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727739AbfCVKZM (ORCPT ); Fri, 22 Mar 2019 06:25:12 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2019 03:25:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="154142967" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga002.fm.intel.com with SMTP; 22 Mar 2019 03:25:08 -0700 Received: by lahna (sSMTP sendmail emulation); Fri, 22 Mar 2019 12:25:08 +0200 Date: Fri, 22 Mar 2019 12:25:08 +0200 From: Mika Westerberg To: Aditya Pakki Cc: kjlu@umn.edu, Andreas Noever , Michael Jamet , Yehezkel Bernat , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] thunderbolt: Fix to check for kmemdup failure Message-ID: <20190322102508.GS3622@lahna.fi.intel.com> References: <20190320155754.29731-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190320155754.29731-1-pakki001@umn.edu> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 20, 2019 at 10:57:54AM -0500, Aditya Pakki wrote: > Memory allocated via kmemdup might fail and return a NULL pointer. > This patch adds a check on the return value of kmemdup and passes the > error upstream. > > Signed-off-by: Aditya Pakki Applied, thanks!