Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp536879img; Fri, 22 Mar 2019 03:27:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqyldEJVsd2ZdbCZmTHH6irPolsoe2I3CkvpM4Ao0e0OUKpMuB7GGZHujle1rX9bugVOkkXr X-Received: by 2002:a63:6a08:: with SMTP id f8mr8218405pgc.165.1553250476649; Fri, 22 Mar 2019 03:27:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553250476; cv=none; d=google.com; s=arc-20160816; b=xDWzl1EU+bZ9WhFEkMwIq7Mhg+l8kK8FXcQqpfCVCvtPptuBqZqC0WOO277QfaYML9 rp1hGTGTMIzJYU8uAPYdIa+nKK/HoSArymXjJL2UEn2WiWLoMRQkZZmzCLkhj2qBmdX2 j/WzI+qvLDWILp9WZZX6t4fh8jRqqTTxIzkiUXAdloXxVT32JBITFyiCEGwag36iP9Gz PSIfPLeogC+o7FGc+owwJI/aEP08tHOdvH6dsmiFg1S9P/KpvreFH/yACQOAiprgzEoC O92wAi22zffYtshqtthtm+S61a+UZiCnyfspUmiB/mvw6D3wouOT2wRh2b7RW6oxAO4b WWsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UMN+05tRIxfAfIdwyVk3o4qkNnNcXcpJpEfIGA0qSLo=; b=JG+Ot6Ipsax5IAok6EVDX0oFxrZPNWMsbZe/xRESJSEwVcXyw0FK7pnGHt7ftc06Wk rOOxhlrdJNDg/n2z+ehyx39OiyIJIXn4nyF3sK5CsmcbU2aPYayilich/81fVZ/gkJOa heVGooEnL9Du1wu+PPGGTOzkLvzZNn9dcpf4feLz2l+ReH6Ehi/TU7/Uu87M/KxqxttN JEB+NiVzXxECnJ/npbijsqGvRzvmYo3rLQ040TGIeOmAmrycy0ldAzuS6UGgU/f36Zf3 UGafPOKYHR7Yd1bgI5vNlw6s+sklQBQQ8ntV3Ursk+1D8nyOh9+h/qxwro0ChWZf2Izn OOIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g35si6367883pgm.540.2019.03.22.03.27.41; Fri, 22 Mar 2019 03:27:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727957AbfCVK06 (ORCPT + 99 others); Fri, 22 Mar 2019 06:26:58 -0400 Received: from mga07.intel.com ([134.134.136.100]:1732 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727739AbfCVK06 (ORCPT ); Fri, 22 Mar 2019 06:26:58 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2019 03:26:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="154143378" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga002.fm.intel.com with SMTP; 22 Mar 2019 03:26:54 -0700 Received: by lahna (sSMTP sendmail emulation); Fri, 22 Mar 2019 12:26:53 +0200 Date: Fri, 22 Mar 2019 12:26:53 +0200 From: Mika Westerberg To: Aditya Pakki Cc: kjlu@umn.edu, Andreas Noever , Michael Jamet , Yehezkel Bernat , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] thunderbolt: Fix to check return value of ida_simple_get Message-ID: <20190322102653.GT3622@lahna.fi.intel.com> References: <20190320163409.30746-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190320163409.30746-1-pakki001@umn.edu> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 20, 2019 at 11:34:09AM -0500, Aditya Pakki wrote: > In enumerate_services, ida_simple_get on failure can return an error and > leaks memory. The patch ensures that the dev_set_name is set on non > failure cases, and releases memory during failure. > > Signed-off-by: Aditya Pakki Applied, thanks!