Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp579392img; Fri, 22 Mar 2019 04:27:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqyR9A3Dtsl2200qbtdWhxwTTbBz+yv6TFCKueGCgj1Kp2gsSlGLoBfiTYAv43y8ned7Uq1Q X-Received: by 2002:a62:e80f:: with SMTP id c15mr8582186pfi.93.1553254034315; Fri, 22 Mar 2019 04:27:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553254034; cv=none; d=google.com; s=arc-20160816; b=U3UjYegWJDnYJ91x8iiqeGBxw9cwk3CCfxzjJ/uaanhTAXdT/UsfYGutiwudGWDv0G t5yS1SBS56rl6eUw4lU3Ae4wQ+f7Zaj5nyzmXs5VlDyGgVB2AHeAwrRuE4z+s+S61gBz 6kykDw/fhgyYsiyRmKbMUVVrm0qzV1jNyR6Z16rEAReAGWyz3xk3Nks128UaIpeo2RNT 0qGUudXsW0o58uTUSmV7Z7S5xsshGpSB8YPBUZ+OtI8tgdpiugQoRhr3ooeVjafPsM4b ppCN8E0T2J8/92VFiVa0l9ex+p0zrpzHo37fAwmGz67FiFQkAmEoRxswkLTWirbiRpkV +jQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sCsq4Tiguaf3IYR31xCvrHETti67Z1z95rXze7sl72U=; b=cSzSpW3i7tTcH8sOkcHPVNVtVNa1VDkjmUlCQg38Rb5ttSz/ChGTcoaqEr3EZrYgEP C00oWQCxEvzv2yconA6dhbY89JktJVZyRkkoomVjDvbep5mifIWh0wrXBmdh//g9pdyO BMtq4loyX0EKPnGUrJiBOJvyBkhALrT+tI2Lm3yJGqob1zkRGL/iRKecHj6snh8fwu/j hRbuGUIg8phEaYcKTVjDDmXyeZiYdjw7tvFMfUX+VyTWDZZW6Dv8m55UfacaunsB6GJ3 9V+bzlUygQpQC12Unc90zgeOdEeisVax7zYm6CES/B8Nb5Vnw0anC7L4lffvfojE/9WE WmBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uNrIsxDG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d125si6637187pfd.206.2019.03.22.04.26.56; Fri, 22 Mar 2019 04:27:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uNrIsxDG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729233AbfCVLZG (ORCPT + 99 others); Fri, 22 Mar 2019 07:25:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:52316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728215AbfCVLZF (ORCPT ); Fri, 22 Mar 2019 07:25:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6158218B0; Fri, 22 Mar 2019 11:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253904; bh=5X55nuMh53QzAJlEgDgGNhlxjQCyU3H35uXJYbyAinw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uNrIsxDGPhoMkuE010Gd6swBSklfZAlYoNa1DQ/zZlfD0YLNYCQYTVh8w+nKyW6cv /wTU4UcbqNc50DbKY8tjjek1roGNyyqR2Vswh6Ro7vCl5ze0PQauBnnuqZn5Ewmdsh /z+LWzFEbTiGRHk7pYWjagqMlQQ+HwpIJQ+9UqKY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Darrick J. Wong" , Hugh Dickins , Matej Kupljen , Al Viro , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 3.18 107/134] tmpfs: fix link accounting when a tmpfile is linked in Date: Fri, 22 Mar 2019 12:15:20 +0100 Message-Id: <20190322111217.997579517@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111210.465931067@linuxfoundation.org> References: <20190322111210.465931067@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 1062af920c07f5b54cf5060fde3339da6df0cf6b ] tmpfs has a peculiarity of accounting hard links as if they were separate inodes: so that when the number of inodes is limited, as it is by default, a user cannot soak up an unlimited amount of unreclaimable dcache memory just by repeatedly linking a file. But when v3.11 added O_TMPFILE, and the ability to use linkat() on the fd, we missed accommodating this new case in tmpfs: "df -i" shows that an extra "inode" remains accounted after the file is unlinked and the fd closed and the actual inode evicted. If a user repeatedly links tmpfiles into a tmpfs, the limit will be hit (ENOSPC) even after they are deleted. Just skip the extra reservation from shmem_link() in this case: there's a sense in which this first link of a tmpfile is then cheaper than a hard link of another file, but the accounting works out, and there's still good limiting, so no need to do anything more complicated. Link: http://lkml.kernel.org/r/alpine.LSU.2.11.1902182134370.7035@eggly.anvils Fixes: f4e0c30c191 ("allow the temp files created by open() to be linked to") Signed-off-by: Darrick J. Wong Signed-off-by: Hugh Dickins Reported-by: Matej Kupljen Acked-by: Al Viro Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- mm/shmem.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 64c33e3dbe69..b40b13c94e03 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2286,10 +2286,14 @@ static int shmem_link(struct dentry *old_dentry, struct inode *dir, struct dentr * No ordinary (disk based) filesystem counts links as inodes; * but each new link needs a new dentry, pinning lowmem, and * tmpfs dentries cannot be pruned until they are unlinked. + * But if an O_TMPFILE file is linked into the tmpfs, the + * first link must skip that, to get the accounting right. */ - ret = shmem_reserve_inode(inode->i_sb); - if (ret) - goto out; + if (inode->i_nlink) { + ret = shmem_reserve_inode(inode->i_sb); + if (ret) + goto out; + } dir->i_size += BOGO_DIRENT_SIZE; inode->i_ctime = dir->i_ctime = dir->i_mtime = CURRENT_TIME; -- 2.19.1