Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp579407img; Fri, 22 Mar 2019 04:27:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqywY6QlawbOSF60bizrnJmv9aFOXyI1QQwX3EJpYvG8mc9IzFHp7SEo3yZD0LhuZUqZ/JFt X-Received: by 2002:a65:4549:: with SMTP id x9mr8622364pgr.3.1553254034871; Fri, 22 Mar 2019 04:27:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553254034; cv=none; d=google.com; s=arc-20160816; b=g0r7amNtyQTBwEAulCFlWfIjD0qbE8wwDhLN9T5lTJJPA+aaziMQrgXIQFs7/nUdqc zhjaxxpwW2vueuYuL5jxfDPDKd3sg6lN4ekQFRGnkv7nYAsHOX6Y5vMu+6iJPUw5fMfa dJ7p0rWf/yNYFHvfN+ms8gHBeSCGUG/IZoV89IZSYbj2Btg05Z3Wvey9F+aFllPk/wB9 Ej2C3teSqrSO5i/mKluFP4uWK/UUaPs5mpydjUYhMk2hoEnYdKhIYXv4EHMjAacnwHs8 kVl+4dWaNUFzAeIJOQEFFoHB/VmLTcbxGwuxMAlOZeHTPzdgEYH2BG57Tv1qSbTTxkrx +Hwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YzdKFFexjDu19kQPUPA4+Jp/ylqJc4NP8P6xgQXwngc=; b=R+i73MVeRGrNah0A2gokGiIz3u4oEytDE0yVUgZu0BCW4pPsoObZ1RusyNwLqLemz1 lmGt30MpO7eSmYcUQyOWjuqvmcVBhXToop3AIQeKcOExw4F5lwkp1naouTZS2jTzyVq4 kw6W8sHF8dHwrspmH3JaZMYqZA9eSohGfMGpraLjEN6iUGoINes8dERBr4qiZdx1+Nng 5mspKB1nSNkEjxI3+aC65eAGRyB174PM/PdSbna06bDdWRmpugTv1LXYF3junj3fGGfQ OFvbHSUa+oU6KLhJoplxUdlVwNazjB8ahd7HQb7a4E+c+fo5wxSHqdclwUkYjq9zX9xZ +bbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VsfcZQRe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y18si6293359pfe.72.2019.03.22.04.26.59; Fri, 22 Mar 2019 04:27:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VsfcZQRe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729101AbfCVLYT (ORCPT + 99 others); Fri, 22 Mar 2019 07:24:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:51378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729091AbfCVLYS (ORCPT ); Fri, 22 Mar 2019 07:24:18 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 341442190A; Fri, 22 Mar 2019 11:24:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253857; bh=pnBHd4x5gX3yWnr24gNiR3cV6grV2bx4EBgFrbjyim8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VsfcZQReW2Cwy6Ltmm7h1ThLt7WwlB/WzvQ7qzka+c/cu3FSd3lxr+Gh2kUqvYMR4 qvyKo/RwM+/iquTi3sZJ8uTqX8wiHuS/JSYY0m0qUX65EeL2yStCwPQKa/0wD+kU8H STQBvPb0AJQMx75pAhDOG1VeWtvcvcr7MmBy40JI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gustavo A. R. Silva" , Konrad Rzeszutek Wilk Subject: [PATCH 3.18 078/134] iscsi_ibft: Fix missing break in switch statement Date: Fri, 22 Mar 2019 12:14:51 +0100 Message-Id: <20190322111215.747552622@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111210.465931067@linuxfoundation.org> References: <20190322111210.465931067@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gustavo A. R. Silva commit df997abeebadaa4824271009e2d2b526a70a11cb upstream. Add missing break statement in order to prevent the code from falling through to case ISCSI_BOOT_TGT_NAME, which is unnecessary. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/iscsi_ibft.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -503,6 +503,7 @@ static umode_t __init ibft_check_tgt_for case ISCSI_BOOT_TGT_NIC_ASSOC: case ISCSI_BOOT_TGT_CHAP_TYPE: rc = S_IRUGO; + break; case ISCSI_BOOT_TGT_NAME: if (tgt->tgt_name_len) rc = S_IRUGO;