Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp579933img; Fri, 22 Mar 2019 04:27:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqxeM9dqFSk8T7nmuUPlZdT2wRVYZ3GTUSWmR/ngVlVBuGUzBeCo3PMMg8u4zJCfdmhgZdE2 X-Received: by 2002:a65:6148:: with SMTP id o8mr8483180pgv.442.1553254073678; Fri, 22 Mar 2019 04:27:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553254073; cv=none; d=google.com; s=arc-20160816; b=uIxfxz1Dg4DAEH+HiKgJd+G2qy2Ne4b+HndxFbssfImp0x9b+Gh+qQfFUlKIsGSJat 5qpFZP6R6jhFLr9FJgNMbelarTpk2hS/uePVn17x58zwd5vt+JfA8rgcL1k4YtBI0hEj LPwIynkinN24IB+qTOwwGF/INTRKQlxdbjeV88/vwVkiwIZ/e0L5ZKhCv042twHdvP6Q wcp0XNytq/oCPpcjZr0U63UpRSeiOQ/w/b0O2V8iS+o+DG1yOerP6VKbp9Uc3s7lo3b2 WFFkhZ+gD/Vn9bA0AC1aBU9TcR3Uv4/hUWVC1sJA6VPuDI/lhHares8D5kKYiNLiE+Vm tXUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7f5nqG8UApD4nQnbnp9+rS4xSWDtJwi0haC6akFlvgw=; b=iqFaDDWmOnmjKdWrmh6IloLeWOIfmEuljwAdaavTnBnhV1jeuIw6KuLTR6/sdTAfXt li8u15Jk1zE8k7DaKhk3czblNsuLGQfPVIegZtI/59OK7SaVwchkthaUj9ie3/uvaEk+ f7CRtFRLpqp3H9ZLp9I08iFXIc8L+e9yD8whw42pqKTm0Dmss8+t7YFGTfo+QSZXUeUj QVyJqIysHFx8vf+LgKoMZXgMf8LMnYpImLu7JJyNaPNK6YTMGn4zlqivQem0vRTJmxDU 94TmU2G8G7X/0e94ursg2li4C6pC5xro2dJCu6b0EcHfA/RAI8OdH8W9epTQ7WYSHrZU 3c2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="bd/BpDbY"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o1si6714127plk.7.2019.03.22.04.27.38; Fri, 22 Mar 2019 04:27:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="bd/BpDbY"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729391AbfCVL0K (ORCPT + 99 others); Fri, 22 Mar 2019 07:26:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:53874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728845AbfCVL0I (ORCPT ); Fri, 22 Mar 2019 07:26:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 894D120657; Fri, 22 Mar 2019 11:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253968; bh=ZWVxI3lBqJ/i9lN0ZIZ2JXPtXgDD3RIUeygEWIVLzuM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bd/BpDbY4O2QE1FU+lwIMvSAcyZpxyBr8YqnQs1YZhXfJpVncxj9slHKuMvkMTgSU yUVx06o3EywnCkcEd2J0DFOXD9MqieKQ4yyjDFn5wpCNqt1VXPVDDD1piUz8QnjYxi ozePMS7KC4SmbOgN+te5TRFs12G1e37VpyHx+0lc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jordan Niethe , Stewart Smith , Andrew Donnellan , Michael Ellerman Subject: [PATCH 3.18 126/134] powerpc/powernv: Make opal log only readable by root Date: Fri, 22 Mar 2019 12:15:39 +0100 Message-Id: <20190322111219.586727822@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111210.465931067@linuxfoundation.org> References: <20190322111210.465931067@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jordan Niethe commit 7b62f9bd2246b7d3d086e571397c14ba52645ef1 upstream. Currently the opal log is globally readable. It is kernel policy to limit the visibility of physical addresses / kernel pointers to root. Given this and the fact the opal log may contain this information it would be better to limit the readability to root. Fixes: bfc36894a48b ("powerpc/powernv: Add OPAL message log interface") Cc: stable@vger.kernel.org # v3.15+ Signed-off-by: Jordan Niethe Reviewed-by: Stewart Smith Reviewed-by: Andrew Donnellan Signed-off-by: Michael Ellerman Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/platforms/powernv/opal-msglog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/powerpc/platforms/powernv/opal-msglog.c +++ b/arch/powerpc/platforms/powernv/opal-msglog.c @@ -92,7 +92,7 @@ out: } static struct bin_attribute opal_msglog_attr = { - .attr = {.name = "msglog", .mode = 0444}, + .attr = {.name = "msglog", .mode = 0400}, .read = opal_msglog_read };