Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp591860img; Fri, 22 Mar 2019 04:43:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqwB+8pTkYjbmINOtVYgdvAm8OE3k8j2LKY5sofLayRux26UvG+XYsaDsxibdXaEzrsQRQSA X-Received: by 2002:a63:fc60:: with SMTP id r32mr8547818pgk.345.1553255030803; Fri, 22 Mar 2019 04:43:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553255030; cv=none; d=google.com; s=arc-20160816; b=JhzLSqZ4blrE8rJpb/0xzg5CD4rZJSR2RsxMu2yMSvp4V3Ilxk3lxfEzEwPl9/Sz7I kAG2/SrhS7NyWvFxrgTUqjwepMjpqcQgmuCPtXB8cWVb0Wrf+gw7niqLmwhboCKxfbAV Yepl4hcH/FxWcjc5xPqup9xbOjiIsjPT2FWMK0HpmJXaOa+HLfozBmVGJkr406NWLyFy dtBDuz2T5Z6xvQqWhAfRaht8u+w3EwcwhRSVUI9ycJKMsmjoAWmeRrQMSar76kBrZ7gK xgFOIOfBqJbbQxq5idI4jeAoqVBZJY7941qn3BlOkRr9dAi+Y2aap3is8TN7QqnqGRXh 1O0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IWwJ7Br2BuRXWkcAz5jApjn8eZCuFbz1lZNj0JPpwCk=; b=k/tDM0GtRoSsllAt/ylt7CfqqW3gDRx8goNw+uht9r+83+4bfyn41DWU/ossfBlA6g Oq+R3kxWeEUh/bZWOeObnVgSOPodikjCBmUf0aJUzFkgA+OQLypMlPODSYkQM3AE7Tik 4LwfcPBpV8GBrkCLhnelK12TgnhSfQR68KHnhAja7RQnxYMPpz4ksbz9zNuzC8+9h1bO xAgsU+6uciNQkM7QbmXyiKGyzWypmllV7N3L0+kIkjU2PZ0fR4Rqn8Ndl4hvxTDkYSDC 2OIZkctCTNoAPQHeCp7e8qb4c7FkXGVzNWlvOcvn/jyFRJY/x18Or0bLP+PgzFqfTBCh BGIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="D/SEAjVD"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x6si6349399pgr.372.2019.03.22.04.43.35; Fri, 22 Mar 2019 04:43:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="D/SEAjVD"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731605AbfCVLnA (ORCPT + 99 others); Fri, 22 Mar 2019 07:43:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:45552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731021AbfCVLm5 (ORCPT ); Fri, 22 Mar 2019 07:42:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8402A2082C; Fri, 22 Mar 2019 11:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553254977; bh=SIYhy/7sRsOGxgjxU5dq25oQM/O39KmLbNKt26DYIG0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D/SEAjVDzBe11m5VL9ehDdnDyjiIeXWVJi54C0ebIeRyNUDuDgJ/a7Yo4uQWcJ/ga eJQpW3mF0kwKF8eMrk2hdzCKdcBVIVcGe2qMZluWg9pkopdphLeo/iCg/Y42rL12jD 1ZNR0/ZNeCoZSDwaPDqBxmuY2bWxzJXzKYJHX9no= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lubomir Rintel , Steve deRosier , Kalle Valo Subject: [PATCH 4.9 069/118] libertas_tf: dont set URB_ZERO_PACKET on IN USB transfer Date: Fri, 22 Mar 2019 12:15:41 +0100 Message-Id: <20190322111221.520903034@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111215.873964544@linuxfoundation.org> References: <20190322111215.873964544@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lubomir Rintel commit 607076a904c435f2677fadaadd4af546279db68b upstream. It doesn't make sense and the USB core warns on each submit of such URB, easily flooding the message buffer with tracebacks. Analogous issue was fixed in regular libertas driver in commit 6528d8804780 ("libertas: don't set URB_ZERO_PACKET on IN USB transfer"). Cc: stable@vger.kernel.org Signed-off-by: Lubomir Rintel Reviewed-by: Steve deRosier Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/net/wireless/marvell/libertas_tf/if_usb.c +++ b/drivers/net/wireless/marvell/libertas_tf/if_usb.c @@ -433,8 +433,6 @@ static int __if_usb_submit_rx_urb(struct skb_tail_pointer(skb), MRVDRV_ETH_RX_PACKET_BUFFER_SIZE, callbackfn, cardp); - cardp->rx_urb->transfer_flags |= URB_ZERO_PACKET; - lbtf_deb_usb2(&cardp->udev->dev, "Pointer for rx_urb %p\n", cardp->rx_urb); ret = usb_submit_urb(cardp->rx_urb, GFP_ATOMIC);