Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190319064050.149212-1-kyletso@google.com> <20190319173802.GA31323@roeck-us.net>
 <CAGZ6i=0qeF1YU9N3pnKjejsKY76bY_sfqbwN83LWMRMr82k=nA@mail.gmail.com>
In-Reply-To: <CAGZ6i=0qeF1YU9N3pnKjejsKY76bY_sfqbwN83LWMRMr82k=nA@mail.gmail.com>
From:   Kyle Tso <kyletso@google.com>
Date:   Fri, 22 Mar 2019 19:54:06 +0800
Message-ID: <CAGZ6i=1ZyftH6CcMvpeWz9tLwJxusaOyz5BOaSS3YP2mijSQCw@mail.gmail.com>
Subject: Re: [PATCH] usb: typec: tcpm: collision avoidance
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Badhri Jagan Sridharan <badhri@google.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 22, 2019 at 12:51 AM Kyle Tso <kyletso@google.com> wrote:
>
> On Wed, Mar 20, 2019 at 1:38 AM Guenter Roeck <linux@roeck-us.net> wrote:
> >

> > >  static enum tcpm_state tcpm_default_state(struct tcpm_port *port)
> > >  {
> > >       if (port->port_type == TYPEC_PORT_DRP) {
> > > @@ -600,6 +664,9 @@ static void tcpm_debugfs_exit(const struct tcpm_port *port) { }
> > >
> > >  #endif
> > >
> > > +static int tcpm_ams_start(struct tcpm_port *port, enum tcpm_ams ams,
> > > +                       bool start);
> > > +
> >
> > Does this have to be a forward declaration ?
> >
> tcpm_pd_transmit() calls tcpm_ams_start() and tcpm_ams_start() calls
> tcpm_pd_transmit()
>
Since tcpm_ams_start will be divided into two parts, tcpm_pd_transmit no
longer needs to call tcpm_ams_start.

I will remove the forward declaration in the next version.

thanks,
Kyle