Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp612104img; Fri, 22 Mar 2019 05:08:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqz85vQcOHQ9/4cVhIM0+ityjho5yrk81ONIChpF2LBYyhidSHdBnoEun0GxMWkOpk2H+3t0 X-Received: by 2002:a63:4142:: with SMTP id o63mr8461350pga.81.1553256538776; Fri, 22 Mar 2019 05:08:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553256538; cv=none; d=google.com; s=arc-20160816; b=E/oCV05gAv87B7W7LhyNbbsgN+GWJBYDkjU+LL2zE9PwB6qpA8WfeyGjEYOqtnvPRH SNzqmsVmRvTH3cF7UOxBf8zADWxqul/tyDhkRJCS4Bb0vAAiv2kWQVLh5+1ax1paGbjF rMmAomFF+afWdMjNP3vYLzD+Rvl9ZIcEnOVJWg1kFFmL/h5dbOe6quSkah4R08wghoE2 lODeAUnw95MWqw1m93OJdvvyvX/uXU8RDSLjvCFdwSValcyZ8lypjHUeGa8FtuFOKR58 2BeGkC0bJeKNQ/26jAw0enK2zswGYo9q+yuMzKqDuT5jV/qNonqIqul+TNKHPmq5hw5J MLpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MFHrpSo6564EgaIXMTrdKE16XN7vk1co3ukYVSS/OOo=; b=DPJi8Qt9ulCo/6NEePSv3sd/qtPB/R+OIy5n4nhGE12RabKtZcIqOfuFzMzpaPTKUq WBzM/J6WC7moTE4CN9DYF2kk/qzB00+DZf1Qbs+7sC8xYt1zfs3aNLUvW4jXoE1MUolo uOaAUtjDm1w+8YXGHYrqTpdvvJP1cyoCjtPlD1SXBSWaYyJpmCRCg+ItULrAnz/3FmW3 xjP9kPGxDWhFNnqbTqrLgoDPqCVj0gw8BwYruYMl8WKNKg5E0FtLr5syC2ACi5yvOtsR ZgEcb+4fp2zGz/zOA6IqnMDDaGQUDPjImrcRqKukAIk1iLJeieSFcTMGQXUSxu+RpOep 7u0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MDwmuMhy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p6si6403632pga.151.2019.03.22.05.08.41; Fri, 22 Mar 2019 05:08:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MDwmuMhy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388867AbfCVMHs (ORCPT + 99 others); Fri, 22 Mar 2019 08:07:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:46086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389063AbfCVMHn (ORCPT ); Fri, 22 Mar 2019 08:07:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBD7E206C0; Fri, 22 Mar 2019 12:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256462; bh=I5DfUpWc4FkhWApzv8awRJ97Wee7r7iwYLBrP50ov9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MDwmuMhyHEAgiZMBWy6JZq0yrnlc4SVb3Bkm2C73Zad9qIXr/Ar7fDIo+cEZ0hPOm KDXlea2FeRU89X7Pkd8LyGBjgFpVSgbhhjgbinDvoVA15PzrKqy4bK6BKDGmqMg7j+ 3hJlbzjRczct75AamxYxTrexxPf5wrp6XoZxCJEU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tvrtko Ursulin , Guenter Roeck , Adam Zabrocki , Joonas Lahtinen , Akash Goel , Chris Wilson , Jani Nikula , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, Sasha Levin Subject: [PATCH 4.19 211/280] drm/i915: Relax mmap VMA check Date: Fri, 22 Mar 2019 12:16:04 +0100 Message-Id: <20190322111332.825969209@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111306.356185024@linuxfoundation.org> References: <20190322111306.356185024@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit ca22f32a6296cbfa29de56328c8505560a18cfa8 ] Legacy behaviour was to allow non-page-aligned mmap requests, as does the linux mmap(2) implementation by virtue of automatically rounding up for the caller. To avoid breaking legacy userspace relax the newly introduced fix. Signed-off-by: Tvrtko Ursulin Fixes: 5c4604e757ba ("drm/i915: Prevent a race during I915_GEM_MMAP ioctl with WC set") Reported-by: Guenter Roeck Cc: Adam Zabrocki Cc: Joonas Lahtinen Cc: # v4.0+ Cc: Akash Goel Cc: Chris Wilson Cc: Jani Nikula Cc: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org Reviewed-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20190305110409.28633-1-tvrtko.ursulin@linux.intel.com (cherry picked from commit a90e1948efb648f567444f87f3c19b2a0787affd) Signed-off-by: Rodrigo Vivi Signed-off-by: Sasha Levin --- drivers/gpu/drm/i915/i915_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 280c851714e6..03cda197fb6b 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1828,7 +1828,8 @@ __vma_matches(struct vm_area_struct *vma, struct file *filp, if (vma->vm_file != filp) return false; - return vma->vm_start == addr && (vma->vm_end - vma->vm_start) == size; + return vma->vm_start == addr && + (vma->vm_end - vma->vm_start) == PAGE_ALIGN(size); } /** -- 2.19.1