Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Mar 2019 13:18:42 +0100
From:   Petr Vorel <pvorel@suse.cz>
To:     djacobs7@binghamton.edu
Cc:     linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        zohar@linux.ibm.com, vt@altlinux.org
Subject: Re: [PATCH v2 1/8] evmtest: Regression testing integrity subsystem
Message-ID: <20190322121842.GA32091@dell5510>
Reply-To: Petr Vorel <pvorel@suse.cz>
References: <20190322083441.31084-1-djacobs7@binghamton.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190322083441.31084-1-djacobs7@binghamton.edu>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi David,

> $ evmtest runtest example_test -e /bin/bash
> [*] Starting test: example_test
> [*] TEST: PASSED

> Example 1a: successful verbose example test output
> $ evmtest runtest example_test -e /bin/bash -v
...

> Changelog:
...
> * checkbashishms compliant
Not yet :). I noticed using
source (should be .)
== (should be =)
${BASH_SOURCE[0]} (should be $0)
$UID (should be $(id -u)
bash redirection &>> (should be >/dev/null 2>&1)
+= (should be VAR="${VAR}foo")
and bash shebang.

Could you please fix that?

...
> +++ b/evmtest/evmtest
> @@ -0,0 +1,67 @@
> +#!/bin/bash

Can we, please, use /bin/sh and not-expect bash?
Portability matters.

> +source "$EVMDIR"/files/common.sh
> +usage (){
> +	echo "Usage:"
> +	echo "	evmtest runtest <test name> [OPTIONS]"
> +	echo ""
Can be just echo. Maybe using cat might be better than many echos:

cat <<EOF
Usage:
\tevmtest runtest <test name> [OPTIONS]
...
EOF


Kind regards,
Petr