Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp624698img; Fri, 22 Mar 2019 05:23:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqxQMlLE+9NGXzvziNHmujLqbH/8m5WfOJ2hCSPySRaC5zIpj1WqB86P0Uzk6RdAl/fUb9Pj X-Received: by 2002:a62:b502:: with SMTP id y2mr8823279pfe.212.1553257427591; Fri, 22 Mar 2019 05:23:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553257427; cv=none; d=google.com; s=arc-20160816; b=07j4PN9vFQ/rHLkKQrTYPz3GUPj8++9jFnTpTYaXpYX9J9eCheeKE94P963I4KAZec 9CRHPV5klYh3KAJ0LJ+2LnHQpMsbxhgueWg7XWygagQMr/o2YXHgtW/Z8pBDM+ex4LBt QPTXGwu/viJcAuXFb5ekZJLzhlugHMzDaadqwfb6M0dertburv836Eh6/T5tyH8q4fEl ZuXp++umWbn07IMPKLE6RTeF9IoeeiOJW/WJRgvejvWiz3Hps/8PaleDgKSIHv9Q9Lvn UkT9SIECLzVBA8uGDkb4bRspw3pXRPk+NlDbhse8h+yQt8gafLlriGMwuYtoUGCMQ2R3 YzPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hLhGDV9sJ5fMrDWFQYgS5VDfpLI91XMBaRutKc2OuF8=; b=zEFSFU+7+9mZsLlPZetpR3DqAaMaAvri5MInkI7HpOxTFS1VGyad/jqn31p59jNu+n 78UNsEr/gZYIJ8PMlFmZJtNXCJhmb2qZ/sIPwDmxqFjl3VWDwE172digzFb158/V+Jyg Z4MZCxxMdwIpT0xLihb5hBbZmLvVGdGLLFZ8ZY9Gtu0SuNoujwG4X1VrLT0Yg0Gs/yT3 ftQfCz9tKCRcrGsCX+jxhWghklCJlh76smrkImVcegT96CCUHgOuS/gOesK+sH3rRDLZ +Cyw93+kFun1pXgT5j3WYYn5W3NJba5KRL74SZynQlqkJU+RY9TUdKb4gMUachw3ebfo 3qfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BLtQ1202; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 59si7222666plb.405.2019.03.22.05.23.32; Fri, 22 Mar 2019 05:23:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BLtQ1202; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391063AbfCVMWt (ORCPT + 99 others); Fri, 22 Mar 2019 08:22:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:34022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391055AbfCVMWq (ORCPT ); Fri, 22 Mar 2019 08:22:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4ADD621900; Fri, 22 Mar 2019 12:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553257365; bh=xZLqDWKZJR2ON60ZpOr+Z8VHxNFoZJKyNJWqjuXx1DY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BLtQ1202GXac9/zp0/6g5RpGvZ38YHCVrXZjkHej+hpBG4jxvHO7YMzzdEmm+mRIE IhbDH0Gr1ryhbKCo0jckTT1QHrIpPR4pU7Wr01xJVGZlGCQh+duo1Al9ZCwR1ECRAF btAsG2LPIMYJZdNtyxhCLus3RSOhQ6hskweNh+oI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Niklas Cassel , Jorge Ramirez-Ortiz , Viresh Kumar , "Rafael J. Wysocki" Subject: [PATCH 5.0 193/238] PM / OPP: Update performance state when freq == old_freq Date: Fri, 22 Mar 2019 12:16:52 +0100 Message-Id: <20190322111309.590147242@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111258.383569278@linuxfoundation.org> References: <20190322111258.383569278@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Viresh Kumar commit faef080f6db5320011862f7baf1aa66d0851559f upstream. At boot up, CPUFreq core performs a sanity check to see if the system is running at a frequency defined in the frequency table of the CPU. If so, we try to find a valid frequency (lowest frequency greater than the currently programmed frequency) from the table and set it. When the call reaches dev_pm_opp_set_rate(), it calls _find_freq_ceil(opp_table, &old_freq) to find the previously configured OPP and this call also updates the old_freq. This eventually sets the old_freq == freq (new target requested by cpufreq core) and we skip updating the performance state in this case. Fix this by also updating the performance state when the old_freq == freq. Fixes: ca1b5d77b1c6 ("OPP: Configure all required OPPs") Cc: v5.0 # v5.0 Reported-by: Niklas Cassel Tested-by: Jorge Ramirez-Ortiz Signed-off-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/opp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -743,7 +743,7 @@ int dev_pm_opp_set_rate(struct device *d old_freq, freq); /* Scaling up? Configure required OPPs before frequency */ - if (freq > old_freq) { + if (freq >= old_freq) { ret = _set_required_opps(dev, opp_table, opp); if (ret) goto put_opp;