Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263148AbUCYEd0 (ORCPT ); Wed, 24 Mar 2004 23:33:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263149AbUCYEd0 (ORCPT ); Wed, 24 Mar 2004 23:33:26 -0500 Received: from ozlabs.org ([203.10.76.45]:46551 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S263148AbUCYEdZ (ORCPT ); Wed, 24 Mar 2004 23:33:25 -0500 Subject: Re: [PATCH] Hotplug CPU toy for i386 From: Rusty Russell To: Zwane Mwaikambo Cc: Nick Piggin , Andrew Morton , lkml - Kernel Mailing List , LHCS list In-Reply-To: References: <405C1F42.9030901@cyberone.com.au> <1079937266.5759.42.camel@bach> Content-Type: text/plain Message-Id: <1080189202.25555.26.camel@bach> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Thu, 25 Mar 2004 15:33:22 +1100 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1047 Lines: 30 On Mon, 2004-03-22 at 20:56, Zwane Mwaikambo wrote: > On Mon, 22 Mar 2004, Rusty Russell wrote: > > > @@ -1035,6 +1036,10 @@ inline void smp_local_timer_interrupt(st > > { > > int cpu = smp_processor_id(); > > > > + /* FIXME: Actually remove timer interrupt in __cpu_disable() --RR */ > > + if (cpu_is_offline(cpu)) > > + return; > > + > > We could setup an offline cpu idt with nop type interrupt stubs, this > could also take care of the irq_stabilizing problem later on... The problem I have with this approach is that it shouldn't be neccessary. Perhaps I'm overly optimistic. I know *nothing* about i386: I'll play with stealing the PM code's APIC suspend/resume, which I think is the Right Way to do this. Rusty. -- Anyone who quotes me in their signature is an idiot -- Rusty Russell - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/