Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp635840img; Fri, 22 Mar 2019 05:37:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqx574DRN9glVnjVgcgAptMqK9S9GJaxppl7lD06kOM+1vbpiF0GF7K6WQfve1v94611Mw9D X-Received: by 2002:aa7:8019:: with SMTP id j25mr9064703pfi.77.1553258253361; Fri, 22 Mar 2019 05:37:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553258253; cv=none; d=google.com; s=arc-20160816; b=bLSOSjgo6Of0J3HP25EenlLIMnSThJ9Dh5aCUmwbAt+p1TtbfPr+zHqj1dBtwMiKzQ AVcV6MrYxDI1hBGmtuOCkveyQzjXrQydwewxEHmxvYs0a2Xm0B1X6Lvv4gK9O395x97A k+SrRXfsqDm+JaXZBV5QnUO228QvUOXpApmM0zXn1nVFTMZ+ZIsIdnPKIK4X6Y5KKeYR J1afWkW4hcr2TLMg8fImNkZ0wNUYxuIvKJz0jf2BC7pAQgu3snRwrQsrz7tlQp5fxkPN UQCTwfPB7xm6EV8KZCODkbbVXsaIh+eR7akFhFoE9RtP6EJNsm46Iro0jnwNhLj+gp3N 55Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TeKcAm2gVI54sbiJdTe+l/n9Y3WToDWFrHY7KQzsLuA=; b=g4bPqDkZtmj/gQk0NXRFv07xej74KRap4o6JYMd0UZ70jM6F8TG3CMCSu9bNEgdiJ2 Emc9vNOO+lO+Cg0R6YZUQlaE+mYoxCQAuJwR3ZPbaPDLYSp0Du+2E2VaxJAgKFgxTycR i2nsoO18bI7Q80OiGEJKAea4cZCIRe1EKkY5IEmqvN1syL2mv2TrgZDpSHSkdc6XTxbE iKYcNPHNtIeghNVSje5aWx0veN5sLAePDPkPO2tG3N4RMSZL7LePgqonsGTe3W+XLJaW Ed2VKhrEpr7T6SdDqcXQBFtY1frQWIwwWNW8xKSEn8Dj7Ctq087S1qLqXha78sp3nsuH TQdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x5mmowx2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r15si6256616pgv.389.2019.03.22.05.37.18; Fri, 22 Mar 2019 05:37:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x5mmowx2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389573AbfCVMf0 (ORCPT + 99 others); Fri, 22 Mar 2019 08:35:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:50586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388887AbfCVMMX (ORCPT ); Fri, 22 Mar 2019 08:12:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D8812082C; Fri, 22 Mar 2019 12:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256743; bh=GEzVkmtQcm34vN5nXXEpUAE8jZFGhIhzKkeXmb8d8w4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x5mmowx2gjkDLpmFJwKJESfC2i2vB9/AX90J1z1Hxq/zOFHm4a2/5j+K58oNIzMex fPEfFHJTcF/tq1lb18h7xWUBIYQE+oNFXacXQ88eBPk1ob8lvsF2yyr5gvDD0ScDPF DnNndkRXctdYEF5DfUQFjY1037F67zJCTiYjNmnI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.0 007/238] iio: adc: exynos-adc: Use proper number of channels for Exynos4x12 Date: Fri, 22 Mar 2019 12:13:46 +0100 Message-Id: <20190322111258.728510789@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111258.383569278@linuxfoundation.org> References: <20190322111258.383569278@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Krzysztof Kozlowski commit 103cda6a3b8d2c10d5f8cd7abad118e9db8f4776 upstream. Exynos4212 and Exynos4412 have only four ADC channels so using "samsung,exynos-adc-v1" compatible (for eight channels ADCv1) on them is wrong. Add a new compatible for Exynos4x12. Signed-off-by: Krzysztof Kozlowski Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt | 4 +- drivers/iio/adc/exynos_adc.c | 17 ++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt @@ -11,11 +11,13 @@ New driver handles the following Required properties: - compatible: Must be "samsung,exynos-adc-v1" - for exynos4412/5250 controllers. + for Exynos5250 controllers. Must be "samsung,exynos-adc-v2" for future controllers. Must be "samsung,exynos3250-adc" for controllers compatible with ADC of Exynos3250. + Must be "samsung,exynos4212-adc" for + controllers compatible with ADC of Exynos4212 and Exynos4412. Must be "samsung,exynos7-adc" for the ADC in Exynos7 and compatibles Must be "samsung,s3c2410-adc" for --- a/drivers/iio/adc/exynos_adc.c +++ b/drivers/iio/adc/exynos_adc.c @@ -115,6 +115,7 @@ #define MAX_ADC_V2_CHANNELS 10 #define MAX_ADC_V1_CHANNELS 8 #define MAX_EXYNOS3250_ADC_CHANNELS 2 +#define MAX_EXYNOS4212_ADC_CHANNELS 4 #define MAX_S5PV210_ADC_CHANNELS 10 /* Bit definitions common for ADC_V1 and ADC_V2 */ @@ -271,6 +272,19 @@ static void exynos_adc_v1_start_conv(str writel(con1 | ADC_CON_EN_START, ADC_V1_CON(info->regs)); } +/* Exynos4212 and 4412 is like ADCv1 but with four channels only */ +static const struct exynos_adc_data exynos4212_adc_data = { + .num_channels = MAX_EXYNOS4212_ADC_CHANNELS, + .mask = ADC_DATX_MASK, /* 12 bit ADC resolution */ + .needs_adc_phy = true, + .phy_offset = EXYNOS_ADCV1_PHY_OFFSET, + + .init_hw = exynos_adc_v1_init_hw, + .exit_hw = exynos_adc_v1_exit_hw, + .clear_irq = exynos_adc_v1_clear_irq, + .start_conv = exynos_adc_v1_start_conv, +}; + static const struct exynos_adc_data exynos_adc_v1_data = { .num_channels = MAX_ADC_V1_CHANNELS, .mask = ADC_DATX_MASK, /* 12 bit ADC resolution */ @@ -493,6 +507,9 @@ static const struct of_device_id exynos_ .compatible = "samsung,s5pv210-adc", .data = &exynos_adc_s5pv210_data, }, { + .compatible = "samsung,exynos4212-adc", + .data = &exynos4212_adc_data, + }, { .compatible = "samsung,exynos-adc-v1", .data = &exynos_adc_v1_data, }, {