Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp654467img; Fri, 22 Mar 2019 06:01:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqzB8LKWwnUZzmD5e1/uY95jMZp4JXIhWoqqSvOfkMldtMCBq/ZoejVh6di5IPuPO+hTwOlw X-Received: by 2002:a65:6085:: with SMTP id t5mr8959364pgu.257.1553259709132; Fri, 22 Mar 2019 06:01:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553259709; cv=none; d=google.com; s=arc-20160816; b=xViu5OKRvi5KWrpsmTq4e3ge0HsLfaczZZTyS9xXc7Bdb88ueVO8A4QOG6K1UxPFBy pjq2+JqvGeAehOzAAHKoM3X8sJHkQGnkIDTHkmZk/fJNgSOllFy2r/J3aMXdR5iDcjjd 8GlXljAJH1Hmm53miU9LiYHNcyaylYNHsatf61rwtGSUtCIkyiH/pqUAU1tMMcls/TW4 Bi06kaCS1dtRBkAbA5KIqFPOfVRD4XS8Ja6pDXMamj3YkRkddDG1KPKt/z1byGlKB18U tMEy8xE3rVxh9OvZH/squM/GMLmJcwqznhN0iKep/NxVM+vFHsAuCrX9luS//mT8XiDh gAWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=K2PEjgUDZoknvXnHLbWldm2Ia9IGHUB2Ov1UyIA/k6s=; b=JlENbQAaE43czmmtwQxYdUzAmGZi0tC0o1/JEMfxQApoYsKdiwmrgFTVWd4KcXamcS DBlF6noLBOLrBRR66S+Pyu/JkUHJ4XNGgo9NSmrqc4P7Mn4Y+0famvW03So/aiwcwwzo EkYq6JgHQTLhP0ROdYjYx69sy3G2cLEexGR/uYtgwjmR0VhLq+SS62kYUe1/QPku86hm yZpfP43Rz2Y3BIQReLffcobbq5FTT8Jbo5fJmHHAI+qnuHO6glyYWJnIBYoQIzRNUQMj efmjzeD5uKU1BQi/YWqfnHsIVN0j/TVieUAa8U1ounXZGHUp1xo7vX1pl0RG3fT02DjW vxCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q+ckEvv4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5si917070pgr.121.2019.03.22.06.01.33; Fri, 22 Mar 2019 06:01:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q+ckEvv4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732081AbfCVM7o (ORCPT + 99 others); Fri, 22 Mar 2019 08:59:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:48028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731874AbfCVLo7 (ORCPT ); Fri, 22 Mar 2019 07:44:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B9FA121971; Fri, 22 Mar 2019 11:44:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553255099; bh=ros8T3V3LXPUlHmN1SzqGOXxm0gbcwDCW6RiZ41HhS8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q+ckEvv4sDf+R3SGgr+EKejDBvB0z4Vl+e7NF5XP/ayopFZBfHt1wcYAMfYTKQHgQ cT32iWGDVXJoAAzBrq9lwYU/rzYukbGAMX5ziIeqEoxKXVcw/6FKi/ioXwWNCj33K0 UDZD8D4wTy58pA1gWg56pnf3aHDEigr78jwbdZgA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lubomir Rintel Subject: [PATCH 4.9 087/118] serial: 8250_of: assume reg-shift of 2 for mrvl,mmp-uart Date: Fri, 22 Mar 2019 12:15:59 +0100 Message-Id: <20190322111222.790372811@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111215.873964544@linuxfoundation.org> References: <20190322111215.873964544@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lubomir Rintel commit f4817843e39ce78aace0195a57d4e8500a65a898 upstream. There are two other drivers that bind to mrvl,mmp-uart and both of them assume register shift of 2 bits. There are device trees that lack the property and rely on that assumption. If this driver wins the race to bind to those devices, it should behave the same as the older deprecated driver. Signed-off-by: Lubomir Rintel Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/8250/8250_of.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/tty/serial/8250/8250_of.c +++ b/drivers/tty/serial/8250/8250_of.c @@ -97,6 +97,10 @@ static int of_platform_serial_setup(stru if (of_property_read_u32(np, "reg-offset", &prop) == 0) port->mapbase += prop; + /* Compatibility with the deprecated pxa driver and 8250_pxa drivers. */ + if (of_device_is_compatible(np, "mrvl,mmp-uart")) + port->regshift = 2; + /* Check for registers offset within the devices address range */ if (of_property_read_u32(np, "reg-shift", &prop) == 0) port->regshift = prop;