Message-ID: <406310CB.4010404@pobox.com>
Date: Thu, 25 Mar 2004 12:03:07 -0500
From: Jeff Garzik <jgarzik@pobox.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
MIME-Version: 1.0
To: Sergey Vlasov <vsu@altlinux.ru>
CC: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: sata_via: ata1 failed to respond
References: <20040325164441.GP1756@master.mivlgu.local>
In-Reply-To: <20040325164441.GP1756@master.mivlgu.local>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2224
Lines: 59

Sergey Vlasov wrote:
> Hello!
> 
> I have another report about nonworking sata_via in 2.4.25-libata9
> plus the probing bug fix (so sata_via was identical to the version
> in 2.4.25-libata12).  The drive was not recognised with these
> messages:
> 
> libata version 1.02 loaded.
> sata_via version 0.20
> sata_via(00:0f.0): routed to hard irq line 10
> ata1: SATA max UDMA/133 cmd 0xB800 ctl 0xB402 bmdma 0xA400 irq 20
> ata2: SATA max UDMA/133 cmd 0xB000 ctl 0xA802 bmdma 0xA408 irq 20
> ata1 is slow to respond, please be patient
> ata1 failed to respond (30 secs)
> 
> The hardware was: ASUS A7V600 motherboard, Seagate ST3120026AS hard
> drive.  2.4.25-libata1 worked fine.
> 
> acpi=off and noapic options did not help.  However, replacing
> sata_via.c with the version from 2.4.25-libata1 (with removed
> ".phy_config = pata_phy_config" line to make it compile) allowed the
> detection to succeed.
> 
> I tried to replace ATA_FLAG_SATA_RESET with ATA_FLAG_SRST in the new
> driver - with this change detection also succeeds:
> 
> --- kernel-source-2.4.25/drivers/scsi/sata_via.c.via-srst	2004-03-24 16:27:50 +0300
> +++ kernel-source-2.4.25/drivers/scsi/sata_via.c	2004-03-25 18:51:19 +0300
> @@ -203,7 +203,7 @@ static int svia_init_one (struct pci_dev
>  	INIT_LIST_HEAD(&probe_ent->node);
>  	probe_ent->pdev = pdev;
>  	probe_ent->sht = &svia_sht;
> -	probe_ent->host_flags = ATA_FLAG_SATA | ATA_FLAG_SATA_RESET |
> +	probe_ent->host_flags = ATA_FLAG_SATA | ATA_FLAG_SRST |
>  				ATA_FLAG_NO_LEGACY;
>  	probe_ent->port_ops = &svia_sata_ops;
>  	probe_ent->n_ports = 2;
> 
> Here is the full dmesg output from boot with the above change:


Man, you are full of useful bug reports ;-)

Thanks much for testing.  It looks like there are still some bugs in my 
SATA reset routine, since it was hoped that that code works universally.

I'll try to come up with an alternate patch that fixes sata_phy_reset(). 
  If I fail, we will use your patch as the fallback.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/