Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp845480img;
        Fri, 22 Mar 2019 09:45:30 -0700 (PDT)
X-Google-Smtp-Source: APXvYqztKKUeJLubga4RABzvyTXcPMaKR1JU3RhH0r1XfnpETWNItMFpGLFRNT1fpTyru32AOlOX
X-Received: by 2002:a63:d706:: with SMTP id d6mr9370201pgg.367.1553273130520;
        Fri, 22 Mar 2019 09:45:30 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1553273130; cv=none;
        d=google.com; s=arc-20160816;
        b=yTvbiozfAH+KPxP4xYScILKVQ6dzt5TL7TiYtifitnSD7aUCw3kaogI1xUBitPyCMj
         T3HpQwsR7VQQacDxGsVnPAIlIFiKFEComE0lEUII44qsPvhhi4Rf00I48couwxEa0L+G
         OOxKs2ZqxXSPtsvbfMYTlycOcmBTkIFcf3H78ZLWDsdVBAxU8G1WF5N8C15K/UQ/N4z/
         sgvAoxIwLmkRETLMZHNMvLn7lYrM84jB06TGT7luwvkjE4hnyZs8EXj8KmGAYUF1xLN9
         UAqbgUsE48zRkwmSgeTV5ytmM49rHapeKPVM//ob9lw/07Of+Hx2+sm2Zanvx3cYJeWM
         6Wrw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=ZmQpzNFcqBpAXeW0vjr7E+LBfluLIyrtjVPh6+Uat+c=;
        b=nuZkiJ1VHTOLw+Nh+ppnkZbWKCkgwabBE6RU+eVH89GBPvZe91+mD1swrOGR8cEQ7P
         znkiDs0KYQCTudK3yj8XaQCGBB1BNelaUqHpDnEzRsM/cKyRnTB7jxshQmrixzGwi6KX
         7heamnNrip7ggsUMut0Y/C7pwx6n6/3disIe0wnFxPcl+CX3NvnLzeGeZ4Ovact7mDCh
         h6BXZjLt51LNzBl6E7caJuub+aEZT6AlsqDKos/JfNU9YklO8/+mliG8wz6rNThtr2li
         mSEpxCo1er8EbgVhYUPQ0w9CNrpJgJqgpHwGzatDaP65OtzZXvWyhcxIUuyIJUZzwD1h
         Zfkw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b="p2Qz0s5/";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id f124si7139196pfb.38.2019.03.22.09.45.15;
        Fri, 22 Mar 2019 09:45:30 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b="p2Qz0s5/";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727694AbfCVQoj (ORCPT <rfc822;ahaning.tech@gmail.com>
        + 99 others); Fri, 22 Mar 2019 12:44:39 -0400
Received: from mail.skyhub.de ([5.9.137.197]:59364 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726667AbfCVQoj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Mar 2019 12:44:39 -0400
Received: from zn.tnic (p200300EC2F098000329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:8000:329c:23ff:fea6:a903])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EDC501EC09F1;
        Fri, 22 Mar 2019 17:44:37 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
        t=1553273078;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:in-reply-to:in-reply-to:  references:references;
        bh=ZmQpzNFcqBpAXeW0vjr7E+LBfluLIyrtjVPh6+Uat+c=;
        b=p2Qz0s5/fcBA5gMX4R7bUkoeQLYr4unZGDCoj/qTfNPRmd51e9Bl3g0kInIdvJTDh2eFmb
        J17Vs9BCBrcRodiRiplPJ+vy8NKQSD6zhpvDmxajKetnTsj2VZyqA52LzLZfmLgKwO+jzo
        xdo7kRkgOrqx08P9cnq60721gv9pCyM=
Date:   Fri, 22 Mar 2019 17:44:45 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Pu Wen <puwen@hygon.cn>
Cc:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "hpa@zytor.com" <hpa@zytor.com>, "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86/cpu/hygon: Fix phys_proc_id calculation logic
 for multi-die processor
Message-ID: <20190322164445.GG12472@zn.tnic>
References: <1553251380-7015-1-git-send-email-puwen@hygon.cn>
 <20190322155449.GE12472@zn.tnic>
 <639a5bc6-f821-ee9d-1594-d02701321192@hygon.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <639a5bc6-f821-ee9d-1594-d02701321192@hygon.cn>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 23, 2019 at 12:19:01AM +0800, Pu Wen wrote:
> That 6 is not a magic number.

Well, if I see a naked 6, then it is only magic to me. Now if it were a
proper define with a descriptive name...

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.