Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp851114img; Fri, 22 Mar 2019 09:53:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqwyv6SEjR3RS+pStUfhvS+FSGqXzCUxKRVhwWjxPVjpHPCnemJ3OZMySiGuhwSrDRvCkMZk X-Received: by 2002:a63:6841:: with SMTP id d62mr9963655pgc.133.1553273629928; Fri, 22 Mar 2019 09:53:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553273629; cv=none; d=google.com; s=arc-20160816; b=xDjbiPhvO4w6Lq+2dWPzWwDEqv/Eo9Mbb/4SbrgfR2G05RwhEsuTtJpAI423f2cUjT wm3za904Z8y/i2hQqpy0X6O59uUkCjeCOzmRLF8AszCJxaVNjnx+rHFAGwM9sNah0Ntx tZIO2blb9uty1Cpf2MXRIj6vYg8HQFauhqvm7HtFVr858HVA1tbRyheMj4OI/uKPL7DN ltbRfWsKOYtCJB/Sddud2c5B4u509KabWtOmPNJz5UQGcepk1jgUCQmO5n/8GvJH1Yut j45umfk+3rRdOxEnYMsxrM/HoOlSRc7dEQ5PE6rZ/CKGXjnKzGRfTNy32XuflO1WGCrj aa6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=43yWoHNsIC8YPsKPjdrRLXkYbp5BCR3I+6h2VPg3G2Q=; b=PtInNepC+dkaRcFt3siD+QZNAGJa/S1tnoHwEUD9NDJRia/D0fUgWKWf9Ouge5Dpvg PQ5SuiDDvP3z6Km4eOdqvcA73ZDcYOsyKuf+2Tjd/Sw6Hpbddi7qb9IB55DcqcNEskzx 5BO9KTdlmFPx18g4bXCO1okQ2KRaQIdTUmHJjYMvzluHCPjrOaEFKzpZts3Sgb2WReU7 vrp81JHSu02QAIKVb4aByuBik/fGIhbJ4OZlzuj0EmR2xacA1nRcH+bGHYrjKNGjDYEE QKGhq42bEm0rtRDbmXVKzqd1ACWu2NtUZ9BiBsrCQHG8MMPct4Ba4n46dgPBq3yyFrfF dk1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=SoIIWRKq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cf17si7852626plb.101.2019.03.22.09.53.35; Fri, 22 Mar 2019 09:53:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=SoIIWRKq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728172AbfCVQw1 (ORCPT + 99 others); Fri, 22 Mar 2019 12:52:27 -0400 Received: from merlin.infradead.org ([205.233.59.134]:51050 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727443AbfCVQw1 (ORCPT ); Fri, 22 Mar 2019 12:52:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=43yWoHNsIC8YPsKPjdrRLXkYbp5BCR3I+6h2VPg3G2Q=; b=SoIIWRKqYcgcAypFylzNqem/l xYfEClSFsoXMgl/znXpzKM57JoUolr1nk1HfWtKPAIM3vf0GI01kzFmXEa5CQ4wCmVmNKUkxtZ6GT l3fIEqpU3AiKeZbhN14cnLqb/iMdvcTN+fg5drySVfie72W5767xQIVrp/ESwBblfgVPaNkurQRCE t3ZaYeT4Zkzz2SGa1mKuelVC4GvvZcYfhz8uhxVMnkzd2hlpzhcRjC+Cfk/l3rz2CkQr28B3M2lca uCF3viMTK56agTLE88pnUuA+hvbWcauM4Cchpwgy0zAmQ4Zncuoni4mdVTl91rLpCaykTQ0i67tKF n9BQOTceA==; Received: from [31.161.229.66] (helo=worktop.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7NOz-0003VU-Pq; Fri, 22 Mar 2019 16:52:18 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id CE103980317; Fri, 22 Mar 2019 17:52:14 +0100 (CET) Date: Fri, 22 Mar 2019 17:52:14 +0100 From: Peter Zijlstra To: Borislav Petkov Cc: Pu Wen , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH] x86/cpu/hygon: Fix phys_proc_id calculation logic for multi-die processor Message-ID: <20190322165214.GI7905@worktop.programming.kicks-ass.net> References: <1553251380-7015-1-git-send-email-puwen@hygon.cn> <20190322155449.GE12472@zn.tnic> <639a5bc6-f821-ee9d-1594-d02701321192@hygon.cn> <20190322164445.GG12472@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190322164445.GG12472@zn.tnic> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 22, 2019 at 05:44:45PM +0100, Borislav Petkov wrote: > On Sat, Mar 23, 2019 at 12:19:01AM +0800, Pu Wen wrote: > > That 6 is not a magic number. > > Well, if I see a naked 6, then it is only magic to me. Now if it were a > proper define with a descriptive name... Does AMD/Hygon not have a CPUID leaf to read useful things like this from?