Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Mar 2019 14:15:50 -0700
From:   Benson Leung <bleung@google.com>
To:     egranata@chromium.org
Cc:     lee.jones@linaro.org, bleung@chromium.org,
        enric.balletbo@collabora.com, groeck@chromium.org,
        linux-kernel@vger.kernel.org, gwendal@google.com, amstan@google.com
Subject: Re: [PATCH] mfd: cros_ec: Only register a positive IRQ number
Message-ID: <20190322211550.GA139120@google.com>
References: <20190321210347.34793-1-egranata@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd"
Content-Disposition: inline
In-Reply-To: <20190321210347.34793-1-egranata@chromium.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--vkogqOf2sHV7VnPd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Enrico,

On Thu, Mar 21, 2019 at 02:03:47PM -0700, egranata@chromium.org wrote:
> From: Enrico Granata <egranata@chromium.org>
>=20
> Add a layer of sanity checking to cros_ec_register against attempting to
> register IRQ values that are not strictly greater than 0.
>=20
> Signed-off-by: Enrico Granata <egranata@chromium.org>

Acked-By: Benson Leung <bleung@chromium.org>

> ---
>  drivers/mfd/cros_ec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index 6acfe036d5222..ff8984a2b8c21 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -118,7 +118,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
>  		return err;
>  	}
> =20
> -	if (ec_dev->irq) {
> +	if (ec_dev->irq > 0) {
>  		err =3D devm_request_threaded_irq(dev, ec_dev->irq, NULL,
>  				ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,
>  				"chromeos-ec", ec_dev);
> --=20
> 2.21.0.225.g810b269d1ac-goog
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--vkogqOf2sHV7VnPd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6gYDF28Li+nEiKLaHwn1ewov5lgFAlyVUIQACgkQHwn1ewov
5ljRIQ//b2ehnCbWJ5gEGNwDk0oqOELUxVUoErK6AnQ3DGWfeUIB4OSHPa1e3mu3
F3vFZyMBgjE1GSN0isadLt5KsR9ctwB7EOOPfpQgftV9sRRPGtDa/2LZyFQoCEUQ
KlfJVF/7QehfSvB/zh5XBR9GeTnx9lnRlU/90rYg6n8lf2KoTX6HZN7c1nBDlOSL
vyJMnfMQsPNUZGOShCqW2pQYtt80/edT5KHoCC/nCzVZMrdY2wlBdjEeYSvS0R7E
rIMqRb06f5Vdqm/w0FSj0/dHopKW267VeCuSiWEldUyJ+hlIaDLrVsxDcqF+YC/P
NlQ0G2M6geAZ+GPGGTEZiTLuKxVDfVrAO9v3bZ+V8TM/UpEZWCWdyydRT6v+q4Tm
2+GUJ8h1l6snPcKisXH7ZfNOqEIspWO8X4ZGsa7gU+Qx6/mtdcuyDKayBfb6FbCx
HS2OMzxJopLSOdAnVzlUVXMaz+mBjMPFx5Lw5fITzeljSfGckGBwmd1PbkjCS9QH
tkB6bm7MSG2aXxZ55HMd+yxH++2MVC9wtOMZaRZLWtoNpxmchxWyxJufVcosMFY3
pI/TAXzZ2AGruk/x5Qx/AYjWd4DXkhyD4TjKbApUJZDLdDvrCLrznOmmY9GSath5
RDi3j+w5YcCIVIUQkc88cKIZetOhF2IGA8uRsjinxd3gTYmo0js=
=8Xpd
-----END PGP SIGNATURE-----

--vkogqOf2sHV7VnPd--