Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1080482img; Fri, 22 Mar 2019 15:19:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqwxGn1cu+dXCoau/4hCIipqdvYhTfNIt4HlZlMB0HhO4Bv7+6DLn4AUioE7gfNiNptz3tiH X-Received: by 2002:a63:4907:: with SMTP id w7mr11220201pga.50.1553293147222; Fri, 22 Mar 2019 15:19:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553293147; cv=none; d=google.com; s=arc-20160816; b=MYSjfu56ZEvxe2bYWuq4GyyL4xwnoee9PwcVfFvLQPI3h3oi3EYbygsYaTVhNuJ/Px Mw+iR38Lz40+Mlac3zLP6gaFFZvo+Ik4MQUePUJhz5tvxjtwe4A7Hsxd1N8HkotWRrHF VRHrG24p0utUqJ6m9qQFQcfiFiSx654+2bSVvCze14KQiRxy45KVSQeTTbVKyRxJoQya yO6ZnSg7qu8CJDcVy6PnBuY+jGpWveJhGS0mMNKuaKxLjYpRbUnxn10FDjTLl05XJNm1 5XmjG1fr1sM6059Qg320tB79kAZfD5Fsv69TCVo3rPm6j7ALudgriwQ1T5tTmixFYrjL RknQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=LPYelOMFdboCAK+6ahCzgRfnJFFIO4kTaGnZPLS2HK8=; b=GNIl8OfgVmcS04qQ/QelzyG2Nk9RkN6b+cPRcY+NTH7uQEDDPSLxbeuaGc0635C48/ AXfTLt88XxPg6wJeNHTDnbpFRe56eeK+dKWKJ8/jrMIwGI0OwLS6ZEqe6+doBlcvWkRU lJusMaJ7i2wggx9c8808cfgS8S8BolFPdIlCyGmvRsbc/bVMRl9TRuJT/zEYJ7vADO2A TkLlvR+ZvyqCaniB1hIqbJ4STWET6n3Sts3ny7j99ZrSBSS82RTz/odzrKSJYZNzvfVN b+oGvKUfjavE6qePFRrdByqnNb+we/3C64psXGpV79/sylM3P9UDTNSeRBr2xGvkvcfH lN7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g2si7893492plo.354.2019.03.22.15.18.52; Fri, 22 Mar 2019 15:19:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728098AbfCVWQ6 (ORCPT + 99 others); Fri, 22 Mar 2019 18:16:58 -0400 Received: from muru.com ([72.249.23.125]:42206 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726205AbfCVWQ5 (ORCPT ); Fri, 22 Mar 2019 18:16:57 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9535080DB; Fri, 22 Mar 2019 22:17:10 +0000 (UTC) Date: Fri, 22 Mar 2019 15:16:54 -0700 From: Tony Lindgren To: Dan Murphy Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Sebastian Reichel Subject: Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver Message-ID: <20190322221654.GG19425@atomide.com> References: <20190321142838.22985-1-dmurphy@ti.com> <20190321142838.22985-4-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321142838.22985-4-dmurphy@ti.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Dan Murphy [190321 14:29]: > Introduce the Texas Instruments LM3532 White LED driver. > The driver supports ALS configurability or manual brightness > control. > > The driver also supports associating LED strings with specific > control banks in a group or as individually controlled strings. Thanks for getting this driver done. I need help a bit using this though.. What's the glue to the drm driver? I can control the backlight brightness just fine via /sys, and backlight shows up as the trigger in /sys/class/leds/lm3532:backlight, but /sys/class/backlight is empty and looks like drm can't find it. Do I need to enable some additional driver(s) to get this to work with the drm driver? Regards, Tony