Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1084610img; Fri, 22 Mar 2019 15:26:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHVn9OtRO/gG6ILyHcOqTCsYdf/8mhMhErPcv6D0YG6OoVyRcqYEtTZHpuDgYypbji4jkB X-Received: by 2002:a62:1f86:: with SMTP id l6mr11432612pfj.138.1553293570031; Fri, 22 Mar 2019 15:26:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553293570; cv=none; d=google.com; s=arc-20160816; b=v00Ekoi9LO4F34kbipx1A4HfzrUHFeZTKGorLqcH8S3T1KVzHSyMQl/ic63mvDZYv8 31h88ULOZ494k3MqgifIGShbYfNM6uUi1920jRmzYBnppwu76JqNmgWquXZVb5FqrIsB 9VKrlXSFluyqYG09gPgMdYf50Tq5Ed0AXlChMPKIHIFp7sfgCFfp0A8a9JoGNShOsfdx GMdoQvdut3YYnCklb6IqjzNHuNI4Oa9epyrztawp9NMVMKjCqe+HR6eXGo3iuUGfWxow MgA7flQk4FHjFdUDeBZVSkC52Vs3vRUpi7z4hvyfvyiwbSgTxWo5L+AFaKjZTE3ECoYJ q6Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UZrE85ospLrRp6b14ktOfVipRsP6Y7zSUQ3hTHU3F5Y=; b=O2njxAf4Xy1ePxivcV6PF2r6DOl/kut/5EndFBZR3PL5lL6f+tqfpB+u9xwiHqpT04 SXFHbIaCojQuPGLWAY31pdPq1LBlF6++Fx2c74XvlSjBBui1raUy9hhQMEwEjLifQfM6 o0JMtuu4uJYFNWcieuwEp2NsvuIz21bRUO7ciQfIJXS6YiGCy21UJrGopIdmA67WdnC7 yq9lp7gcWiIpmgLMBWU/V6Uk8Rn6qpwar3domFq40t2j+UhQox+OdCTdzxJCuB4j/cBF /GPTUzJkG14sXxe3vce3BgiJEN3HpHwnhX+CFLYscCR+pIKAITZLMsSP9hah1Jr/dm9u oQLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n38si7431627pgm.390.2019.03.22.15.25.54; Fri, 22 Mar 2019 15:26:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728017AbfCVWY6 (ORCPT + 99 others); Fri, 22 Mar 2019 18:24:58 -0400 Received: from muru.com ([72.249.23.125]:42240 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726205AbfCVWY6 (ORCPT ); Fri, 22 Mar 2019 18:24:58 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 50CE580DB; Fri, 22 Mar 2019 22:25:11 +0000 (UTC) Date: Fri, 22 Mar 2019 15:24:54 -0700 From: Tony Lindgren To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available Message-ID: <20190322222454.GJ19425@atomide.com> References: <1550928043-14889-1-git-send-email-Julia.Lawall@lip6.fr> <1550928043-14889-12-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550928043-14889-12-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Julia Lawall [190223 13:58]: > Add an of_node_put when a tested device node is not available. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > identifier f; > local idexpression e; > expression x; > @@ > > e = f(...); > ... when != of_node_put(e) > when != x = e > when != e = x > when any > if (<+...of_device_is_available(e)...+>) { > ... when != of_node_put(e) > ( > return e; > | > + of_node_put(e); > return ...; > ) > } > // > > Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver") > Signed-off-by: Julia Lawall Thanks applying this one into omap-for-v5.1/fixes. Regards, Tony