Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1117303img; Fri, 22 Mar 2019 16:20:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqxgbmuZS8JcIaz4kgiak1TbY4l1VrEQNd6mO+QQB8tzTM2PxA7XLl+KuIZZCpKF1TaJqBIy X-Received: by 2002:a17:902:2865:: with SMTP id e92mr12406860plb.312.1553296836587; Fri, 22 Mar 2019 16:20:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553296836; cv=none; d=google.com; s=arc-20160816; b=MYyIOun6m54TLkCSMt/MSO4ma2tN5dzZlABCfYijZaiqxydyAzMBZc1DAlO5Oy+ywb rRZc1N7qco3GKc6+jguLv9zZdGn9o8YTOMEJq8W0MH3FwffC2SwnUuFbmMIj3HZJT9Xt OW8PSmsO6QD99xZGZl3xJGL33Lz/ZZoKnVekcb1JdmZhGgqEIHQWdOqVu4Hbzg93LD5K L7C99XO18BOqxKs7W7b0sTg16aCxHVlB0jG72VSvPteGjHkcrIyTCOcCClkBgOOJhNE0 DwUNBnXt6sYHBdzMFR4YURkQjh2aiK7vhed6AalpH9PjZHbMcrZxoMHoh6HDDXYvOxr7 nR6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=t/KnKnJbjL2XdvaMbGWqEf+k3IVwRfEx/9UWeohN0wQ=; b=Dy4jKrayeFpyiuqUNCQGEuUqFmKfBHAh9DvKGA1UGcb9ou5hKMf4fhsVn3ksXFDWKL ejA4WnTyexXSEmkcDFJQKFxobQNnq8Zt91gp1zoH2bkm9Uq26vKrpzZjn53gs9rMvUBT YjpEwyyRZ7AlcLW2tmrm61cpPS9Vq6u1Y10wUdwfsJ27CN7R8slnE5EMf7HwLpnCnktl F6j7Uu/17eXufxonDkZRBRR7igMdRQlg7Clzfy4mQXfgaGLaO1oMj6w3uDhFDYIzE64O aeuIF4mTjFaKVXh9DT6zI6tJxVLek1GUhCHBIUYrIEWE68UL5v5vHe0d4YrPtQyjQijE GOgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si7742204pgn.105.2019.03.22.16.20.21; Fri, 22 Mar 2019 16:20:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728102AbfCVXS4 (ORCPT + 99 others); Fri, 22 Mar 2019 19:18:56 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:42175 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727410AbfCVXSz (ORCPT ); Fri, 22 Mar 2019 19:18:55 -0400 Received: from p5492e2fc.dip0.t-ipconnect.de ([84.146.226.252] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1h7TR1-0003nE-J7; Sat, 23 Mar 2019 00:18:47 +0100 Date: Sat, 23 Mar 2019 00:18:35 +0100 (CET) From: Thomas Gleixner To: Lubomir Rintel cc: Sebastian Reichel , Darren Hart , Rob Herring , Mark Rutland , x86@kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/10] x86, olpc: Don't split string literals when fixing up the DT In-Reply-To: <20190310162419.11861-3-lkundrak@v3.sk> Message-ID: References: <20190310162419.11861-1-lkundrak@v3.sk> <20190310162419.11861-3-lkundrak@v3.sk> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 10 Mar 2019, Lubomir Rintel wrote: Please use 'x86/platform/olpc:' as prefix in the subject. > It was pointed out in a review, and checkpatch.pl complains about this. > Breaking it down into multiple ofw evaluations works just as well, and > perhaps even reads better. perhaps? Other than that: Acked-by: Thomas Gleixner