Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <0ac4779574441c51c2a7074b4c003290b1876623.camel@perches.com>
Subject: Re: [PATCH v3] staging: ralink-gdma: Use u32 over uint32_t
From:   Joe Perches <joe@perches.com>
To:     Bharath Vedartham <linux.bhar@gmail.com>,
        gregkh@linuxfoundation.org, christian@lkamp.de
Cc:     devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date:   Fri, 22 Mar 2019 17:53:55 -0700
In-Reply-To: <20190322171330.GA13658@bharath12345-Inspiron-5559>
References: <20190322171330.GA13658@bharath12345-Inspiron-5559>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-03-22 at 22:43 +0530, Bharath Vedartham wrote:
> This fixes the checkpatch.pl warning: "Prefer u32 over uint32_t"

Please run your proposed patches through checkpatch before
submitting them.

> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> ---
> Changes since v2
> 	- Improved changelog
> 	- Thanks for the good feedback. I am a beginner. I will learn
> 	  and grow. :)

More feedback for you.

> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
[]
> @@ -157,14 +157,14 @@ static struct gdma_dma_desc *to_gdma_dma_desc(struct virt_dma_desc *vdesc)
>  	return container_of(vdesc, struct gdma_dma_desc, vdesc);
>  }
>  
> -static inline uint32_t gdma_dma_read(struct gdma_dma_dev *dma_dev,
> +static inline u32 gdma_dma_read(struct gdma_dma_dev *dma_dev,
>  				     unsigned int reg)

Please realign the line following your change.