Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH] drm: vkms: check status of alloc_ordered_workqueue
From:   Kangjie Lu <kjlu@umn.edu>
In-Reply-To: <20190309043628.6078-1-kjlu@umn.edu>
Date:   Fri, 22 Mar 2019 21:32:07 -0500
Cc:     pakki001@umn.edu, Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
        Haneen Mohammed <hamohammed.sa@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <9E681935-0B8D-4157-AED7-A851FA265BC7@umn.edu>
References: <20190309043628.6078-1-kjlu@umn.edu>
To:     kjlu@umn.edu
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Mar 8, 2019, at 10:36 PM, Kangjie Lu <kjlu@umn.edu> wrote:
>=20
> alloc_ordered_workqueue may fail and return NULL.
> The fix returns ENOMEM when it fails to avoid potential NULL
> pointer dereference.
>=20
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/gpu/drm/vkms/vkms_crtc.c | 2 ++
> 1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c =
b/drivers/gpu/drm/vkms/vkms_crtc.c
> index 8a9aeb0a9ea8..bb66dbcd5e3f 100644
> --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> @@ -219,6 +219,8 @@ int vkms_crtc_init(struct drm_device *dev, struct =
drm_crtc *crtc,
> 	spin_lock_init(&vkms_out->state_lock);
>=20
> 	vkms_out->crc_workq =3D =
alloc_ordered_workqueue("vkms_crc_workq", 0);
> +	if (!vkms_out->crc_workq)
> +		return -ENOMEM;

Is this a reasonable patch?

>=20
> 	return ret;
> }
> --=20
> 2.17.1
>=20