Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH] memstick: fix a potential NULL pointer dereference
From:   Kangjie Lu <kjlu@umn.edu>
In-Reply-To: <20190309075917.6791-1-kjlu@umn.edu>
Date:   Fri, 22 Mar 2019 22:08:37 -0500
Cc:     pakki001@umn.edu, Maxim Levitsky <maximlevitsky@gmail.com>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <11B50B8B-7A27-4BFD-B0C6-669C74381B46@umn.edu>
References: <20190309075917.6791-1-kjlu@umn.edu>
To:     kjlu@umn.edu
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Maxim,

Can you review this patch?=20

Thanks,

> On Mar 9, 2019, at 1:59 AM, Kangjie Lu <kjlu@umn.edu> wrote:
>=20
> In case alloc_ordered_workqueue fails, the fix returns ENOMEM to
> avoid potential NULL pointer dereference.
>=20
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/memstick/core/ms_block.c | 5 +++++
> 1 file changed, 5 insertions(+)
>=20
> diff --git a/drivers/memstick/core/ms_block.c =
b/drivers/memstick/core/ms_block.c
> index 82daccc9ea62..8e00de414567 100644
> --- a/drivers/memstick/core/ms_block.c
> +++ b/drivers/memstick/core/ms_block.c
> @@ -2149,6 +2149,11 @@ static int msb_init_disk(struct memstick_dev =
*card)
>=20
> 	msb->usage_count =3D 1;
> 	msb->io_queue =3D alloc_ordered_workqueue("ms_block", =
WQ_MEM_RECLAIM);
> +	if (!msb->io_queue) {
> +		rc =3D -ENOMEM;
> +		goto out_put_disk;
> +	}
> +
> 	INIT_WORK(&msb->io_work, msb_io_work);
> 	sg_init_table(msb->prealloc_sg, MS_BLOCK_MAX_SEGS+1);
>=20
> --=20
> 2.17.1
>=20