Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH] mfd: fix a potential NULL pointer dereference
From:   Kangjie Lu <kjlu@umn.edu>
In-Reply-To: <20190309080456.8579-1-kjlu@umn.edu>
Date:   Fri, 22 Mar 2019 22:09:47 -0500
Cc:     pakki001@umn.edu, Lee Jones <lee.jones@linaro.org>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <C71F9E7E-5EF8-4AE5-92D4-4596D25B1D9B@umn.edu>
References: <20190309080456.8579-1-kjlu@umn.edu>
To:     kjlu@umn.edu
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Lee Jones,

Can you review this patch?

Thanks.=20

> On Mar 9, 2019, at 2:04 AM, Kangjie Lu <kjlu@umn.edu> wrote:
>=20
> In case devm_kzalloc fails, the fix does NULL check and returns
> -ENOMEM upon failure so as to avoid NULL pointer dereference.
>=20
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/mfd/sm501.c | 3 +++
> 1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index a530972c5a7e..e0173bf4b0dc 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -1145,6 +1145,9 @@ static int =
sm501_register_gpio_i2c_instance(struct sm501_devdata *sm,
> 	lookup =3D devm_kzalloc(&pdev->dev,
> 			      sizeof(*lookup) + 3 * sizeof(struct =
gpiod_lookup),
> 			      GFP_KERNEL);
> +	if (!lookup)
> +		return -ENOMEM;
> +
> 	lookup->dev_id =3D "i2c-gpio";
> 	if (iic->pin_sda < 32)
> 		lookup->table[0].chip_label =3D "SM501-LOW";
> --=20
> 2.17.1
>=20