Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190309075917.6791-1-kjlu@umn.edu> <11B50B8B-7A27-4BFD-B0C6-669C74381B46@umn.edu>
In-Reply-To: <11B50B8B-7A27-4BFD-B0C6-669C74381B46@umn.edu>
From:   Maxim Levitsky <maximlevitsky@gmail.com>
Date:   Sat, 23 Mar 2019 09:57:32 +0200
Message-ID: <CACAwPwaPb6x0WWay5Wt5hsYumLv3sQea9Nq4GAJHJ6qLs62apQ@mail.gmail.com>
Subject: Re: [PATCH] memstick: fix a potential NULL pointer dereference
To:     Kangjie Lu <kjlu@umn.edu>
Cc:     pakki001@umn.edu, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Mar 23, 2019 at 5:08 AM Kangjie Lu <kjlu@umn.edu> wrote:
>
> Hi Maxim,
>
> Can you review this patch?
>
> Thanks,
>
> > On Mar 9, 2019, at 1:59 AM, Kangjie Lu <kjlu@umn.edu> wrote:
> >
> > In case alloc_ordered_workqueue fails, the fix returns ENOMEM to
> > avoid potential NULL pointer dereference.
> >
> > Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> > ---
> > drivers/memstick/core/ms_block.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
> > index 82daccc9ea62..8e00de414567 100644
> > --- a/drivers/memstick/core/ms_block.c
> > +++ b/drivers/memstick/core/ms_block.c
> > @@ -2149,6 +2149,11 @@ static int msb_init_disk(struct memstick_dev *card)
> >
> >       msb->usage_count = 1;
> >       msb->io_queue = alloc_ordered_workqueue("ms_block", WQ_MEM_RECLAIM);
> > +     if (!msb->io_queue) {
> > +             rc = -ENOMEM;
> > +             goto out_put_disk;
> > +     }
> > +
> >       INIT_WORK(&msb->io_work, msb_io_work);
> >       sg_init_table(msb->prealloc_sg, MS_BLOCK_MAX_SEGS+1);
> >
> > --
> > 2.17.1
> >

Looks OK to me!

Reviewed-by: Maxim Levitsky <maximlevitsky@gmail.com>

Best regards,
     Maxim Levitsky