Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1417270img; Sat, 23 Mar 2019 02:16:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqw0Uqu+zvK+HmfCcUBwkaSyRQ/fBdHwApl4O/sJBrcVapB/sTE0BWKhMKGIlhUdcV51vebW X-Received: by 2002:a63:2bd5:: with SMTP id r204mr13409767pgr.48.1553332582858; Sat, 23 Mar 2019 02:16:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553332582; cv=none; d=google.com; s=arc-20160816; b=TXL8LAGhw4kMDfrL85WplWO9htj+JtcHy5+7wq4T7wvGBgGaIUDuYzuNfAGEni6gqM S6RZLZkYO3gcFyAB2p7eVBOKuV5ZiFgW0bYTXzoPNoXFEj4psszxfpTabdSBWvHT2b+n BX6swN5SRl/EsrkmFy+Sg7FsF52EVOADPhXlAxblrS5tUZNDcYmuwdDPs9CYFLY9ORe5 5N/pJrVFzUOAxz7t/sDxb0Kn9fD2Hl+IHE44gAJh66gqzaUSbhez+17FCHZdJm2+EhGX iu6HLNRujuEeIajBuxT8w32+R6MS0cHHMNJBllYuvDhNEmrbP/InD2iD35SrcxYSEU2L 0QOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=FWG8fg16n6kJEb0gBcO8DVjVPWqH60Ih6bWewVTbp9I=; b=LokLalTZCSzDqSXWyW1+/fTqOdRbAwM1xsvHGIDG2AkUcqBpn5FCp4TV7/7hfEHzZF ddJyDoGg8hY/Phn4boUOxFgVZBdHUSOWNJdsq6ysM28McmQ1K/6g3Sz/Z7mehQmw2Rqp zgSKN3NwqDMoRQy8fF2fByY87ZJwXgs4AhI42+2HVyxRfy3cFC575CAuJVXb12XAxe4t Z4BmmKGGeeHYHO0EJr3NAnBAEtvLnfoaxC5Z5GrnGbd0Xp2ffg9b5VIgCu/UexksZPD7 Qjnpc/Df0+s+ycCxfbDAD/ZgWj3dm6S+gvn4Vn78x6R6gCYokEOyIVpWm0SfWX65deLM pFkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gInSVE8G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9si8480547pgq.173.2019.03.23.02.15.58; Sat, 23 Mar 2019 02:16:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gInSVE8G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726555AbfCWJPE (ORCPT + 99 others); Sat, 23 Mar 2019 05:15:04 -0400 Received: from mail.skyhub.de ([5.9.137.197]:58778 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbfCWJPE (ORCPT ); Sat, 23 Mar 2019 05:15:04 -0400 Received: from zn.tnic (p200300EC2F098000329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:8000:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B97B51EC0104; Sat, 23 Mar 2019 10:15:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1553332502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=FWG8fg16n6kJEb0gBcO8DVjVPWqH60Ih6bWewVTbp9I=; b=gInSVE8G7w+oUyk2JoSM2/6OynEEy0NYrM7dQc3lSUPB9XeSoN8e42a8XeP0dQDlfAE2BR oWknZBmG8k7Kx+pt2/ly4mgrWTX03rdQFqqpWvH62iyh3cIoq7TU3H19+46jiKAR4b7W2+ b39MaPWGEe/S25nyv5m0qPtCezKURNo= Date: Sat, 23 Mar 2019 10:15:05 +0100 From: Borislav Petkov To: thor.thayer@linux.intel.com Cc: mchehab@kernel.org, james.morse@arm.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC, altera: Fix S10 Double Bit Error Notification Message-ID: <20190323091505.GC23698@zn.tnic> References: <1552490842-25440-1-git-send-email-thor.thayer@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1552490842-25440-1-git-send-email-thor.thayer@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 13, 2019 at 10:27:22AM -0500, thor.thayer@linux.intel.com wrote: > From: Thor Thayer > > Stratix10 Double Bit Error Address was always read from > SDRAM Address register instead of each device's Address > register. > To determine which device had the DBE, cycle through > the EDAC devices comparing the DBE value to the db_irq > value. Once found, report the DBE Address from the device > registers as well as the device name. > Finally, notify the system via an SMC call and indicate > the panic should result in a system reboot. > Change a run-time check to a Stratix10 compile-time check > for a clean SMC notification. > > Fixes: d5fc9125566c ("EDAC, altera: Combine Stratix10 and Arria10 probe functions") > Signed-off-by: Thor Thayer > --- > drivers/edac/altera_edac.c | 69 ++++++++++++++++++++++++++++++++++------------ > drivers/edac/altera_edac.h | 20 ++++++++++++++ > 2 files changed, 72 insertions(+), 17 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.