Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 23 Mar 2019 19:30:48 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     frowand.list@gmail.com, linux-kernel@vger.kernel.org,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Tom Zanussi <tom.zanussi@linux.intel.com>,
        Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH v2] tracing: initialize variable in create_dyn_event()
Message-Id: <20190323193048.35d96b86388552b0b7f7a36d@kernel.org>
In-Reply-To: <20190322152000.0a357bb1@gandalf.local.home>
References: <1553237900-8555-1-git-send-email-frowand.list@gmail.com>
        <20190322152000.0a357bb1@gandalf.local.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 22 Mar 2019 15:20:00 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 21 Mar 2019 23:58:20 -0700
> frowand.list@gmail.com wrote:
> 
> > From: Frank Rowand <frank.rowand@sony.com>
> > 
> > Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized
> > in this function [-Wuninitialized].
> > 
> > Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework")
> > 
> > Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> 
> Applied. Thanks Frank!

Thank you Frank and Steve,

feel free to add my ack.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

> 
> -- Steve
> 
> > ---
> > 
> > changes since v1:
> >   - initialize to -ENODEV instead of 0, as suggested by Steve
> > 
> >  kernel/trace/trace_dynevent.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
> > index dd1f43588d70..fa100ed3b4de 100644
> > --- a/kernel/trace/trace_dynevent.c
> > +++ b/kernel/trace/trace_dynevent.c
> > @@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
> >  static int create_dyn_event(int argc, char **argv)
> >  {
> >  	struct dyn_event_operations *ops;
> > -	int ret;
> > +	int ret = -ENODEV;
> >  
> >  	if (argv[0][0] == '-' || argv[0][0] == '!')
> >  		return dyn_event_release(argc, argv, NULL);
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>