Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1663306img; Sat, 23 Mar 2019 08:48:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqwYBnDRjvbmP9w5p+p3up90LoQAFv5kOcho74AIOV8UcgnEHg+9w0oNo5b3eg+ltPc2XWrT X-Received: by 2002:a17:902:28a7:: with SMTP id f36mr15755077plb.169.1553356110265; Sat, 23 Mar 2019 08:48:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553356110; cv=none; d=google.com; s=arc-20160816; b=euRgP0UAJZa/adzxS7rH0GjvhUBghmaOmwi/dXRvtyk985p92orx1uqR16k4mP6ppI mqzh6wUB9vLM0rRJpa3o/JFSla7oexuxC8Wt0SQoBZ5LSuvNb/JOTq1bYYpxC647MxKw I70q9vSabCthW+zWICZn7dTabHK9BWvViuyAE2Bv8AgrR0ST1I5kdQpNIVTSUCQ0uQwf vGNPxgK6P7QhJqK1OoL6cq/Uk2PSbsruoxLbzlyCoXrzktAbZyGV39U6Pl+c0/LuXvNG UKGUBf/1i3gNnJnm7mq4UczbGHwxNwsOY5OAetld9IXadojoRU+tPgHT/qJp/wpSbYQ0 RMaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=HbhPhbLIVf5pBOuyL/DhIEkSg/RkUI1HDLQ686o01hs=; b=aHF3ZAn6M5vahm4Voibl8wO8iQTm8Ffrn4DbQ4rhkhl7Iwy9ymyHQUblQDzoEprV7u AUW4ue/asVah7lt9qooCPFDT4YDRXpFCLXjXpMf/eCNUNtr+UlDF5jGy/f+uUj75HDpC UZUjEh8OVfFdzlH1rtiHQviw/uT8YtsGMKWvC1pYZ59NSfBUzgB305kh72uYoeKWJBXI uanVVZPREd/LP2v4yHTk9QpfmGYTmKbEko2VdRsE21lJmWObQFPXzcOLETdkV7pP4Y9W KPudfJnvQS94rJ/y/ACQMk07FpEsqgsjI79y50k3CyOrg5bJoFOaFjEVIFtI61aW2zFg jLig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vPFgIIFW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d68si9150882pgc.538.2019.03.23.08.48.14; Sat, 23 Mar 2019 08:48:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vPFgIIFW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727588AbfCWPq5 (ORCPT + 99 others); Sat, 23 Mar 2019 11:46:57 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35028 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726889AbfCWPq5 (ORCPT ); Sat, 23 Mar 2019 11:46:57 -0400 Received: by mail-pf1-f194.google.com with SMTP id t21so3521204pfe.2 for ; Sat, 23 Mar 2019 08:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=HbhPhbLIVf5pBOuyL/DhIEkSg/RkUI1HDLQ686o01hs=; b=vPFgIIFWLotJk+HYP/LezUVIV1r7k2foi1ErvEPV079QPri/hrmJveiMOUtesCo8z+ aYyDNEuLcINtf94O14+N2T8vdWaZWmZDO21oluXbqc42x8nWJsj6ou3TwOHy1Tbh06B7 bz4AeAtP9ZSX9GcFL0j8M6ScajHrfh76zws+Kiccihb8dpmhvBRU7650CPTH9jEuSROK HrgZYnEsMN3A86jA0M6dMw+E0Xx5ibJnRhTyTII7GWtzeI19PR4YxsGXonbgQasb/qgh VbsfaGp7JSZX5tiPYj+V8WxppYDZ+8tIx4VP5LvcOFWBP4OpTNhlDcd2dD5usEbMUbAl VfYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=HbhPhbLIVf5pBOuyL/DhIEkSg/RkUI1HDLQ686o01hs=; b=DL6xgk+F1OSASPVtz5RZ/K0DDxNy9DVdQ4SC+84EnRVmjfHKd11HfimT1v1f8ZnQ4z 3CMDKZhpsD/efB4VAXiTIR2PZCpZUTkHtnk58N8Cy5DjLS5Qr1T96z9C8J/lH9liPbGG fWJIuwIuXzU9P8nToHX+yQJhU9i/Jb/TQQ/0JK7F0L/0Y7WLx3lFgOcs1nzS4BfTZM81 YC5pLbkewz7IcKnoVmgsS4nKHeQDjEbZDoN9P9lbzEhzDf3dm1VLTCkBRpcl/qO56ZD1 uuOcxGuEdwweE/dae0w0CtM4Un8VzdNfm5K5NcFk12fyk+uTIdSq7qZ1FRBFaZkwmg23 X/hw== X-Gm-Message-State: APjAAAVffXrXAN1mbIWEpLseCOjCQr6O7Pe1QKT4IQWBrdSF+iYg5C7H MMJ29e3t/K+KdroaYCgug7E= X-Received: by 2002:a62:1ac3:: with SMTP id a186mr14922610pfa.48.1553356016666; Sat, 23 Mar 2019 08:46:56 -0700 (PDT) Received: from bharath12345-Inspiron-5559 ([103.110.42.35]) by smtp.gmail.com with ESMTPSA id s16sm6909519pgo.69.2019.03.23.08.46.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Mar 2019 08:46:56 -0700 (PDT) Date: Sat, 23 Mar 2019 21:16:48 +0530 From: Bharath Vedartham To: gregkh@linuxfoundation.org, philipp.panzer@fau.de Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v4] staging: ralink-gdma: Use u32 over uint32_t Message-ID: <20190323154648.GA10634@bharath12345-Inspiron-5559> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the checkpatch.pl warning: "Prefer u32 over uint32_t" Signed-off-by: Bharath Vedartham --- Changes since v3 - Fixed allignment issues. - Submitted a seperate patch to change unsigned to unsigned int. - One of the allignments crosses 80 characters in a line but I feel that we may loose readability if we try to reduce the characters in the line. --- drivers/staging/ralink-gdma/ralink-gdma.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c index d78042e..0b831f8 100644 --- a/drivers/staging/ralink-gdma/ralink-gdma.c +++ b/drivers/staging/ralink-gdma/ralink-gdma.c @@ -157,14 +157,12 @@ static struct gdma_dma_desc *to_gdma_dma_desc(struct virt_dma_desc *vdesc) return container_of(vdesc, struct gdma_dma_desc, vdesc); } -static inline uint32_t gdma_dma_read(struct gdma_dma_dev *dma_dev, - unsigned int reg) +static inline u32 gdma_dma_read(struct gdma_dma_dev *dma_dev, unsigned int reg) { return readl(dma_dev->base + reg); } -static inline void gdma_dma_write(struct gdma_dma_dev *dma_dev, - unsigned reg, uint32_t val) +static inline void gdma_dma_write(struct gdma_dma_dev *dma_dev, unsigned reg, u32 val) { writel(val, dma_dev->base + reg); } @@ -283,7 +281,7 @@ static int rt305x_gdma_start_transfer(struct gdma_dmaengine_chan *chan) struct gdma_dma_dev *dma_dev = gdma_dma_chan_get_dev(chan); dma_addr_t src_addr, dst_addr; struct gdma_dma_sg *sg; - uint32_t ctrl0, ctrl1; + u32 ctrl0, ctrl1; /* verify chan is already stopped */ ctrl0 = gdma_dma_read(dma_dev, GDMA_REG_CTRL0(chan->id)); @@ -361,7 +359,7 @@ static int rt3883_gdma_start_transfer(struct gdma_dmaengine_chan *chan) struct gdma_dma_dev *dma_dev = gdma_dma_chan_get_dev(chan); dma_addr_t src_addr, dst_addr; struct gdma_dma_sg *sg; - uint32_t ctrl0, ctrl1; + u32 ctrl0, ctrl1; /* verify chan is already stopped */ ctrl0 = gdma_dma_read(dma_dev, GDMA_REG_CTRL0(chan->id)); @@ -753,7 +751,7 @@ static void gdma_dma_tasklet(unsigned long arg) static void rt305x_gdma_init(struct gdma_dma_dev *dma_dev) { - uint32_t gct; + u32 gct; /* all chans round robin */ gdma_dma_write(dma_dev, GDMA_RT305X_GCT, GDMA_REG_GCT_ARBIT_RR); @@ -767,7 +765,7 @@ static void rt305x_gdma_init(struct gdma_dma_dev *dma_dev) static void rt3883_gdma_init(struct gdma_dma_dev *dma_dev) { - uint32_t gct; + u32 gct; /* all chans round robin */ gdma_dma_write(dma_dev, GDMA_REG_GCT, GDMA_REG_GCT_ARBIT_RR); -- 2.7.4