Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1683915img; Sat, 23 Mar 2019 09:19:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqwXpYLmaUA4GFdPhO7hKMX6f2t95W88Id8YrLXMl9lNbg9H9rngA7MTjpfe9zpfdHP8nGwI X-Received: by 2002:a17:902:7c0f:: with SMTP id x15mr15346168pll.98.1553357965077; Sat, 23 Mar 2019 09:19:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553357965; cv=none; d=google.com; s=arc-20160816; b=O2faaba+5/IxACBgb/oYEk8QRrJBJ+qAFk6KQeMnwBOwLvNWlAWboPmnBFLP7eb8N6 wlTPoC6HFBfSnQsZi72FotIalJ5sYDUV1ty1KCMKzPO8H182mVR94h1CduU/EmeUa4h6 lCPi8Khmm1MJsf5fbiNlEDS9g3kDrWshiwjurZ/EGd/46BhMtw+8J9ErPNMEuA5WFL32 OZFrSaTFYtqVjo48Yp5ChR8VGyz3MfNxSmqoA4zrAQyNuNARVkNj8gfQqu1uCbZltjn1 BnDwZ6J2YejdG+3QkDvAOqIVTXbqyjHqO0VeqahsmPHXioC60UjU9KghURoXzCrT5Q3i +o/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language:in-reply-to:mime-version :user-agent:date:message-id:autocrypt:openpgp:from:references:cc:to :subject:dkim-signature; bh=Fxk6PLBzrEb6AMv0OsLqPP/74dKvMMQwN33fs/QcKLw=; b=0otbaz5ELcPhAzzKt37YcmmqQyqAG6Q2w4ZrpfFZWypT+S8lGcnfmGudKDtuMq6L5G 7hp0OM19d/MnCQrYbk+notJgnbt1vrvq851NDrZYj86jgRHKWTAKDOTPpgPezxK35jif DnH2OE8rs0D87Ia6NWrZQ+ApJdCQTOcsgWAx5g38CCVR3lJDf3l2PYOLQuAwmmrvcRxj 7cnHAx4kKCQ720C+XS4dkPJ/gGJbYQjpcCGdsbfxV74n4IfpleeEYMnbeEXOja1GOrYY XtQK5lrOe3s7bn1UBbpNn1pdteH4IB6ZESbsge2rV5SFuLOv+L2c1jBQ4UAMW3RvfGUs 7uMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b="fd/kcQhZ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d12si10268311pla.80.2019.03.23.09.19.09; Sat, 23 Mar 2019 09:19:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b="fd/kcQhZ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727718AbfCWQSf (ORCPT + 99 others); Sat, 23 Mar 2019 12:18:35 -0400 Received: from mout.web.de ([212.227.17.11]:42049 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727440AbfCWQSe (ORCPT ); Sat, 23 Mar 2019 12:18:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1553357888; bh=Fxk6PLBzrEb6AMv0OsLqPP/74dKvMMQwN33fs/QcKLw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=fd/kcQhZmoJ2s7vAPmH6HZGCLt2TbOgpE46Jx21rDlUCnP6fkrweSxnf7cx4W2P0z PK9r9kL/VMnMXLN0EPXaPuvjUXsHAzP4fpMgQIYBfg9PYtNL876hjP5RH22234IyGv s38oJJ9xM3hxGZu3EUQCjw4QpfIEwpJdCZM8/WdU= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.135.145.237]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MAdol-1hIU3v1PS7-00BsWK; Sat, 23 Mar 2019 17:18:08 +0100 Subject: Re: [v5] coccinelle: semantic code search for missing put_device() To: Masahiro Yamada , Wen Yang , Julia Lawall Cc: Gilles Muller , Nicolas Palix , Michal Marek , Yi Wang , Wen Yang , Cheng Shengyu , cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <1550217319-40418-1-git-send-email-wen.yang99@zte.com.cn> From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <1691b160-5558-d4c3-afed-5773e115c5aa@web.de> Date: Sat, 23 Mar 2019 17:17:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Provags-ID: V03:K1:LYI5KCaIHvIoNdKrw+qN+/gt/BJHI/MG+jWPbTbAGtetmLGjQ3/ K6xPmV3e7RorzPX94t1WPW0069Cg0Od45drSafDONup9Lp0vYmT33gIIzMePMUXbcLWF7j5 xIC6djy4gnxVK5OslaM1ExKNVlBfxiJ0K9v6tdI19bqoLZstIjAKBDk/BdaTUljEiGci3lE XLTV2MNL8J1NWpgZg6D8g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:epNlFZ0gQCA=:3tDqdkng0J3+Nkpm51WU7F q4hpE2Mwsjltsu7ZOZlwFQ8LKc5DjJ/6Ip8bVnp/xwynmVcIQjBLxZ/JwucpK5ASJu1JjJxnv QiOCdU9gqAP7KH6TDVu+dV9omEvo+xv5+mw/sp1UPb+VXqnBARN41jIfBs0RIWiBnS+WQN3fs +5jGVmPWi7teFMYRv99G0X7R9lZl1KAeFmwsYW0izS2ajns+/Bz/xD6AuB2d5naq3XkReOnL3 hxGA6UfD4fLsRpcQc5CIrg7PAqcGMSRtPfFZ2/6weycWTHqrBX/wCHMKrvJH10D1lRjy9UHRO yImri79YCZgUDzBSiGm1Jao+fG4BoXS8T66FsaC+liVp8PYH5Fe0j02EaAOC5TOhb9lPtZHzA s8gTWoKbPL57kZDecZHxGk6QM9i2eSCSt993HVSZ+4PMCcs83PTfrRCIIPi5qbxa3G0uWLjjE 57DlEUONy1e0Bcc9KLidgNeYo9z+/2brIjo/2sCpU7Rm+HvfzSXp01OJ7ajqvQDK62uPoH7KI BDbi8xESdjsIQRV+lvUtUxh/qP3acXuuvkZew9S5Es6WU7u67bW7GOpGtubLYVfZstlv8GJxZ 7307TrQwSjQlg58casw9W2BdvxSyDNJJrKzXjiSOpAr42Oh0sei055Q/hN5EJ2PQ3/OWzdYFs BVllvizs6L9r9Eavrv2/2WYLbf0opl4ydYeMoW5zP6oYzsBFMqGb7liAEM/TRbBMk2nCYgO2x TmPzCL1/y/+s/VlR3BbqrGFNQrIWCKl7sCSvYtkJuuwCpsjGL1OW5ZZaaOj0fxoZmXdk9IYmw QB18V8Urs61sZdFzRpXn7e2gJW/JEsDJrychazpTrpDEct1ukYAOI8IiXl8F2z9jDr0sx5QPv MKXhZwY69Tk4kenj+BujarfzqkemrMLWrE80gjEhrMqZ4XonRVvPnwMdh72MA6ZS46jz07Cf1 XJxqawVOCUA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Applied to linux-kbuild. A questionable development version was integrated for this SmPL script. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/scripts/coccinelle/free/put_device.cocci?id=da9cfb87a44da61f2403c4312916befcb6b6d7e8 https://lore.kernel.org/cocci/201902191014156680299@zte.com.cn/ Now I am curious on how such a source code analysis approach will be improved further. Which changes will get the desired acceptance? https://lore.kernel.org/patchwork/patch/1053979/ https://lore.kernel.org/lkml/1553321671-27749-1-git-send-email-wen.yang99@zte.com.cn/ https://systeme.lip6.fr/pipermail/cocci/2019-March/005679.html Regards, Markus