Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1893267img; Sat, 23 Mar 2019 15:40:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyfIdU0p5XV9scJg5Lo06fM7lnHWHHw8L5m/umEwNSyydkMUGEGHM/0DTJCQdZ+WhGtfWVB X-Received: by 2002:a62:4d43:: with SMTP id a64mr16234724pfb.157.1553380845885; Sat, 23 Mar 2019 15:40:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553380845; cv=none; d=google.com; s=arc-20160816; b=bIZQf6Yfjii2E7IxFVqxdy6qSO2OXscZSQ8/YN5p4y4SY/3a2T/QZuviopx6Wrcle6 O8DV7lujt+6K47ZvA7UZeWa/F29sKjxlVLMylqk+tdo90Ys7o1bBfUzk/tgLG/wm5XKG 7+ACLllErtrd0lWAKLTvpwlMc1ps1F6Ri39QlQb8wX4rMTZb9tOMSR3dMGqCyCJRHTML bYWs9C7mWBxbKwbYIAShQittiRXLtvmINKti+up/BpQnTpJyNhPGcrjWtxdK4NJJ9/o0 9jabbTLUrzdA8TbUinXq5Ekhqh10c1e8zKOJWcWXi8QFnkk0QKted19HgMDmIkdNjyZB BMpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=aicOTmUHmiFSYikM8BDl1oQkhVALsRhj9kFFnLcxAB4=; b=J4vrWTzubnUivN45lYsIAKvGD/la1XlWSpLjnZOMpxqrRFPjAhlQP/7Mzy8Oh41nzJ oCj3b9X8QZomFP7i/YNwPvNONRthPRqVBm3VNG2Nj4hHQCynXBK+VANuoP+RgVHBQZ20 dSIvisQ9w/63rQHijELd2A49kadjtWzvKHkkcMZnnlLi2azjn+jgG7dEhWURRpA/lV6+ Ptt2AGAQtHpdlCejks4L61BTvz884mGHlvpaZClwN7h5Jz+jbVLOUlgKPvNTlwszZupl zV6GFRr/JVMj4Tr/IqbMKkIp3PYop6A/LAT3e5bq43+QB5whWJ2g9dKr7q51taeBpNfF PLAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=m6rtzOJM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si9675656pgo.332.2019.03.23.15.40.30; Sat, 23 Mar 2019 15:40:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=m6rtzOJM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727713AbfCWWj4 (ORCPT + 99 others); Sat, 23 Mar 2019 18:39:56 -0400 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:36208 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726823AbfCWWjz (ORCPT ); Sat, 23 Mar 2019 18:39:55 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 6C4EEA9A for ; Sat, 23 Mar 2019 22:39:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4ucePQoesEWz for ; Sat, 23 Mar 2019 17:39:54 -0500 (CDT) Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 433EDA2C for ; Sat, 23 Mar 2019 17:39:54 -0500 (CDT) Received: by mail-io1-f70.google.com with SMTP id c2so4862855ioh.11 for ; Sat, 23 Mar 2019 15:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=aicOTmUHmiFSYikM8BDl1oQkhVALsRhj9kFFnLcxAB4=; b=m6rtzOJM9RbifpHFI+0N9+R/YyQly4z2ZztzncMBmD0Ob1Pp+5orMAnJHKtZEi/VKy 7U6haeWhkwcxChtNb8sOEvYzquV8kP6HNVkE8HAbZ7jf1gVXsRcie/Mpu3+c3/TTruee jEkHxep5Em1g4f3gEWH4a7jfQLhzOrTCj375S1zEmJe9R+IroWENx36cNCtG76CnUOcW q/Ij/TMZutGSXGteY49F2Y+kXJSCq8hP/ZOrQq3rX5y31U0pAifn42gLFjU2MXMlHGaI iw9Zj7D/izLv3+sGG0Yi2O/+nBqZ5w2W27MOKUjUR4ykIFhXCgvNX6kH2KWl32oEV3JO H0Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aicOTmUHmiFSYikM8BDl1oQkhVALsRhj9kFFnLcxAB4=; b=q7m2ma5YFTh8uZYGSuVQjo749pwVKafykMHTKtg1TrP5kzSboccDKarmQse5phKi3u w7XlqJdkjzQS85mI+2hbfH2pXeEtqogg/mldG624S+4WQ9JLPG9PDeovf5CVWNjjfj++ p2VPIuyedTfgs5NQTzleggcZbbBa/fiAsR+468SxtAGvLc9VhQbobULUMJrmwegDPMRl Ek5EDwKhPswK0GACzaguvU2OMdy1Nb4w9LeUfDaPfJFKcauyh/e4uOg9Dkfjuzb9Yrwv NbchkeqHAQ6lo2F4mYo1zWHU7tGd/OkzRuXlf+f6lVmcpOTIb3IpNBJmeVhhM0989CxH hkFw== X-Gm-Message-State: APjAAAXVNd3YqOMl+nXEavsPLWyznCn8tM9IvyWSotsOrBbUMzu+N/Cb wPPFZF6EFAbUytth8RPMfbB0LJgGkjk4bY/oLU4ANYuwRvMKfopKQP1yq1SYlNqQRnqOA9bBrGC i1rC4bkGi6B8WPYZqP8cut8VVjjge X-Received: by 2002:a6b:b258:: with SMTP id b85mr13230604iof.122.1553380793900; Sat, 23 Mar 2019 15:39:53 -0700 (PDT) X-Received: by 2002:a6b:b258:: with SMTP id b85mr13230592iof.122.1553380793703; Sat, 23 Mar 2019 15:39:53 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id t74sm3583130itb.11.2019.03.23.15.39.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Mar 2019 15:39:52 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Vinod Koul , Dan Williams , Peter Ujfalusi , Janusz Krzysztofik , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dma: ti: fix a missing check in omap_dma_prep_dma_cyclic Date: Sat, 23 Mar 2019 17:39:43 -0500 Message-Id: <20190323223948.13885-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is invalid when "buf_len" is not aligned with "period_len". The fix adds a check for the alignment. Signed-off-by: Kangjie Lu --- drivers/dma/ti/omap-dma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c index a4a931ddf6f6..5f0ce1975e52 100644 --- a/drivers/dma/ti/omap-dma.c +++ b/drivers/dma/ti/omap-dma.c @@ -1065,6 +1065,9 @@ static struct dma_async_tx_descriptor *omap_dma_prep_dma_cyclic( unsigned es; u32 burst; + if (buf_len % period_len) + return NULL; + if (dir == DMA_DEV_TO_MEM) { dev_addr = c->cfg.src_addr; dev_width = c->cfg.src_addr_width; -- 2.17.1