Subject: Re: swsusp with highmem, testing wanted
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pavel Machek <pavel@suse.cz>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>, seife@suse.de
In-Reply-To: <20040325120250.GC300@elf.ucw.cz>
References: <20040324235702.GA497@elf.ucw.cz>
	 <1080185300.1147.62.camel@gaston>  <20040325120250.GC300@elf.ucw.cz>
Content-Type: text/plain
Message-Id: <1080254461.1195.40.camel@gaston>
Mime-Version: 1.0
Date: Fri, 26 Mar 2004 09:41:01 +1100
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 947
Lines: 26


> I'd need to do atomic copy. (Unless someone can guarantee that during
> writing to disk, no highmem page is going to be changed...)
> 
> "copy back" during resume is done in assembly, and I'd rather not
> dealed with highmem there.

Can you make that an option ? The PPC version runs in real mode and
can perfectly copy highmem pages (with small tweaks maybe)

> OTOH, if it possible to guarantee that highmem pages do not change
> during reads/writes to disk, I might be able to get away without this
> copy.

I also think we free too much memory btw (and spend too much time
trying to free memory). Have you looked at some of Nigel stuffs in
swsusp2 ? There may be good ideas to borrow... 

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/